From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87B561A2545 for ; Fri, 14 Aug 2026 11:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786705563; cv=none; b=U+sAQ1ls5zSq7T/7j4cTE7HDjSOCqQJJzLGUGHqBR8X6xvfi176YW9ru3rp7XAWskghl3PBYBfWrlWadTA8hEhh3T9X0OgS7ErsDFSJ09s+tBN1p9YcK6Wgj238WTUa0fYGyDBTSfxE3MyrQkQAyRLs7v/q13K4iv5gpyUWNqsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786705563; c=relaxed/simple; bh=lQiwtEw+WmNvc0x52h0zqnqLcKUxwahwqFQPQSJ3WaQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q6Rr0nIyMGvgpNusvBFCLvreJxPvjfkHk5cIAtT1k0GLU7vBLSLfec+t1/iVDuvV4VupmvSuvNN4uBAVlokHOHFWNHv7xTbUu6dlyPYjOL3tDXLVVTBMIPlmscYV4LC5s0oVZyJy8lEgres0muvyYKyn1gmYVPJR/YLY1P1eK+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ILqFP6yl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F5AH2H9C; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ILqFP6yl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F5AH2H9C" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67EAbBnP1467604 for ; Fri, 14 Aug 2026 11:05:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ia1fHRv7KxysZi8styKWTgvHgU/DCGpe4M+1Zoj2WWY=; b=ILqFP6ylJr7VzIbT tSkA0buIgwtlKF/80Goe/TbopBfSp7EOXM0DN8fyuE6oc6h0CwK2LXW3yU6u/zAZ AKm6YTQfVvqJbENLGKQa7Acay2XZUPKi2/Qs4fUPAzIIMCYRzdE49iM58MU1Yg6Q XsdXoBImxWT+K4Dy9aJA4Ca4BCqsfAfhkSgQVb0UIEPKBF+F+mrKg7q1+mgXQSGe 4Gq9O9zQem4A61tneWNlHEl3m/HaoclHBqrF8iq+E95EeKMryv1Fc08LPUqqHIS5 r4oDRTbJbhJHn5pj2HQpNX1K/s6yp1SfrJGzOb8XTK5Do5H5Gp8NVn+cuYVnGr9o 9exrng== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1xexgvqp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 14 Aug 2026 11:05:52 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cbeaf07a7f1so118549a12.3 for ; Fri, 14 Aug 2026 04:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786705551; x=1787310351; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ia1fHRv7KxysZi8styKWTgvHgU/DCGpe4M+1Zoj2WWY=; b=F5AH2H9CTmu4qD6iyRZu/U8SMMEX/dFrAsG+HW9nLaCmebhUW2PTfzVyjUD3T4Vch+ twKAsAlWUUZnMOYgJOJ2oXaxKkRBvaL0+clFLqRWmXzKSCH+sYptsbQoC1z12YzGofPO ByzBu7f3A3oHnxPx6GK8IzcfWKXuWjRmRSjhANbG+RX3pflWx0PNV1mo0Fyke1bhOaoT LaR62Qz4wENFC3w2UinLVbVTwHaIs5S6Q2lwpnvYUto3EaV6OqGYZKU8YnDYKbnfzSW6 XKlK/jexW29eqGLiJnYCCaBbb0gLSoSf2/8lS8Za6soUti22ms3ss5eD5RH1hQSbu0yA SomA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786705551; x=1787310351; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ia1fHRv7KxysZi8styKWTgvHgU/DCGpe4M+1Zoj2WWY=; b=BLwPPPGvD4+NgvlG4nc8MZDsS15nxzHfNIUQWWDGlQXer9hZhWhsC/xn2GSZfhdOkk lsBvj1gwpKHjHjZdpeRVc8Vt9BFopWmdr2UcPdJlr0lPnYByrbDhSBKhLQyTYepDixo9 GYoBJ9Ji2/HIR7KDE7t1XA5KUg5NeX3HSytLLPWHiBpIwg6UdcbftNVwcAiScXdfb/rz Em+NAcwLT8xGh6Uzg19jPj0UxJgIbmbUgevqCeIcKJ8QOAHeglaDTaiI6OxUXy7iyc1c bL9du0qzwMB9DF1phlx7QtG1bt51Fd/m5oaGKzY/nACCrYmL4FgLFGBAEHIJBpEaoQNW 7D1A== X-Forwarded-Encrypted: i=1; AHgh+RoZJui+mtolETKvhAx30GKhLabwio32CeT+cmEmejxKiViGrClQ9yxH42RYOamVkUJA9WvVbnA+HkRd@vger.kernel.org X-Gm-Message-State: AOJu0Yzyejn/NXqpHDNbhn3JHnp/qLJxwQLNrcQ5Z4F09F6iZZCdkbId tb3D6kXXepnFDqnt2MHXHmRBvNYdMakYwmqeLHVtpADbIN9WxSrnjoKTcgvxIFYmqEI7sBPYJW/ GtFr6NreqV2gSha+o+ukbBSjnB7N+w5ORL9UVwgmHrDjVnjVxsLmkjA1K7qbROEBN X-Gm-Gg: AR+sD115pjxpVXlkeP+BXrJXsKGrSeCXWRaZlA5ysKZgSwRmAszIMci+yrE1W4WQwMx WmlJfzM5HaNH9p/hY1/EKyBZh8Vc1K2NsEfTSAfnaQd9PjucfGFboe1OKS4UNG6ZjmutDfyMqrt FYrCeN2kseVS+8RPuYaFdm7LESzeCYDjdovkV59a3C3Mn+YqCPYXnKQ72B5YZlp5hi0njSeoP3e UVD5VCi2QAC2+3fM9Dg07IdT6klL8E0+W8U29p85CKSaXtOyh6LfD+2XDAX5Z+dT844zcqP3DaG grxl+59vR1TseXSSOhelEMqLmVy/Yepf3T/YazvddaN/s7DnSgo+SuhZLM9q6+RMDqmzh8AcSn9 vuhXu56yOSyjcnpEwLGd1EueNjRZN9w== X-Received: by 2002:aa7:8681:0:b0:850:a86b:6ce1 with SMTP id d2e1a72fcca58-850a86b8ac4mr1694185b3a.0.1786705551326; Fri, 14 Aug 2026 04:05:51 -0700 (PDT) X-Received: by 2002:aa7:8681:0:b0:850:a86b:6ce1 with SMTP id d2e1a72fcca58-850a86b8ac4mr1694141b3a.0.1786705550748; Fri, 14 Aug 2026 04:05:50 -0700 (PDT) Received: from [10.92.210.190] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8517d01f300sm312585b3a.18.2026.08.14.04.05.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2026 04:05:50 -0700 (PDT) Message-ID: <3d8101b2-558b-48e0-badd-a8e439c74dd0@oss.qualcomm.com> Date: Fri, 14 Aug 2026 16:35:43 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] dt-bindings: arm: ras: Introduce bindings for ARM RAS error sources To: Krzysztof Kozlowski , Trilok Soni Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Ruidong Tian , Tony Luck , Borislav Petkov , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, faruque.ansari@oss.qualcomm.com, avaneesh.dwivedi@oss.qualcomm.com References: <20260720081954.1858180-1-umang.chheda@oss.qualcomm.com> <20260720081954.1858180-2-umang.chheda@oss.qualcomm.com> <20260728-determined-lorikeet-from-tartarus-cf124e@quoll> Content-Language: en-US From: Umang Chheda In-Reply-To: <20260728-determined-lorikeet-from-tartarus-cf124e@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODE0MDA4MyBTYWx0ZWRfX5vH7aUb/msH3 DRMBK7NHG8OviriPZKbUKitcqC8y1O1Q/2KfD/fZGXmzUYh9RaPE3/a1oXUJ+DGUmdzqc58bekT 8Ku5ebRuuYP4JJvQpGkiTZOwu6zI9+c= X-Proofpoint-GUID: xgl1c3o5OSMwJQYighKqxOW_lgMjxz89 X-Authority-Analysis: v=2.4 cv=eO4jSnp1 c=1 sm=1 tr=0 ts=6a7ef690 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=3LPT6PZN0yckniG3iNgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE0MDA4MyBTYWx0ZWRfXwYmJxrsGmweR 9Nm3mFPqY6GbgT+fhjfg1mavQCGGRWHrx86cX2UuXy+Gg0omaNgWBpdtXtwlxMsVRibEcUfvjxG SslY6W+Y4D2SqrPLa985cY5yD7J+JX/LKYE9x1Y/Duc5LpZjbPpSpWKZt6ja8aUJoGbQ8FqTdQ1 68RQLPdxvBUy/HypzexwNncCTibv3SDUqumoEXl2ZvIEJcmgYj4B4BNyWkLRAo1gcMcwkDusz7a GmNSjp9PEpG4iDEI6qMUwYqPSxewbDjScs7w7hHrvQLfb6kKebmx1q5EvmEcipNLEX/J8KVEdFU zQI6DPt3yB8yiMeFjFu0cFhdEuzY8e7f/wn2MD9sb8s1pyKH7zr5/wUmIAnBjhv/+AGnzabRn++ 4bW8QaAeb8Xhos0OsogQUqLIsguKuIeyn1OiD/DQOMQd9sAxF3RbhfbZ45ntTUAEiisCrrUlvnO V1+S/WXwrQJ0iLaAH0g== X-Proofpoint-ORIG-GUID: xgl1c3o5OSMwJQYighKqxOW_lgMjxz89 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-14_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608140083 Hello Krzysztof, Trilok, On 7/28/2026 2:17 PM, Krzysztof Kozlowski wrote: > On Mon, Jul 27, 2026 at 01:51:08PM -0700, Trilok Soni wrote: >> On 7/20/2026 1:19 AM, Umang Chheda wrote: >>> new file mode 100644 >>> index 000000000000..c2f4e1f8243e >>> --- /dev/null >>> +++ b/include/dt-bindings/arm/arm-ras.h >>> @@ -0,0 +1,11 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>> + >>> +#ifndef _DT_BINDINGS_ARM_RAS_H >>> +#define _DT_BINDINGS_ARM_RAS_H >>> + >>> +/* arm,group-format - error record group register window page size */ >>> +#define ARM_RAS_GROUP_4K 0 /* 4 KiB, 1 ERRGSR */ >>> +#define ARM_RAS_GROUP_16K 1 /* 16 KiB, 4 ERRGSRs */ >>> +#define ARM_RAS_GROUP_64K 2 /* 64 KiB, 14 ERRGSRs */ >> >> Do you want me to have different DT for 4k and 16k and 64k? This is not a right approach. >> > > Is this page size or register window page size? If the latter, why would > device registers be a binding? Thanks for the review. To clarify both points: On "page size" vs "register window page size": The comment in arm-ras.h is misleading — I will fix it. It is neither a memory page size nor a kernel page granularity. The 4K/16K/64K values refer to the three fixed error record group register window layouts defined by the ARM RAS architecture specification. The naming comes from the ARM spec itself which uses these sizes to describe the three possible layouts of the MMIO window. I will update the comment to make this clear. On "why would device registers be a binding": This is a static hardware property — it describes which of the three fixed register layouts the hardware block implements, and it is not self-discoverable at runtime. There is no register within the window that encodes the layout. The driver needs it upfront to: - Determine the correct ioremap size - Know how many ERRGSR registers to scan - Know the array length for arm,record-impl and arm,status-reporting I will also fix the misleading comment in arm-ras.h from "register window page size" to "error record group register window layout" in v3. > > Best regards, > Krzysztof > Thanks, Umang