From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Subject: Re: [PATCH v2 1/2] dt-bindings: backlight: lm3630a: add enable_gpios Date: Wed, 11 Sep 2019 13:44:01 -0500 Message-ID: <3d8237d0-4e36-3787-6050-b0e75f2fa8c3@ti.com> References: <20190910212909.18095-1-andreas@kemnade.info> <20190910212909.18095-2-andreas@kemnade.info> <20190911100851.f4rnldghtmly26oo@holly.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190911100851.f4rnldghtmly26oo@holly.lan> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Daniel Thompson , Andreas Kemnade Cc: lee.jones@linaro.org, jingoohan1@gmail.com, jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, "H. Nikolaus Schaller" List-Id: devicetree@vger.kernel.org Andreas On 9/11/19 5:08 AM, Daniel Thompson wrote: > On Tue, Sep 10, 2019 at 11:29:08PM +0200, Andreas Kemnade wrote: >> add enable-gpios to describe HWEN pin >> >> Signed-off-by: Andreas Kemnade > Acked-by: Daniel Thompson > >> --- >> changes in v2: add example >> .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >> index dc129d9a329e..1fa83feffe16 100644 >> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml >> @@ -29,6 +29,10 @@ properties: >> '#size-cells': >> const: 0 >> >> + enable-gpios: >> + description: GPIO to use to enable/disable the backlight (HWEN pin). >> + maxItems: 1 >> + >> required: >> - compatible >> - reg >> @@ -92,6 +96,7 @@ examples: >> i2c { >> #address-cells = <1>; >> #size-cells = <0>; >> + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; This is in the wrong place.  This is implying that the gpio is for the i2c parent This needs to go under the led-controller node below Dan >> >> led-controller@38 { >> compatible = "ti,lm3630a"; >> -- >> 2.20.1 >>