From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cristian Marussi <cristian.marussi@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: sudeep.holla@arm.com, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: firmware: arm,scmi: Add support for syspower protocol
Date: Fri, 23 Dec 2022 11:11:27 +0100 [thread overview]
Message-ID: <3d89e135-c8e4-ede4-950f-03900a660822@kernel.org> (raw)
In-Reply-To: <20221222183823.518856-5-cristian.marussi@arm.com>
On 22/12/2022 19:38, Cristian Marussi wrote:
> Add new SCMI Syspower protocol bindings definitions and example.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
> Got lost in translation probably...from txt to yaml
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
> ---
> .../devicetree/bindings/firmware/arm,scmi.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> index 1c0388da6721..f3dd77a470dd 100644
> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> @@ -111,6 +111,12 @@ properties:
> required:
> - '#power-domain-cells'
>
> + protocol@12:
> + type: object
> + properties:
> + reg:
> + const: 0x12
> +
Why? It did not got lost, it's already covered by pattern. If you refer
to particular warning, please paste it in commit msg. Otherwise it looks
incorrect.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-23 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221222183823.518856-1-cristian.marussi@arm.com>
2022-12-22 18:38 ` [PATCH 4/5] dt-bindings: firmware: arm,scmi: Add support for syspower protocol Cristian Marussi
2022-12-23 10:11 ` Krzysztof Kozlowski [this message]
2022-12-23 10:37 ` Cristian Marussi
2022-12-23 11:22 ` Krzysztof Kozlowski
2023-01-03 10:08 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d89e135-c8e4-ede4-950f-03900a660822@kernel.org \
--to=krzk@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).