From: Taniya Das <taniya.das@oss.qualcomm.com>
To: Vivek Aknurwar <vivek.aknurwar@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v2 2/2] clk: qcom: Add support for the camera clock controller (CAMCC) on Hawi
Date: Fri, 11 Sep 2026 09:55:29 +0530 [thread overview]
Message-ID: <3d8a5b6a-7393-4d9c-bff3-559e5c870011@oss.qualcomm.com> (raw)
In-Reply-To: <20260908-camcc-hawi-v2-2-f892ba1d118e@oss.qualcomm.com>
On 9/9/2026 11:31 AM, Vivek Aknurwar wrote:
> +static struct gdsc cam_cc_titan_top_cx_gdsc = {
> + .gdscr = 0x21388,
> + .en_rest_wait_val = 0x2,
> + .en_few_wait_val = 0x2,
> + .clk_dis_wait_val = 0xf,
> + .pd = {
> + .name = "cam_cc_titan_top_cx_gdsc",
> + },
> + .pwrsts = PWRSTS_OFF_ON,
> + .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
> +};
> +
I think we need to add, similar to downstream requirements.
Please check 'drivers/clk/qcom/camcc-milos.c' for example.
.needs_icc = true,
.icc_path_index = DT_ICC_TOP_GDSC,
> +static struct gdsc cam_cc_titan_top_gdsc = {
> + .gdscr = 0x21330,
> + .en_rest_wait_val = 0x2,
> + .en_few_wait_val = 0x2,
> + .clk_dis_wait_val = 0xf,
> + .pd = {
> + .name = "cam_cc_titan_top_gdsc",
> + },
> + .pwrsts = PWRSTS_OFF_ON,
> + .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
> + .parent = &cam_cc_titan_top_cx_gdsc.pd,
> +};
Here too.
--
Thanks,
Taniya Das
prev parent reply other threads:[~2026-09-11 4:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 6:01 [PATCH v2 0/2] clk: qcom: add camera clock controller support for Hawi SoC Vivek Aknurwar
2026-09-09 6:01 ` [PATCH v2 1/2] dt-bindings: clock: qcom: Add Hawi CAMCC compatible strings Vivek Aknurwar
2026-09-10 8:47 ` Krzysztof Kozlowski
2026-09-11 4:27 ` Taniya Das
2026-09-09 6:01 ` [PATCH v2 2/2] clk: qcom: Add support for the camera clock controller (CAMCC) on Hawi Vivek Aknurwar
2026-09-09 6:32 ` sashiko-bot
2026-09-10 7:27 ` Abel Vesa
2026-09-11 4:25 ` Taniya Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d8a5b6a-7393-4d9c-bff3-559e5c870011@oss.qualcomm.com \
--to=taniya.das@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=jbrunet+clk@baylibre.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_jkona@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vivek.aknurwar@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox