From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBB5EB64DC for ; Mon, 26 Jun 2023 18:58:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229788AbjFZS6A (ORCPT ); Mon, 26 Jun 2023 14:58:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229828AbjFZS57 (ORCPT ); Mon, 26 Jun 2023 14:57:59 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32FB913D for ; Mon, 26 Jun 2023 11:57:56 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4f973035d60so4622128e87.3 for ; Mon, 26 Jun 2023 11:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687805874; x=1690397874; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rCdLkrs2k8/GdjdTwOGaHO7ETa8DMcDvVAQQIXLxcIA=; b=rAeakYceWuhKPzsOkodDNmSHj+PzFIRXD01GV65oquCHX+0KTmawSHhTJ/ccJoD23H J920HjSqhstqpk+Cax6cRq/oFNe+k1enFlPu2/f+gBaSwJz+3NEXW5AHYOeY3EMXhSeS fprGmh0QEZ9xAjv8EzR9+H5JoKs/4ePJaRaLd8BbPAMOoQ/BHVOK0PC3jBB1htLkWZB6 FLW1fPo/n2Myf/hFURBbP4EjaOSbPO6gvle6a+uGf/eUhkNIpViRlh54r7y1/IY+LU+V n+Gbkp1TMWbjw/D18GCy0O/nPEtsC0WAylsr1n51VQArHto0dVK5KielJEtnZgeEmz24 MZFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687805874; x=1690397874; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rCdLkrs2k8/GdjdTwOGaHO7ETa8DMcDvVAQQIXLxcIA=; b=HTee1u3G8XR6lRWHu8RYR5iqGyH0UzM+MuWvhkh+dhg4jBBkjk1d13fFn7oUv6jNm7 l37//Y8TGWtQW+xRchXosXDNlftigsM8GwTQmB3zBSf8LClMpNZ/Xt8uTmh1QmG4B+7K pREa0c0wY5wcZNmrowXcFDUQbZhjnB+AH6831QwWGb1wOGLC8+0Tolq/1fnvyndEbrMz x0i6rKb8c8L6Iz1RgrZBCh+P+FEXJcORdA85fRBOV7zsr9xjjX+ZpNisXBE2/sXUNqfv WeegQvGoD9A+fDP+HiQicSWxjyWzr4EQq5RR8gJ/F2cbWnu4ZMGJYdRfdZ1B+/oUjuLH xgOQ== X-Gm-Message-State: AC+VfDyCiWUpbKu8AEu0MRmkt7FFl/s9pUsKSS9u2srzw0kXyGddA0Et rKbIA8w5ej9m8gNJVahje5OjTA== X-Google-Smtp-Source: ACHHUZ7+UEN56oLxNZpprzEBS8sPcmBjz5c7VRXtZgHtsWgmJKEs9PmiVBr7ZbZW5TN5i3z0lW7Tnw== X-Received: by 2002:a05:6512:2348:b0:4fb:7592:cc7a with SMTP id p8-20020a056512234800b004fb7592cc7amr2668173lfu.20.1687805874286; Mon, 26 Jun 2023 11:57:54 -0700 (PDT) Received: from [192.168.1.101] (abyk179.neoplus.adsl.tpnet.pl. [83.9.30.179]) by smtp.gmail.com with ESMTPSA id u27-20020ac248bb000000b004f861e64f24sm1225513lfg.113.2023.06.26.11.57.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jun 2023 11:57:53 -0700 (PDT) Message-ID: <3daf9990-79da-9adf-af6a-d9007c186557@linaro.org> Date: Mon, 26 Jun 2023 20:57:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125 Content-Language: en-US To: Marijn Suijten , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Krishna Manikandan , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Lux Aliaga References: <20230624-sm6125-dpu-v1-0-1d5a638cebf2@somainline.org> <20230624-sm6125-dpu-v1-6-1d5a638cebf2@somainline.org> <6bbf239f-d530-2f1e-ff52-361f7c9cc951@linaro.org> <75d64lixeawfoqbrctm4thzh73cxkvnlmnh5xgbpf277pmh3gz@zthnqvvuxmeq> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26.06.2023 19:54, Marijn Suijten wrote: > On 2023-06-26 18:16:58, Krzysztof Kozlowski wrote: >> On 25/06/2023 21:52, Marijn Suijten wrote: >>> On 2023-06-24 11:12:52, Krzysztof Kozlowski wrote: >>>> On 24/06/2023 02:41, Marijn Suijten wrote: >>>>> SM6125 is identical to SM6375 except that while downstream also defines >>>>> a throttle clock, its presence results in timeouts whereas SM6375 >>>>> requires it to not observe any timeouts. >>>> >>>> Then it should not be allowed, so you need either "else:" block or >>>> another "if: properties: compatible:" to disallow it. Because in current >>>> patch it would be allowed. >>> >>> That means this binding is wrong/incomplete for all other SoCs then. >>> clock(-name)s has 6 items, and sets `minItems: 6`. Only for sm6375-dpu > > Of course meant to say that clock(-name)s has **7** items, not 6. > >>> does it set `minItems: 7`, but an else case is missing. >> >> Ask the author why it is done like this. > > Konrad, can you clarify why other 6375 needs the throttle clk and the clock(-names) are strongly ordered so having minItems: 6 discards the last entry Konrad > >>> Shall I send a Fixes: ed41005f5b7c ("dt-bindings: display/msm: >>> sc7180-dpu: Describe SM6350 and SM6375") for that, and should maxItems: >>> 6 be the default under clock(-name)s or in an else:? >> >> There is no bug to fix. Or at least it is not yet known. Whether other >> devices should be constrained as well - sure, sounds reasonable, but I >> did not check the code exactly. > > I don't know either, but we need this information to decide whether to > use `maxItems: 6`: > > 1. Directly on the property; > 2. In an `else:` case on the current `if: sm6375-dpu` (should have the > same effect as 1., afaik); > 3. In a second `if:` case that lists all SoCS explicitly. > > Since we don't have this information, I think option 3. is the right way > to go, setting `maxItems: 6` for qcom,sm6125-dpu. > > However, it is not yet understood why downstream is able to use the > throttle clock without repercussions. > >> We talk here about this patch. > > We used this patch to discover that other SoCs are similarly > unconstrained. But if you don't want me to look into it, by all means! > Saves me a lot of time. So I will go with option 3. > > - Marijn