From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: William-tw Lin <william-tw.lin@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Kevin Hilman <khilman@kernel.org>
Cc: Project_Global_Chrome_Upstream_Group@mediatek.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 0/3] mtk-socinfo driver implementation
Date: Sun, 17 Sep 2023 10:31:26 +0200 [thread overview]
Message-ID: <3dbff750-c430-04a7-1c53-f2e327e54f2e@linaro.org> (raw)
In-Reply-To: <20230915152607.18116-1-william-tw.lin@mediatek.com>
On 15/09/2023 17:26, William-tw Lin wrote:
> This purpose of the patches is for soc-related information retrival.
> Such information includes manufacturer information, SoC name, SoC
> segment name, and SoC marketing name.
>
> Based on tag: next-20230915, linux-next/master
>
> Changes in v2:
> - Remove mtk-socinfo.h
> - Consolidate different compatibles into mediatek,socinfo
> - Move socinfo node out of MMIO bus
> - Move mtk-socinfo.yaml to hwinfo
> - Fix reviewer's comments
This is way to vague, especially that you did not fix them. You need to
list all of them. Then we will nicely see what you ignored.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-09-17 8:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 15:26 [PATCH v2 0/3] mtk-socinfo driver implementation William-tw Lin
2023-09-15 15:26 ` [PATCH v2 1/3] arm64: dts: Add node for chip info driver William-tw Lin
2023-09-15 15:26 ` [PATCH v2 2/3] soc: mediatek: mtk-socinfo: Add driver for getting chip information William-tw Lin
2023-09-17 8:30 ` Krzysztof Kozlowski
2023-09-18 20:16 ` Christophe JAILLET
2023-09-15 15:26 ` [PATCH v2 3/3] dt-bindings: hwinfo: Add mtk-socinfo driver William-tw Lin
2023-09-17 8:26 ` Krzysztof Kozlowski
2023-09-18 8:47 ` AngeloGioacchino Del Regno
2023-09-18 11:59 ` Krzysztof Kozlowski
2023-09-20 13:46 ` AngeloGioacchino Del Regno
2023-09-18 19:47 ` Rob Herring
2023-09-17 8:31 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dbff750-c430-04a7-1c53-f2e327e54f2e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=william-tw.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).