* [PATCH v2 13/14] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS
2023-09-12 13:31 [PATCH v2 00/14] Clean up RPM bus clocks remnants Konrad Dybcio
@ 2023-09-12 13:31 ` Konrad Dybcio
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2023-09-12 13:31 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Sibi Sankar, Will Deacon, Robin Murphy, Joerg Roedel,
Greg Kroah-Hartman, Wesley Cheng
Cc: Marijn Suijten, Alexey Minnekhanov, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel, linux-arm-kernel,
iommu, linux-usb, Konrad Dybcio
The PNoC clock is a clock for the entire PNoC bus, managed from
within the interconnect driver. Attaching it to MSS was a total hack.
Get rid of it and take the liberty to make the clock-names entries
more readable.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 7061a8e12c81..51db5ddcef88 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -2479,10 +2479,15 @@ mss_pil: remoteproc@2080000 {
<&gcc GCC_MSS_GPLL0_DIV_CLK>,
<&gcc GCC_MSS_SNOC_AXI_CLK>,
<&gcc GCC_MSS_MNOC_BIMC_AXI_CLK>,
- <&rpmcc RPM_SMD_PCNOC_CLK>,
<&rpmcc RPM_SMD_QDSS_CLK>;
- clock-names = "iface", "bus", "mem", "xo", "gpll0_mss",
- "snoc_axi", "mnoc_axi", "pnoc", "qdss";
+ clock-names = "iface",
+ "bus",
+ "mem",
+ "xo",
+ "gpll0_mss",
+ "snoc_axi",
+ "mnoc_axi",
+ "qdss";
resets = <&gcc GCC_MSS_RESTART>;
reset-names = "mss_restart";
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 13/14] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS
@ 2023-09-13 10:29 Yassine Oudjana
0 siblings, 0 replies; 2+ messages in thread
From: Yassine Oudjana @ 2023-09-13 10:29 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Manivannan Sadhasivam, Sibi Sankar, Will Deacon, Robin Murphy,
Joerg Roedel, Greg Kroah-Hartman, Wesley Cheng
Cc: Marijn Suijten, Alexey Minnekhanov, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel, linux-arm-kernel,
iommu, linux-usb
On 12/09/2023 4:31 pm, Konrad Dybcio wrote:
> The PNoC clock is a clock for the entire PNoC bus, managed from
> within the interconnect driver. Attaching it to MSS was a total hack.
> Get rid of it and take the liberty to make the clock-names entries
> more readable.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 7061a8e12c81..51db5ddcef88 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -2479,10 +2479,15 @@ mss_pil: remoteproc@2080000 {
> <&gcc GCC_MSS_GPLL0_DIV_CLK>,
> <&gcc GCC_MSS_SNOC_AXI_CLK>,
> <&gcc GCC_MSS_MNOC_BIMC_AXI_CLK>,
> - <&rpmcc RPM_SMD_PCNOC_CLK>,
> <&rpmcc RPM_SMD_QDSS_CLK>;
> - clock-names = "iface", "bus", "mem", "xo", "gpll0_mss",
> - "snoc_axi", "mnoc_axi", "pnoc", "qdss";
> + clock-names = "iface",
> + "bus",
> + "mem",
> + "xo",
> + "gpll0_mss",
> + "snoc_axi",
> + "mnoc_axi",
> + "qdss";
>
> resets = <&gcc GCC_MSS_RESTART>;
> reset-names = "mss_restart";
Tested-by: Yassine Oudjana <y.oudjana@protonmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-13 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-13 10:29 [PATCH v2 13/14] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS Yassine Oudjana
-- strict thread matches above, loose matches on Subject: below --
2023-09-12 13:31 [PATCH v2 00/14] Clean up RPM bus clocks remnants Konrad Dybcio
2023-09-12 13:31 ` [PATCH v2 13/14] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).