[PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name

[PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name

[Luca Weiss]

Adjust the node name to match bindings and fix the validation warning.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
index 9b7d9d04ded6..be8c8032a3b1 100644
--- a/arch/arm/boot/dts/qcom-pm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
@@ -98,7 +98,7 @@ pm8226_1: pm8226@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		pm8226_spmi_regulators: pm8226-regulators {
+		pm8226_spmi_regulators: regulators {
 			compatible = "qcom,pm8226-regulators";
 		};
 
-- 
2.37.3

[PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings

[Luca Weiss]

pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
index 33517cccee01..01f14d5f314d 100644
--- a/arch/arm/boot/dts/qcom-pm8941.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
@@ -27,7 +27,7 @@ pwrkey@800 {
 			bias-pull-up;
 		};
 
-		usb_id: misc@900 {
+		usb_id: extcon@900 {
 			compatible = "qcom,pm8941-misc";
 			reg = <0x900>;
 			interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
@@ -138,7 +138,7 @@ pm8941_iadc: adc@3600 {
 			qcom,external-resistor-micro-ohms = <10000>;
 		};
 
-		pm8941_coincell: coincell@2800 {
+		pm8941_coincell: charger@2800 {
 			compatible = "qcom,pm8941-coincell";
 			reg = <0x2800>;
 			status = "disabled";
-- 
2.37.3

Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings

[Neil Armstrong]

Hi,

On 25/09/2022 23:02, Luca Weiss wrote:
> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>   arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index 33517cccee01..01f14d5f314d 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -27,7 +27,7 @@ pwrkey@800 {
>   			bias-pull-up;
>   		};
>   
> -		usb_id: misc@900 {
> +		usb_id: extcon@900 {
>   			compatible = "qcom,pm8941-misc";
>   			reg = <0x900>;
>   			interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
> @@ -138,7 +138,7 @@ pm8941_iadc: adc@3600 {
>   			qcom,external-resistor-micro-ohms = <10000>;
>   		};
>   
> -		pm8941_coincell: coincell@2800 {
> +		pm8941_coincell: charger@2800 {
>   			compatible = "qcom,pm8941-coincell";
>   			reg = <0x2800>;
>   			status = "disabled";

I think those changes are unrelated and should be split into 2 patches.

Neil

Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings

[Krzysztof Kozlowski]

On 25/09/2022 23:02, Luca Weiss wrote:
> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>  arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index 33517cccee01..01f14d5f314d 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -27,7 +27,7 @@ pwrkey@800 {
>  			bias-pull-up;
>  		};
>  
> -		usb_id: misc@900 {
> +		usb_id: extcon@900 {

Why? extcon is Linux specific name and should not be added to DTS.
Anything requires it?


Best regards,
Krzysztof

Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings

[Neil Armstrong]

On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
> On 25/09/2022 23:02, Luca Weiss wrote:
>> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
>>
>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>> ---
>>   arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
>> index 33517cccee01..01f14d5f314d 100644
>> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
>> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
>> @@ -27,7 +27,7 @@ pwrkey@800 {
>>   			bias-pull-up;
>>   		};
>>   
>> -		usb_id: misc@900 {
>> +		usb_id: extcon@900 {
> 
> Why? extcon is Linux specific name and should not be added to DTS.
> Anything requires it?

It matches the current dt bindings:

Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml:
<snip>
    "extcon@[0-9a-f]+$":

      type: object

      $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
<snip>

Neil

> 
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings

[Krzysztof Kozlowski]

On 26/09/2022 12:04, Neil Armstrong wrote:
> On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
>>>   		};
>>>   
>>> -		usb_id: misc@900 {
>>> +		usb_id: extcon@900 {
>>
>> Why? extcon is Linux specific name and should not be added to DTS.
>> Anything requires it?
> 
> It matches the current dt bindings:

Then instead maybe let's fix it in the bindings and DTS?

Best regards,
Krzysztof

Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings

[Luca Weiss]

Hi Krzysztof,

On Montag, 26. September 2022 12:29:11 CEST Krzysztof Kozlowski wrote:
> On 26/09/2022 12:04, Neil Armstrong wrote:
> > On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
> >>>   		};
> >>> 
> >>> -		usb_id: misc@900 {
> >>> +		usb_id: extcon@900 {
> >> 
> >> Why? extcon is Linux specific name and should not be added to DTS.
> >> Anything requires it?
> > 
> > It matches the current dt bindings:
> Then instead maybe let's fix it in the bindings and DTS?

What node name do you propose? I doubt "misc" is a better name as it really 
doesn't describe anything so I don't really have a suggestion here..

Regards
Luca

> 
> Best regards,
> Krzysztof

Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings

[Krzysztof Kozlowski]

On 26/09/2022 17:07, Luca Weiss wrote:
> Hi Krzysztof,
> 
> On Montag, 26. September 2022 12:29:11 CEST Krzysztof Kozlowski wrote:
>> On 26/09/2022 12:04, Neil Armstrong wrote:
>>> On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
>>>>>   		};
>>>>>
>>>>> -		usb_id: misc@900 {
>>>>> +		usb_id: extcon@900 {
>>>>
>>>> Why? extcon is Linux specific name and should not be added to DTS.
>>>> Anything requires it?
>>>
>>> It matches the current dt bindings:
>> Then instead maybe let's fix it in the bindings and DTS?
> 
> What node name do you propose? I doubt "misc" is a better name as it really 
> doesn't describe anything so I don't really have a suggestion here..
> 

Some manufacturers call it a muic (Micro-USB IC), but maybe just
usb-detect? The role of this device is accessory and cable detection.

Best regards,
Krzysztof

Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings

[Neil Armstrong]

On 26/09/2022 12:29, Krzysztof Kozlowski wrote:
> On 26/09/2022 12:04, Neil Armstrong wrote:
>> On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
>>>>    		};
>>>>    
>>>> -		usb_id: misc@900 {
>>>> +		usb_id: extcon@900 {
>>>
>>> Why? extcon is Linux specific name and should not be added to DTS.
>>> Anything requires it?
>>
>> It matches the current dt bindings:
> 
> Then instead maybe let's fix it in the bindings and DTS?

Yes it would be preferable

> 
> Best regards,
> Krzysztof
> 

Neil

Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings

[Konrad Dybcio]

On 25.09.2022 23:02, Luca Weiss wrote:
> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>

Konrad
>  arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index 33517cccee01..01f14d5f314d 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -27,7 +27,7 @@ pwrkey@800 {
>  			bias-pull-up;
>  		};
>  
> -		usb_id: misc@900 {
> +		usb_id: extcon@900 {
>  			compatible = "qcom,pm8941-misc";
>  			reg = <0x900>;
>  			interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
> @@ -138,7 +138,7 @@ pm8941_iadc: adc@3600 {
>  			qcom,external-resistor-micro-ohms = <10000>;
>  		};
>  
> -		pm8941_coincell: coincell@2800 {
> +		pm8941_coincell: charger@2800 {
>  			compatible = "qcom,pm8941-coincell";
>  			reg = <0x2800>;
>  			status = "disabled";

[PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name to bindings

[Luca Weiss]

The pm8941-coincell node is supposed to be called 'charger'.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index d09f2954b6f9..52c1b34e7d79 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -63,7 +63,7 @@ pm8998_temp: temp-alarm@2400 {
 			#thermal-sensor-cells = <0>;
 		};
 
-		pm8998_coincell: coincell@2800 {
+		pm8998_coincell: charger@2800 {
 			compatible = "qcom,pm8941-coincell";
 			reg = <0x2800>;
 
-- 
2.37.3

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name to bindings

[Krzysztof Kozlowski]

On 25/09/2022 23:02, Luca Weiss wrote:
> The pm8941-coincell node is supposed to be called 'charger'.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name to bindings

[Konrad Dybcio]

On 25.09.2022 23:02, Luca Weiss wrote:
> The pm8941-coincell node is supposed to be called 'charger'.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>

Konrad
>  arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> index d09f2954b6f9..52c1b34e7d79 100644
> --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> @@ -63,7 +63,7 @@ pm8998_temp: temp-alarm@2400 {
>  			#thermal-sensor-cells = <0>;
>  		};
>  
> -		pm8998_coincell: coincell@2800 {
> +		pm8998_coincell: charger@2800 {
>  			compatible = "qcom,pm8941-coincell";
>  			reg = <0x2800>;
>  

Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name

[Neil Armstrong]

On 25/09/2022 23:02, Luca Weiss wrote:
> Adjust the node name to match bindings and fix the validation warning.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>   arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
> index 9b7d9d04ded6..be8c8032a3b1 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -98,7 +98,7 @@ pm8226_1: pm8226@1 {
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>   
> -		pm8226_spmi_regulators: pm8226-regulators {
> +		pm8226_spmi_regulators: regulators {
>   			compatible = "qcom,pm8226-regulators";
>   		};
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name

[Neil Armstrong]

On 25/09/2022 23:02, Luca Weiss wrote:
> Adjust the node name to match bindings and fix the validation warning.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>   arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
> index 9b7d9d04ded6..be8c8032a3b1 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -98,7 +98,7 @@ pm8226_1: pm8226@1 {
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>   
> -		pm8226_spmi_regulators: pm8226-regulators {
> +		pm8226_spmi_regulators: regulators {
>   			compatible = "qcom,pm8226-regulators";
>   		};
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name

[Krzysztof Kozlowski]

On 25/09/2022 23:02, Luca Weiss wrote:
> Adjust the node name to match bindings and fix the validation warning.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>  arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-

Thanks, I missed it in my last cleanups.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name

[Krzysztof Kozlowski]

On 26/09/2022 11:05, Krzysztof Kozlowski wrote:
> On 25/09/2022 23:02, Luca Weiss wrote:
>> Adjust the node name to match bindings and fix the validation warning.
>>
>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>> ---
>>  arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
> 
> Thanks, I missed it in my last cleanups.

No, this should be rather squashed with my cleanups:
https://lore.kernel.org/all/20220901093401.134473-3-krzysztof.kozlowski@linaro.org/

Best regards,
Krzysztof

Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name

[Krzysztof Kozlowski]

On 26/09/2022 11:12, Krzysztof Kozlowski wrote:
> On 26/09/2022 11:05, Krzysztof Kozlowski wrote:
>> On 25/09/2022 23:02, Luca Weiss wrote:
>>> Adjust the node name to match bindings and fix the validation warning.
>>>
>>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>>> ---
>>>  arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
>>
>> Thanks, I missed it in my last cleanups.
> 
> No, this should be rather squashed with my cleanups:
> https://lore.kernel.org/all/20220901093401.134473-3-krzysztof.kozlowski@linaro.org/

No, to a no, my patch was changing RPM regulators... Argh, damn that
naming...

Best regards,
Krzysztof

Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name

[Konrad Dybcio]

On 25.09.2022 23:02, Luca Weiss wrote:
> Adjust the node name to match bindings and fix the validation warning.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>

Konrad
>  arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
> index 9b7d9d04ded6..be8c8032a3b1 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -98,7 +98,7 @@ pm8226_1: pm8226@1 {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		pm8226_spmi_regulators: pm8226-regulators {
> +		pm8226_spmi_regulators: regulators {
>  			compatible = "qcom,pm8226-regulators";
>  		};
>