devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Mauderer <oss@c-mauderer.de>
To: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v3 2/2] leds: spi-byte: add single byte SPI LED driver
Date: Mon, 6 May 2019 17:29:59 +0200	[thread overview]
Message-ID: <3de252f0-de98-bec2-b233-8be1d38a4671@c-mauderer.de> (raw)
In-Reply-To: <20190506151500.GA6221@amd>

On 06/05/2019 17:15, Pavel Machek wrote:
> Hi!
> 
>>> Of course it would have been possible to make it a lot more universal by
>>> for example adding a prefix, a bit mask or other word lengths. But that
>>> would have added a lot of complexity without any actual application.
>>>
>>
>> I have to disagree here.  If this is supposed to be a universal SPI byte driver that
>> needs special handling then it is either needs to be created in a universal way or needs to be made
>> target specific.
>>
> 
> Let him be. The driver is good.
> 
> If some hardware needs more flexibility, we add it.
> 
> No need to have 1000 releases of everything.
> 
> 									Pavel
> 

Hello Pavel,

thanks for the support.

It's a pure hobby project so I have the time to add useful features or
to improve the description to make it clear what the drivers intention
is. So if we find a more useful set of features it's a good idea to
discuss it.

By the way: Although I haven't written a Linux driver yet it's not my
first open source project. So I know that there can be a lot of
different opinions and sometimes a lot of revisions. So no big risk of
scaring me away.

Best regards

Christian

  reply	other threads:[~2019-05-06 15:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-05 20:00 [PATCH v3 1/2] dt-bindings: leds: Add binding for spi-byte LED oss
2019-05-05 20:00 ` [PATCH v3 2/2] leds: spi-byte: add single byte SPI LED driver oss
2019-05-05 20:09   ` Jacek Anaszewski
2019-05-05 20:14     ` Christian Mauderer
2019-05-06 12:05   ` Dan Murphy
2019-05-06 12:59     ` Christian Mauderer
2019-05-06 14:58       ` Dan Murphy
2019-05-06 15:15         ` Pavel Machek
2019-05-06 15:29           ` Christian Mauderer [this message]
2019-05-06 17:40             ` Dan Murphy
2019-05-06 19:12               ` Christian Mauderer
2019-05-06 15:19         ` Christian Mauderer
2019-05-06 15:37           ` Dan Murphy
2019-05-06 15:42             ` Christian Mauderer
2019-05-06 16:21 ` [PATCH v3 1/2] dt-bindings: leds: Add binding for spi-byte LED Rob Herring
2019-05-06 16:28   ` Pavel Machek
2019-05-06 17:44     ` Rob Herring
2019-05-06 19:21       ` Christian Mauderer
2019-05-06 20:25         ` Pavel Machek
2019-05-07  9:52           ` Christian Mauderer
2019-05-10 19:50             ` Christian Mauderer
2019-05-10 20:42               ` Jacek Anaszewski
2019-05-11  6:56                 ` Christian Mauderer
2019-05-11  9:11                   ` Jacek Anaszewski
2019-05-06 17:03   ` Christian Mauderer
2019-05-06 17:59     ` Rob Herring
2019-05-06 19:28       ` Christian Mauderer
2019-05-06 19:06     ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3de252f0-de98-bec2-b233-8be1d38a4671@c-mauderer.de \
    --to=oss@c-mauderer.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).