* [PATCH 0/1] Increase spi-max-frequency of nor flash for roc-rk3399-pc
@ 2022-11-23 9:48 Manoj Sai
2022-11-23 9:48 ` [PATCH 1/1] arm64: dts: rockchip: increase " Manoj Sai
0 siblings, 1 reply; 6+ messages in thread
From: Manoj Sai @ 2022-11-23 9:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner
Cc: Robin Murphy, Chris Morgan, Markus Reichl, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, linux-amarula,
Da Xue, dsx724, Jagan Teki, Suniel Mahesh, Manoj Sai
change spi-max-frequency of nor flash from 10Mhz to 30Mhz for roc-rk3399-pc
Manoj Sai (1):
arm64: dts: rockchip: increase spi-max-frequency of nor flash for
roc-rk3399-pc
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc
2022-11-23 9:48 [PATCH 0/1] Increase spi-max-frequency of nor flash for roc-rk3399-pc Manoj Sai
@ 2022-11-23 9:48 ` Manoj Sai
2022-11-23 14:04 ` Heiko Stuebner
2022-11-24 7:27 ` [PATCH v2] " Manoj Sai
0 siblings, 2 replies; 6+ messages in thread
From: Manoj Sai @ 2022-11-23 9:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner
Cc: Robin Murphy, Chris Morgan, Markus Reichl, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, linux-amarula,
Da Xue, dsx724, Jagan Teki, Suniel Mahesh, Manoj Sai
Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
get reduced from 36 seconds to 20 seconds.
Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Signed-off-by: Da Xue <da.xue@libretech.co>
Signed-off-by: dsx724 <da@lessconfused.com>
---
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
index 2f4b1b2e3ac7..8fd808a0df85 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
@@ -735,7 +735,7 @@ &spi1 {
flash@0 {
compatible = "jedec,spi-nor";
reg = <0>;
- spi-max-frequency = <10000000>;
+ spi-max-frequency = <30000000>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc
2022-11-23 9:48 ` [PATCH 1/1] arm64: dts: rockchip: increase " Manoj Sai
@ 2022-11-23 14:04 ` Heiko Stuebner
2022-11-23 14:15 ` Krzysztof Kozlowski
2022-11-24 7:27 ` [PATCH v2] " Manoj Sai
1 sibling, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2022-11-23 14:04 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Manoj Sai
Cc: Robin Murphy, Chris Morgan, Markus Reichl, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, linux-amarula,
Da Xue, dsx724, Jagan Teki, Suniel Mahesh, Manoj Sai
Hi Manoj,
Am Mittwoch, 23. November 2022, 10:48:27 CET schrieb Manoj Sai:
> Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
> flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
> get reduced from 36 seconds to 20 seconds.
>
> Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> Signed-off-by: Da Xue <da.xue@libretech.co>
> Signed-off-by: dsx724 <da@lessconfused.com>
who are these other people? :-)
I.e. it looks like you're the author of the patch,
and so it should only have your Signed-off-by line.
If Da Xue and dsx724 have tested / reviewed the change, they
should respond individually to the posted patch with
either a "Reviewed-by: ..." or "Tested-by: ..." line.
Thanks
Heiko
> ---
> arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> index 2f4b1b2e3ac7..8fd808a0df85 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
> @@ -735,7 +735,7 @@ &spi1 {
> flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> - spi-max-frequency = <10000000>;
> + spi-max-frequency = <30000000>;
> };
> };
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc
2022-11-23 14:04 ` Heiko Stuebner
@ 2022-11-23 14:15 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-23 14:15 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Manoj Sai
Cc: Robin Murphy, Chris Morgan, Markus Reichl, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, linux-amarula,
Da Xue, dsx724, Jagan Teki, Suniel Mahesh
On 23/11/2022 15:04, Heiko Stuebner wrote:
> Hi Manoj,
>
> Am Mittwoch, 23. November 2022, 10:48:27 CET schrieb Manoj Sai:
>> Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
>> flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
>> get reduced from 36 seconds to 20 seconds.
>>
>> Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
>> Signed-off-by: Da Xue <da.xue@libretech.co>
>> Signed-off-by: dsx724 <da@lessconfused.com>
>
> who are these other people? :-)
moreconfused.com :)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc
2022-11-23 9:48 ` [PATCH 1/1] arm64: dts: rockchip: increase " Manoj Sai
2022-11-23 14:04 ` Heiko Stuebner
@ 2022-11-24 7:27 ` Manoj Sai
2023-01-10 14:04 ` Heiko Stuebner
1 sibling, 1 reply; 6+ messages in thread
From: Manoj Sai @ 2022-11-24 7:27 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner
Cc: Robin Murphy, Chris Morgan, Markus Reichl, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, linux-amarula,
Da Xue, dsx724, Jagan Teki, Suniel Mahesh, Manoj Sai
Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
get reduced from 36 seconds to 20 seconds.
Signed-off-by: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
---
Changes for v2:
- removed irrelevant members from the Signed-Off-By section in the commit message.
---
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
index 2f4b1b2e3ac7..8fd808a0df85 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
@@ -735,7 +735,7 @@ &spi1 {
flash@0 {
compatible = "jedec,spi-nor";
reg = <0>;
- spi-max-frequency = <10000000>;
+ spi-max-frequency = <30000000>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc
2022-11-24 7:27 ` [PATCH v2] " Manoj Sai
@ 2023-01-10 14:04 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2023-01-10 14:04 UTC (permalink / raw)
To: Rob Herring, Manoj Sai, Krzysztof Kozlowski
Cc: Heiko Stuebner, devicetree, Jagan Teki, linux-kernel,
Robin Murphy, dsx724, Chris Morgan, Suniel Mahesh, linux-amarula,
linux-arm-kernel, Markus Reichl, Da Xue, linux-rockchip
On Thu, 24 Nov 2022 12:57:14 +0530, Manoj Sai wrote:
> Increase the spi-max-frequency of nor flash from 10Mhz to 30Mhz,this improves the
> flash raw write speed by 0.9 MB/s to 1.6MB/s and the time taken to write is
> get reduced from 36 seconds to 20 seconds.
>
>
Applied, thanks!
[1/1] arm64: dts: rockchip: increase spi-max-frequency of nor flash for roc-rk3399-pc
commit: 36861fd1fa05fb9b5d9654e6ad3d325a7671b1e1
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-10 14:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-23 9:48 [PATCH 0/1] Increase spi-max-frequency of nor flash for roc-rk3399-pc Manoj Sai
2022-11-23 9:48 ` [PATCH 1/1] arm64: dts: rockchip: increase " Manoj Sai
2022-11-23 14:04 ` Heiko Stuebner
2022-11-23 14:15 ` Krzysztof Kozlowski
2022-11-24 7:27 ` [PATCH v2] " Manoj Sai
2023-01-10 14:04 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).