From: Alex Elder <elder@riscstar.com>
To: "Uwe Kleine-König" <ukleinek@kernel.org>, "Yixun Lan" <dlan@gentoo.org>
Cc: Guodong Xu <guodong@riscstar.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Conor Dooley <conor@kernel.org>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, drew@pdp7.com,
inochiama@gmail.com, geert+renesas@glider.be, heylenay@4d2.org,
tglx@linutronix.de, hal.feng@starfivetech.com,
unicorn_wang@outlook.com, duje.mihanovic@skole.hr,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev
Subject: Re: [PATCH 1/9] dt-bindings: pwm: marvell,pxa: add optional property resets
Date: Wed, 16 Apr 2025 06:33:42 -0500 [thread overview]
Message-ID: <3dfc300f-081c-4824-97c3-842f72d2a7d3@riscstar.com> (raw)
In-Reply-To: <hogqotzzpzcow2xjrwh34qcuiu7ooc2qnvlhuvexzvqkrcsfop@mhz26t5vu35p>
On 4/16/25 12:18 AM, Uwe Kleine-König wrote:
> Hello,
>
> On Tue, Apr 15, 2025 at 12:28:07PM +0000, Yixun Lan wrote:
>> maybe there are cases that users don't want to issue a reset..
>> so, want to make it optional.. I can think one example that,
>> display controller is up and working from bootloader to linux,
>> reset it will got a flicker picture..
>
> Agreed. You can just deassert the reset at probe time. That shouldn't
> interfere with a PWM that is already producing an output.
I think you're saying reset can be a required property, to be
harmlessly deasserted at probe time? Yixun was suggesting it
should not be required, because it might already be deasserted.
Anyway, I don't feel strongly either way. Maybe the DTS
maintainers can recommend what to do.
-Alex
>
>> GPG Key ID AABEFD55
>
> If you advertise your OpenPGP certificate, I recommend using the long
> id. See for example https://keys.openpgp.org/search?q=AABEFD55.
next prev parent reply other threads:[~2025-04-16 11:33 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 13:14 [PATCH 0/9] pwm: Update PWM_PXA driver for SpacemiT K1 Guodong Xu
2025-04-11 13:14 ` [PATCH 1/9] dt-bindings: pwm: marvell,pxa: add optional property resets Guodong Xu
2025-04-11 16:44 ` Conor Dooley
2025-04-15 8:52 ` Philipp Zabel
2025-04-15 9:54 ` Guodong Xu
2025-04-15 10:12 ` Yixun Lan
2025-04-15 12:11 ` Alex Elder
2025-04-15 12:28 ` Yixun Lan
2025-04-16 5:18 ` Uwe Kleine-König
2025-04-16 11:33 ` Alex Elder [this message]
2025-04-16 14:56 ` Uwe Kleine-König
2025-04-11 13:14 ` [PATCH 2/9] pwm: pxa: add optional reset control Guodong Xu
2025-04-11 13:14 ` [PATCH 3/9] dt-bindings: pwm: marvell,pxa: add support to spacemit K1 Guodong Xu
2025-04-11 16:43 ` Conor Dooley
2025-04-12 4:00 ` Guodong Xu
2025-04-11 13:14 ` [PATCH 4/9] pwm: pxa: add support for " Guodong Xu
2025-04-11 13:14 ` [PATCH 5/9] riscv: dts: spacemit: add PWM support for K1 SoC Guodong Xu
2025-04-11 13:14 ` [PATCH 6/9] riscv: dts: spacemit: Add pinctrl configurations for PWM0-PWM19 Guodong Xu
2025-04-11 22:50 ` Inochi Amaoto
2025-04-14 16:42 ` Samuel Holland
2025-04-11 13:14 ` [PATCH 7/9] riscv: dts: spacemit: Add PWM14 backlight support for BPI-F3 Guodong Xu
2025-04-11 14:05 ` Yixun Lan
2025-04-11 14:23 ` Alex Elder
2025-04-11 14:45 ` Yixun Lan
2025-04-11 23:28 ` Inochi Amaoto
2025-04-12 4:22 ` Guodong Xu
2025-04-11 22:54 ` Inochi Amaoto
2025-04-14 5:58 ` Uwe Kleine-König
2025-04-14 8:03 ` Yixun Lan
2025-04-11 13:14 ` [PATCH 8/9] pwm: Kconfig: add depends on ARCH_SPACEMIT to PWM_PXA Guodong Xu
2025-04-11 13:14 ` [PATCH 9/9] riscv: defconfig: Enable PWM support for SpacemiT K1 SoC Guodong Xu
2025-04-11 22:52 ` Inochi Amaoto
2025-04-12 4:02 ` Guodong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dfc300f-081c-4824-97c3-842f72d2a7d3@riscstar.com \
--to=elder@riscstar.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=drew@pdp7.com \
--cc=duje.mihanovic@skole.hr \
--cc=geert+renesas@glider.be \
--cc=guodong@riscstar.com \
--cc=hal.feng@starfivetech.com \
--cc=heylenay@4d2.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=ukleinek@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).