From: Dmitry Osipenko <digetx@gmail.com>
To: Ashish Mhetre <amhetre@nvidia.com>,
krzysztof.kozlowski@linaro.org, thierry.reding@gmail.com,
jonathanh@nvidia.com, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: vdumpa@nvidia.com, Snikam@nvidia.com
Subject: Re: [Patch v6 3/4] dt-bindings: memory: Update reg maxitems for tegra186
Date: Sun, 10 Apr 2022 17:21:57 +0300 [thread overview]
Message-ID: <3e044f9e-3200-bb26-897d-1977e3825c92@gmail.com> (raw)
In-Reply-To: <20220406052459.10438-4-amhetre@nvidia.com>
06.04.2022 08:24, Ashish Mhetre пишет:
> memory-controller@2c00000 {
> compatible = "nvidia,tegra186-mc";
> - reg = <0x0 0x02c00000 0x0 0xb0000>;
> + reg = <0x0 0x02c00000 0x0 0x10000>, /* MC-SID */
> + <0x0 0x02c10000 0x0 0x10000>, /* Broadcast channel */
> + <0x0 0x02c20000 0x0 0x10000>, /* MC0 */
> + <0x0 0x02c30000 0x0 0x10000>, /* MC1 */
> + <0x0 0x02c40000 0x0 0x10000>, /* MC2 */
> + <0x0 0x02c50000 0x0 0x10000>; /* MC3 */
> + reg-names = "mc-sid", "mc-broadcast", "mc0", "mc1", "mc2", "mc3";
The "mc-" prefix feels redundant to me, I'd name the regs like this:
"sid", "broadcast", "ch0", "ch1", "ch2", "ch3"
You should also add validation of the regs/reg-names to the yaml based
on SoC version. I.e. it's not enough to only bump the maxItems.
next prev parent reply other threads:[~2022-04-10 14:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 5:24 [Patch v6 0/4] memory: tegra: Add MC channels and error logging Ashish Mhetre
2022-04-06 5:24 ` [Patch v6 1/4] memory: tegra: Add memory controller channels support Ashish Mhetre
2022-04-10 14:18 ` Dmitry Osipenko
2022-04-11 6:05 ` Ashish Mhetre
2022-04-11 6:33 ` Dmitry Osipenko
2022-04-11 7:28 ` Ashish Mhetre
2022-04-11 7:35 ` Dmitry Osipenko
2022-04-11 9:18 ` Ashish Mhetre
2022-04-11 11:13 ` Dmitry Osipenko
2022-04-10 15:01 ` Dmitry Osipenko
2022-04-11 6:18 ` Ashish Mhetre
2022-04-10 15:04 ` Dmitry Osipenko
2022-04-11 6:20 ` Ashish Mhetre
2022-04-06 5:24 ` [Patch v6 2/4] memory: tegra: Add MC error logging on tegra186 onward Ashish Mhetre
2022-04-10 14:55 ` Dmitry Osipenko
2022-04-11 6:17 ` Ashish Mhetre
2022-04-06 5:24 ` [Patch v6 3/4] dt-bindings: memory: Update reg maxitems for tegra186 Ashish Mhetre
2022-04-10 14:21 ` Dmitry Osipenko [this message]
2022-04-11 6:09 ` Ashish Mhetre
2022-04-11 15:02 ` Ashish Mhetre
2022-04-11 15:29 ` Dmitry Osipenko
2022-04-11 15:41 ` Ashish Mhetre
2022-04-11 22:28 ` Dmitry Osipenko
2022-04-12 4:11 ` Ashish Mhetre
2022-04-06 5:24 ` [Patch v6 4/4] arm64: tegra: Add memory controller channels Ashish Mhetre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e044f9e-3200-bb26-897d-1977e3825c92@gmail.com \
--to=digetx@gmail.com \
--cc=Snikam@nvidia.com \
--cc=amhetre@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).