Devicetree
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Gianluca Boiano <morf3089@gmail.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Takashi Iwai <tiwai@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Baojun Xu <baojun.xu@ti.com>,
	Kevin Lu <kevin-lu@ti.com>, Sen Wang <sen@ti.com>,
	Shenghao Ding <shenghao-ding@ti.com>
Subject: Re: [PATCH v3 2/2] ASoC: codecs: add TAS2557 mono smart amplifier driver
Date: Sat, 18 Jul 2026 17:36:34 +0200	[thread overview]
Message-ID: <3e194c71-2902-462a-ac77-e55f30f3820b@web.de> (raw)
In-Reply-To: <20260717233402.414326-3-morf3089@gmail.com>

…
> +++ b/sound/soc/codecs/tas2557.c
> @@ -0,0 +1,3067 @@
> +static int tas2557_dev_read(struct tas2557_priv *tas2557, unsigned int chn,
> +			    unsigned int reg, unsigned int *value)
> +{
> +	mutex_lock(&tas2557->dev_lock);
> +	ret = tas2557_change_book_page(tas2557, chn, TAS2557_BOOK_ID(reg),
> +				       TAS2557_PAGE_ID(reg));
> +	mutex_unlock(&tas2557->dev_lock);
> +	return ret;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&tas2557->dev_lock);”?
https://elixir.bootlin.com/linux/v7.2-rc3/source/include/linux/mutex.h#L253

Regards,
Markus

      parent reply	other threads:[~2026-07-18 15:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 23:33 [PATCH v3 0/2] ASoC: codecs: add Texas Instruments TAS2557 smart amplifier driver Gianluca Boiano
2026-07-17 23:33 ` [PATCH v3 1/2] dt-bindings: sound: add Texas Instruments TAS2557 Gianluca Boiano
2026-07-17 23:34 ` [PATCH v3 2/2] ASoC: codecs: add TAS2557 mono smart amplifier driver Gianluca Boiano
2026-07-17 23:47   ` sashiko-bot
2026-07-18 15:36   ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e194c71-2902-462a-ac77-e55f30f3820b@web.de \
    --to=markus.elfring@web.de \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kevin-lu@ti.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=morf3089@gmail.com \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=sen@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox