From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Fabrice Gasnier <fabrice.gasnier-qxv4g6HH51o@public.gmane.org>,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
alexandre.torgue-qxv4g6HH51o@public.gmane.org,
knaack.h-Mmb7MZpHnFY@public.gmane.org,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
benjamin.gaignard-qxv4g6HH51o@public.gmane.org,
linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [RFC 4/4] iio: trigger: add GPIO trigger
Date: Sat, 18 Feb 2017 19:19:07 +0000 [thread overview]
Message-ID: <3e2653fe-874c-d761-b274-ffe889df18a7@kernel.org> (raw)
In-Reply-To: <06f74b54-91fa-31c5-f015-52a6524059ef-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
On 17/02/17 16:16, Lars-Peter Clausen wrote:
> On 02/17/2017 05:03 PM, Fabrice Gasnier wrote:
>> GPIOs can be used to generate triggers for any IIO device.
>> Introduce generic GPIO trigger driver. It offers some options
>> to tune polarity (e.g. rising/falling edge), and label so trigger
>> name may be customized.
>> By default, gpio triggers will be named gpiotrigX, where X is gpio
>> number as returned by desc_to_gpio() call.
>> Rising edge is selected if polarity isn't set.
>
> If you want to use the GPIO only as an interrupt, just use it as an
> interrupt directly, no need to go the route via the GPIO.
Absolutely. The majority of the bindings will then just become standard
interrupt bindings and will be effectively handled for you.
Please work to extend the existing interrupt trigger driver rather than adding
this new one. That one actually started as a gpio trigger then got
generalised into a interrupt trigger later so lets not do that again ;)
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-18 19:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 16:03 [RFC 0/4] iio: trigger: Add OF support and GPIO based trigger Fabrice Gasnier
2017-02-17 16:03 ` [RFC 1/4] dt-bindings: iio: introduce trigger providers, consumers Fabrice Gasnier
2017-02-17 16:03 ` [RFC 2/4] iio: trigger: add OF support Fabrice Gasnier
2017-02-17 16:03 ` [RFC 3/4] dt-bindings: iio: add support for GPIO triggers Fabrice Gasnier
[not found] ` <1487347429-31761-4-git-send-email-fabrice.gasnier-qxv4g6HH51o@public.gmane.org>
2017-02-18 19:22 ` Jonathan Cameron
2017-02-23 15:03 ` Linus Walleij
[not found] ` <CACRpkdaFLMDhYZJrO=-MuSG31aO5vOZ2KX3_c95jzze46pymmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-23 15:45 ` Fabrice Gasnier
2017-02-17 16:03 ` [RFC 4/4] iio: trigger: add GPIO trigger Fabrice Gasnier
[not found] ` <1487347429-31761-5-git-send-email-fabrice.gasnier-qxv4g6HH51o@public.gmane.org>
2017-02-17 16:16 ` Lars-Peter Clausen
[not found] ` <06f74b54-91fa-31c5-f015-52a6524059ef-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2017-02-18 19:19 ` Jonathan Cameron [this message]
[not found] ` <3e2653fe-874c-d761-b274-ffe889df18a7-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-02-20 16:24 ` Fabrice Gasnier
[not found] ` <03234803-c75d-bd1a-492b-761c0d5218ff-qxv4g6HH51o@public.gmane.org>
2017-02-25 16:21 ` Jonathan Cameron
[not found] ` <1487347429-31761-1-git-send-email-fabrice.gasnier-qxv4g6HH51o@public.gmane.org>
2017-02-17 16:23 ` [RFC 0/4] iio: trigger: Add OF support and GPIO based trigger Daniel Baluta
2017-02-18 19:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e2653fe-874c-d761-b274-ffe889df18a7@kernel.org \
--to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=alexandre.torgue-qxv4g6HH51o@public.gmane.org \
--cc=benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=benjamin.gaignard-qxv4g6HH51o@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=fabrice.gasnier-qxv4g6HH51o@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).