From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 580F3C43334 for ; Tue, 5 Jul 2022 14:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231932AbiGEO1g (ORCPT ); Tue, 5 Jul 2022 10:27:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231382AbiGEO1e (ORCPT ); Tue, 5 Jul 2022 10:27:34 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 298FCE3A for ; Tue, 5 Jul 2022 07:27:33 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id l7so13991177ljj.4 for ; Tue, 05 Jul 2022 07:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=cq+rwG5GlUu183kF9O9RM161Z2xkyctrzWRCkzqLHRA=; b=ETPZ2xI6tl+nu08jgqeul7MugHkuS70DC1p+sN8Nmnf0r8zuH//FUYkyGQUHTCy2uV lT4uOu9IXXw4wm4vjo1+QfgNmXShQythbfbJEDAfeFDfu0LA/hpZu2VysB0/P3WFbhPp Py0Iw0V3wRAxiaj7oyzDDGt+NnN011pt3eLODl89C66EGV4u5qRfNT0+777BkepB8h6t sCIiTxtZD6RzAgk/+wni+ccIWlbOxgcM4/FDdllMhiUf3w9LD7kMlxz1fS5M36i00pmd 6apDoQCdciU/ZPUd218M20IWCO5xoQkH7pKzgZziDiN0EKyeFqG1JQ4n+HRBUx2Upubl cRPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cq+rwG5GlUu183kF9O9RM161Z2xkyctrzWRCkzqLHRA=; b=1TLsDptsDMYCh9AdqD+5dZ7A6pGZKBhiiaYpb9RaI2hdB05fJ3tKszA9O4jyJz4GqW DvVNamfIZtS+4AM2JSqzpvscKGjp5URRJgEZYxpbdlE93VuiO6xO8WwGYjH0B9Qe0659 Pc74D0d+4Bg+8VntfSoS8EuR33fdq+NMq0OwvcL4YggpN+oZkhSmNZwdBGsJUTNOsHOC 4hW54AW3j5DzDpbAapWi7xIpyHlFu/x9WusVhYkVnNrnYQsDptZ1i72vq7WRTHvYvmYI rShJLjeXp3PqOviQdW8DDsIBa6sEWb5TZdpxPJ+zpFd0uav3cgp77aITnk4Ho682VAbW EljA== X-Gm-Message-State: AJIora9bTzs+3VleGyyaPJT5jJXY3f9zwki5LubFdTBmEZ7CmlfTfiGX 4O1rp43sxxwdSdQbz7uYq0sT6A== X-Google-Smtp-Source: AGRyM1tjXaQxw2mEkj/bUlJ/hl3fhMF5vUOSsIl5m3rHYUUrzbIO0Cvzt7BPdZh5Xh4tSW+wmYPvGQ== X-Received: by 2002:a2e:b94e:0:b0:25b:b99f:4f58 with SMTP id 14-20020a2eb94e000000b0025bb99f4f58mr19250754ljs.263.1657031250676; Tue, 05 Jul 2022 07:27:30 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id j11-20020a056512344b00b00484e9e254c4sm74818lfr.100.2022.07.05.07.27.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 07:27:30 -0700 (PDT) Message-ID: <3e2c2b6b-713b-e613-9712-0b9c6d8ba8cc@linaro.org> Date: Tue, 5 Jul 2022 16:27:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v13 2/3] dt-bindings: usb: Add analogix anx7411 PD binding Content-Language: en-US To: Xin Ji , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski Cc: bliang@analogixsemi.com, qwen@analogixsemi.com, jli@analogixsemi.com, Rob Herring , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220705053657.2340274-1-xji@analogixsemi.com> <20220705053657.2340274-2-xji@analogixsemi.com> From: Krzysztof Kozlowski In-Reply-To: <20220705053657.2340274-2-xji@analogixsemi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/07/2022 07:36, Xin Ji wrote: > Add analogix PD chip anx7411 device binding > > Reviewed-by: Rob Herring > Signed-off-by: Xin Ji > > --- > v12 -> v13 : > 1. Drop the quotes for "$id" and "$schema" > 2. Remove "allOf" label > 3. Change node name from "i2c1" to "i2c" > 4. Change node name from "typec" to "usb-typec" > --- > .../bindings/usb/analogix,anx7411.yaml | 76 +++++++++++++++++++ > 1 file changed, 76 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > > diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > new file mode 100644 > index 000000000000..57429864d499 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/analogix,anx7411.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analogix ANX7411 Type-C controller bindings > + > +maintainers: > + - Xin Ji > + > +properties: > + compatible: > + enum: > + - analogix,anx7411 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + connector: > + type: object > + $ref: ../connector/usb-connector.yaml > + description: > + Properties for usb c connector. > + > + properties: > + compatible: > + const: usb-c-connector > + > + power-role: true > + > + data-role: true > + > + try-power-role: true > + > + required: > + - compatible > + > +required: > + - compatible > + - reg > + - connector > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb-typec: anx7411@2C { 1. node name is still not correct. 2. lowercase hex, so @2c. > + compatible = "analogix,anx7411"; > + reg = <0x2C>; lowercase hex > + interrupts = <8 IRQ_TYPE_EDGE_FALLING>; > + interrupt-parent = <&gpio0>; > + > + typec_con: connector { > + compatible = "usb-c-connector"; > + power-role = "dual"; > + data-role = "dual"; > + try-power-role = "source"; The DT schema requires ports property and just "port" is not accepted. > + > + port { > + typec_con_ep: endpoint { > + remote-endpoint = <&usbotg_hs_ep>; > + }; > + }; > + }; > + }; > + }; > +... Best regards, Krzysztof