Re: [PATCH v4] arm64: dts: imx8mn-bsh-smm-s2pro: Add tlv320aic31xx audio card node

[Ariel D'Alessandro <ariel.dalessandro@collabora.com>]

Hi Fabio, Shawn,

Can we merge this please?

Thanks,
Ariel

On 3/25/22 10:56, Ariel D'Alessandro wrote:
> Hi Fabio,
> 
> On 3/25/22 10:49, Fabio Estevam wrote:
>> On Wed, Mar 23, 2022 at 10:56 AM Ariel D'Alessandro
>> <ariel.dalessandro@collabora.com> wrote:
>>>
>>> BSH SystemMaster (SMM) S2 PRO board comes with an audio card based on
>>> tlv320aic31xx family codec.
>>>
>>> The audio card exposes two playback devices, one of them using the EASRC
>>> (Enhanced Asynchronous Sample Rate Converter) module. Note that this
>>> would require SDMA and EASRC firmware in order to work.
>>>
>>> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
>>> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
>>> ---
>>
>> What are the changes in v4?
> 
> * Fixed the sound-tlv320aic31xx audio-codec property to point to the
> right codec node <&tlv320dac3101>
> 
> * Reordered properties in tlv320dac3101, and removed clock-names property.
> 
>>
>> I see you removed 'clock-names' so this looks good:
> 
> Indeed.
> 
>>
>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> 
> Thanks!