From: <Tudor.Ambarus@microchip.com>
To: <krzysztof.kozlowski@linaro.org>, <p.yadav@ti.com>,
<michael@walle.cc>, <miquel.raynal@bootlin.com>, <richard@nod.at>,
<vigneshr@ti.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
Date: Mon, 11 Apr 2022 08:30:33 +0000 [thread overview]
Message-ID: <3e550deb-7c27-894b-a0b5-62609a60f17f@microchip.com> (raw)
In-Reply-To: <20220408063720.12826-1-krzysztof.kozlowski@linaro.org>
On 4/8/22 09:37, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, few properties are
> redundant.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> ---
>
> Changes since v1:
> 1. Do not remove address/size cells (Rob).
> 2. Add Pratyush review.
> ---
> Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> index 4abfb4cfc157..7149784a36ac 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -50,10 +50,6 @@ properties:
> minItems: 1
> maxItems: 2
>
> - spi-max-frequency: true
> - spi-rx-bus-width: true
> - spi-tx-bus-width: true
> -
> m25p,fast-read:
> type: boolean
> description:
> @@ -74,8 +70,6 @@ properties:
> be used on such systems, to denote the absence of a reliable reset
> mechanism.
>
> - label: true
> -
> partitions:
> type: object
>
> @@ -99,8 +93,6 @@ examples:
> #size-cells = <0>;
>
> flash@0 {
> - #address-cells = <1>;
> - #size-cells = <1>;
> compatible = "spansion,m25p80", "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <40000000>;
> --
> 2.32.0
>
next prev parent reply other threads:[~2022-04-11 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 6:37 [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties Krzysztof Kozlowski
2022-04-08 21:23 ` Rob Herring
2022-04-11 8:30 ` Tudor.Ambarus [this message]
2022-04-11 8:57 ` [PATCH v2] dt-bindings: mtd: jedec, spi-nor: " Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e550deb-7c27-894b-a0b5-62609a60f17f@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).