devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
@ 2022-04-08  6:37 Krzysztof Kozlowski
  2022-04-08 21:23 ` Rob Herring
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-08  6:37 UTC (permalink / raw)
  To: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
	Richard Weinberger, Vignesh Raghavendra, Rob Herring,
	Krzysztof Kozlowski, linux-mtd, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

After conversion the jedec,spi-nor DT schema to reference other schemas
(SPI and MTD) and use unevaluatedProperties, few properties are
redundant.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>

---

Changes since v1:
1. Do not remove address/size cells (Rob).
2. Add Pratyush review.
---
 Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
index 4abfb4cfc157..7149784a36ac 100644
--- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
+++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
@@ -50,10 +50,6 @@ properties:
     minItems: 1
     maxItems: 2
 
-  spi-max-frequency: true
-  spi-rx-bus-width: true
-  spi-tx-bus-width: true
-
   m25p,fast-read:
     type: boolean
     description:
@@ -74,8 +70,6 @@ properties:
       be used on such systems, to denote the absence of a reliable reset
       mechanism.
 
-  label: true
-
   partitions:
     type: object
 
@@ -99,8 +93,6 @@ examples:
         #size-cells = <0>;
 
         flash@0 {
-            #address-cells = <1>;
-            #size-cells = <1>;
             compatible = "spansion,m25p80", "jedec,spi-nor";
             reg = <0>;
             spi-max-frequency = <40000000>;
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
  2022-04-08  6:37 [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties Krzysztof Kozlowski
@ 2022-04-08 21:23 ` Rob Herring
  2022-04-11  8:30 ` Tudor.Ambarus
  2022-04-11  8:57 ` [PATCH v2] dt-bindings: mtd: jedec, spi-nor: " Miquel Raynal
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-04-08 21:23 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Pratyush Yadav, linux-kernel, Krzysztof Kozlowski, Rob Herring,
	Richard Weinberger, Miquel Raynal, devicetree,
	Vignesh Raghavendra, Michael Walle, Tudor Ambarus, linux-mtd

On Fri, 08 Apr 2022 08:37:20 +0200, Krzysztof Kozlowski wrote:
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, few properties are
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
> 
> ---
> 
> Changes since v1:
> 1. Do not remove address/size cells (Rob).
> 2. Add Pratyush review.
> ---
>  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 8 --------
>  1 file changed, 8 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
  2022-04-08  6:37 [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties Krzysztof Kozlowski
  2022-04-08 21:23 ` Rob Herring
@ 2022-04-11  8:30 ` Tudor.Ambarus
  2022-04-11  8:57 ` [PATCH v2] dt-bindings: mtd: jedec, spi-nor: " Miquel Raynal
  2 siblings, 0 replies; 4+ messages in thread
From: Tudor.Ambarus @ 2022-04-11  8:30 UTC (permalink / raw)
  To: krzysztof.kozlowski, p.yadav, michael, miquel.raynal, richard,
	vigneshr, robh+dt, krzysztof.kozlowski+dt, linux-mtd, devicetree,
	linux-kernel

On 4/8/22 09:37, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, few properties are
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Pratyush Yadav <p.yadav@ti.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> 
> ---
> 
> Changes since v1:
> 1. Do not remove address/size cells (Rob).
> 2. Add Pratyush review.
> ---
>  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> index 4abfb4cfc157..7149784a36ac 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -50,10 +50,6 @@ properties:
>      minItems: 1
>      maxItems: 2
> 
> -  spi-max-frequency: true
> -  spi-rx-bus-width: true
> -  spi-tx-bus-width: true
> -
>    m25p,fast-read:
>      type: boolean
>      description:
> @@ -74,8 +70,6 @@ properties:
>        be used on such systems, to denote the absence of a reliable reset
>        mechanism.
> 
> -  label: true
> -
>    partitions:
>      type: object
> 
> @@ -99,8 +93,6 @@ examples:
>          #size-cells = <0>;
> 
>          flash@0 {
> -            #address-cells = <1>;
> -            #size-cells = <1>;
>              compatible = "spansion,m25p80", "jedec,spi-nor";
>              reg = <0>;
>              spi-max-frequency = <40000000>;
> --
> 2.32.0
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: mtd: jedec, spi-nor: remove unneeded properties
  2022-04-08  6:37 [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties Krzysztof Kozlowski
  2022-04-08 21:23 ` Rob Herring
  2022-04-11  8:30 ` Tudor.Ambarus
@ 2022-04-11  8:57 ` Miquel Raynal
  2 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2022-04-11  8:57 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Tudor Ambarus, Pratyush Yadav, Michael Walle,
	Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
	Rob Herring, Krzysztof Kozlowski, linux-mtd, devicetree,
	linux-kernel

On Fri, 2022-04-08 at 06:37:20 UTC, Krzysztof Kozlowski wrote:
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, few properties are
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-04-11  8:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-08  6:37 [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties Krzysztof Kozlowski
2022-04-08 21:23 ` Rob Herring
2022-04-11  8:30 ` Tudor.Ambarus
2022-04-11  8:57 ` [PATCH v2] dt-bindings: mtd: jedec, spi-nor: " Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).