From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EABDA221F24; Sun, 3 May 2026 02:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777776573; cv=none; b=nNhx7zkW8QISv16bWR1IbL3C3z4Id8VetUdnasTNjMVU9SRf2acfKZd+v4ycivHiLY0nB0evWjY1hKgIAcYupmB7G7mG6zfPQrdAoKLHfUINpsOZgHbpZag+fui16cyIVHlFzWhc/S0KQInOcNuu/u4avcqBxzLVLn3zAmEhQHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777776573; c=relaxed/simple; bh=GFGdjCNf3F5kPxCTiB48JwetFydKfpJwz84jgiWDQos=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D/lMyCaJHiGwxZPPWOIMIY/802mIR37jtKvnTIhuXvvlot8fpcpfC5hkFUiJ3QZ1TOIrUkZDDJZGivRF4iG8vpjQjPAhsbsjzQF0OORfqoTHIzSqm6nbTFMRBRjY9vLc55RG/Z7wjF3AlrDVrbAxxTyVGbjRWGqXUBz1NLhKZow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=XWLuIj4W; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="XWLuIj4W" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=YmcxZf7SutD2K2WWcfwCmG8slAmsQJ99Yyc78yb8540=; b=XWLuIj4WipvGPsgidcptl/Qh5N U+weMbENiXqUhZ9K+Huxv3/eFR240BNp8ysGxJUv5weTFCmXBQJGDCLuNAubJCXHxy2cX7WXz2k3j OSsuuVcLs2dG3en05lRl41CWSaZ0IdcY0XVOyrk3VAoopjAUPxvah4wC+M7cYy7dpHHY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wJMst-00158d-Un; Sun, 03 May 2026 04:48:43 +0200 Date: Sun, 3 May 2026 04:48:43 +0200 From: Andrew Lunn To: Alex Elder Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 09/12] gpio: tc956x: add TC956x/QPS615 support Message-ID: <3e5a42cc-53b8-4065-a32a-d754be40b4c7@lunn.ch> References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-10-elder@riscstar.com> <736fb3b7-c88a-4ec4-96ad-d1b79cc48d30@lunn.ch> <30cec7dd-ac3c-47ab-896a-c29992bd5ba5@riscstar.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30cec7dd-ac3c-47ab-896a-c29992bd5ba5@riscstar.com> > It's possible gpio-regmap.c *could* be used. We started with > vendor code and this code got separated at some point along > the way. It was working, and I don't think I pursued other > options at that point. I'll look at this possibility before we > send out the next version. The GPIO subsystem has made a big effort to provide generic code, since GPIOs are pretty simple things with a lot in common. So if the generic code works, or can be made to work with minor changes, you should use it. > What do you mean instantiate it twice? I _think_ you need one instance for the first 32 GPIOs, and a second one for the remaining GPIOs. But maybe config->reg_stride might allow it to work with a single instance? Andrew