From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy McNicoll Subject: Re: [RFC V3 PATCH 5/7] arm64: dts: msm8994 SoC and Huawei Angler (Nexus 6P) support Date: Wed, 12 Oct 2016 17:42:38 -0700 Message-ID: <3e641d25-8ca6-3594-5d3e-038d6f7a9eba@redhat.com> References: <1476265054-22511-1-git-send-email-jeremymc@redhat.com> <1476265054-22511-6-git-send-email-jeremymc@redhat.com> <20161012133450.GC21050@remoulade> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring , Mark Rutland Cc: Jeremy McNicoll , linux-arm-msm , linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Andy Gross , Stephen Boyd , Arnd Bergmann , Bjorn Andersson List-Id: devicetree@vger.kernel.org On 2016-10-12 7:20 AM, Rob Herring wrote: > On Wed, Oct 12, 2016 at 8:34 AM, Mark Rutland wrote: >> On Wed, Oct 12, 2016 at 02:37:32AM -0700, Jeremy McNicoll wrote: >>> +/ { >>> + model = "HUAWEI MSM8994 ANGLER rev-1.01"; >>> + compatible = "qcom,msm8994"; >>> + qcom,board-id= <8026 0>; >>> +}; >> >> This last property is undocumented, and unused. > > They are required by the bootloader which AIUI can't/won't be updated > to use the mainline compatible string. The alternative is leave them That is my understanding as well after talking to some QC people over beer the other night. > out and then you have to run the dtb thru QC's dtbTool to add them > which is worse IMO. > If there is an expectation that one has to run the dtbTool as a post compilation thing, in my opinion its not a good idea. But if that is the path that is decided (not my personal favourite) then we should at least let people know somehow that they have to run this tool in order to boot their kernel. (dont like that either) Its already hard enough to get debug serial going, or figuring out how to get serial debug out. We should make it as easy as possible for people that want to contribute and help. Google did _NOT_ lock down these phones on purpose so that people can do what they want with them (within reason). The fewer barriers to entry the better. > I'd also leave them undocumented as we want to minimize their usage. > I agree with this and will leave policing of their usage to RobH ;-) -jeremy > Rob > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html