From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8815C433E0 for ; Thu, 11 Mar 2021 13:03:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5823B64FC3 for ; Thu, 11 Mar 2021 13:03:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233184AbhCKNCe (ORCPT ); Thu, 11 Mar 2021 08:02:34 -0500 Received: from gecko.sbs.de ([194.138.37.40]:60534 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233386AbhCKNCQ (ORCPT ); Thu, 11 Mar 2021 08:02:16 -0500 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 12BD1tAw006730 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Mar 2021 14:01:55 +0100 Received: from [167.87.35.81] ([167.87.35.81]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 12BD1spc024424; Thu, 11 Mar 2021 14:01:55 +0100 Subject: Re: [PATCH] arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry To: Nishanth Menon , "Bajjuri, Praneeth" Cc: Tero Kristo , Rob Herring , devicetree , Linux Kernel Mailing List , linux-arm-kernel References: <279c20fa-6e5e-4f88-9cd1-f76297a28a19@web.de> <9097f361-419f-995f-2f05-d17a949af1cb@ti.com> <20210311125634.sasiot7hemsdcajl@thrash> From: Jan Kiszka Message-ID: <3e863dea-5dda-7435-e4fb-4135c9c0fcf5@siemens.com> Date: Thu, 11 Mar 2021 14:01:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210311125634.sasiot7hemsdcajl@thrash> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11.03.21 13:56, Nishanth Menon wrote: > On 19:36-20210310, Bajjuri, Praneeth wrote: >> >> >> On 2/20/2021 6:49 AM, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Add the DT entry for a watchdog based on RTI1. >>> >>> On SR1.0 silicon, it requires additional firmware on the MCU R5F cores >>> to handle the expiry, e.g. https://github.com/siemens/k3-rti-wdt. As >>> this firmware will also lock the power domain to protect it against >>> premature shutdown, mark it shared. >>> >>> Signed-off-by: Jan Kiszka >> >> Acked-by: Praneeth Bajjuri >> >>> --- >>> arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> index 7454c8cec0cc..903796bf7d64 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi >>> @@ -308,4 +308,13 @@ mcu_r5fss0_core1: r5f@41400000 { >>> ti,loczrama = <1>; >>> }; >>> }; >>> + >>> + mcu_rti1: rti@40610000 { > > Jan, I was about to pick up the patches and was running through > my sanity checks and the following caught my eye with dtbs_check > (dtschema is at 2021.2.1) test against next-20210311 > > /workdir/arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: rti@40610000: $nodename:0: 'rti@40610000' does not match '^watchdog(@.*|-[0-9a-f])?$' > > Please use watchdog@40610000 instead of rti@40610000 > > Since this is a minor change, I have done this change locally. let me > know if you have an issue and I can drop it off my branch for a new > version. > That's fine, thanks for fixing up - still learning such details. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux