From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
linux-remoteproc@vger.kernel.org, agross@kernel.org,
andersson@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@quicinc.com,
perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org,
quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
judyhsiao@chromium.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v9 1/7] dt-bindings: remoteproc: qcom: Add SC7280 ADSP support
Date: Wed, 28 Sep 2022 08:58:50 +0200 [thread overview]
Message-ID: <3e9ca09c-4134-e05c-3a48-3f0467ba7e8a@linaro.org> (raw)
In-Reply-To: <1664287003-31450-2-git-send-email-quic_srivasam@quicinc.com>
On 27/09/2022 15:56, Srinivasa Rao Mandadapu wrote:
> Add ADSP PIL loading support for SC7280 SoCs.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> ---
Thank you for your patch. There is something to discuss/improve.
> + qcom,smem-state-names:
> + description: The names of the state bits used for SMP2P output
> + const: stop
> +
> + qcom,qmp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Reference to the AOSS side-channel message RAM.
> +
> + glink-edge:
> + $ref: qcom,glink-edge.yaml#
> + type: object
You still miss here unevaluatedProperties: false on this level of
indentation.
> + description: |
> + Qualcomm G-Link subnode which represents communication edge, channels
> + and devices related to the ADSP.
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-28 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 13:56 [PATCH v9 0/7] Update ADSP pil loader for SC7280 platform Srinivasa Rao Mandadapu
2022-09-27 13:56 ` [PATCH v9 1/7] dt-bindings: remoteproc: qcom: Add SC7280 ADSP support Srinivasa Rao Mandadapu
2022-09-28 6:58 ` Krzysztof Kozlowski [this message]
2022-09-27 13:56 ` [PATCH v9 2/7] remoteproc: qcom: Add flag in adsp private data structure Srinivasa Rao Mandadapu
2022-09-27 13:56 ` [PATCH v9 3/7] remoteproc: qcom: Add compatible name for SC7280 ADSP Srinivasa Rao Mandadapu
2022-09-27 13:56 ` [PATCH v9 4/7] remoteproc: qcom: Update rproc parse firmware callback Srinivasa Rao Mandadapu
2022-09-27 13:56 ` [PATCH v9 5/7] remoteproc: qcom: Replace hard coded values with macros Srinivasa Rao Mandadapu
2022-09-27 13:56 ` [PATCH v9 6/7] remoteproc: qcom: Add efuse evb selection control Srinivasa Rao Mandadapu
2022-09-27 13:56 ` [PATCH v9 7/7] remoteproc: qcom: Add support for memory sandbox Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e9ca09c-4134-e05c-3a48-3f0467ba7e8a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).