From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A4065579D for ; Mon, 18 Mar 2024 18:41:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710787304; cv=none; b=r8xVsB188Pc4/f6/4Ejj35xgmqK5N0PgjijiXMEpWKT2XhkytGnTzwYES306PDrasAyPp2Ix2yKOoPMs4dV8Q0PBH7hW6OEy4k9XylR/MlgYQxOWMVL4k4aif+ODMoxuK6YeYf8nO9ATsGc8tw8lC5DdaeoDu0deernRVnajPpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710787304; c=relaxed/simple; bh=bZ8EF+f0ojIjoq6Dr918Kh/3SPma0ywuu31m4SVF0CI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JV7zZxHGf2zgUfLx6Rwjpby0JC8Q0fOqucHs0gjCk2xpbmvU7ywa7K0bzp3TS91hoB9TGGKETmCGBUBGCDbkrgGD8/k/5GBXb5LiAkKgfzx6CO0zfFYFeM4hiYAmGcWPG1hWGVP5WABaFlkr5ZPm5ZVDpU1En/Is+SlHZJ2RJes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ieee.org; spf=pass smtp.mailfrom=ieee.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b=dMjyIKml; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ieee.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ieee.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b="dMjyIKml" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-429f53f0b0bso29390591cf.2 for ; Mon, 18 Mar 2024 11:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1710787301; x=1711392101; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h2Eahz5y1g6Io4kuIZCPOk+HRz1bynd6ShyA3Ce0EGU=; b=dMjyIKmlDNCMZ3lNdbPCCvzpwkAD6yspleRqJAznvikT+WCcOja2js+6+xd4hX2Asx leNBm+qNaNjoi4eFFyY3lgfUq9YftU2FuLRAdViMqVHLM0GVFCTB/Di0/RvySj05y0pT tMhRFiBLl+8rxRJxkk3GFhdGISmglhkBVPnug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710787301; x=1711392101; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h2Eahz5y1g6Io4kuIZCPOk+HRz1bynd6ShyA3Ce0EGU=; b=bOmbFkMLiTJXiTDtuo3RVMADPatBGU85OX8Z3Sg+u+jfO+IY8xQ5NEY8gme8oUNTCK mphKgyuBAeXsjoHvn7AV8Skqo2GPv24fr6iuhf4IhYEhSf+W//qJW9A32uK93gpEE1ip 7DviXho5V4OQjQjW1BD6kJgnnUs+70oyHthTtTCYVLMMKF9N3m3YwEEzh9WTRTRadMy8 nhrwFj6A5uCYDeajHL9bJzBMfus+4LbFNE9C7gmwSfuI8jlwZuyQm23nA6ryIL1/rylY n4sBVe6VAY3q8tJuD9EDA/0fqZcBgwy6TpZs6XVs5gQHjFJ6YkSLJ0Q5riEvz62b4bcr 4Q+Q== X-Forwarded-Encrypted: i=1; AJvYcCWAbZMlFpwpMOXO61rkg5Vr+i2uUlxssLlkCWd+Zs28AcQYZlDtrICvQSQIp0kFi4l2uMOsNIAgYilEAZp4jyKwuX7qkfVy26Z4bQ== X-Gm-Message-State: AOJu0YwF/5pAQwVuS15WJ3WsgPhepnI0e9QPaqZiyILhctP9oVu5nYUu SWHXYtMowbo1p4q4cBFh8+PT1JO2RneIA4OKAmnWlYImod/pH4FdmS6ST1iaZA== X-Google-Smtp-Source: AGHT+IGa3DaP+ZQVnj5jdz1bnLoir7DhMaL4Yu8xli/2COHN6CI/dNA/dqupLIRNhbwqIkT59FDHPg== X-Received: by 2002:a05:622a:248:b0:430:e4ad:afbf with SMTP id c8-20020a05622a024800b00430e4adafbfmr381232qtx.20.1710787301471; Mon, 18 Mar 2024 11:41:41 -0700 (PDT) Received: from [172.22.22.28] (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.googlemail.com with ESMTPSA id fj5-20020a05622a550500b00430b423f06csm3796449qtb.86.2024.03.18.11.41.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 11:41:41 -0700 (PDT) Message-ID: <3eb9d5c2-149c-460c-9684-3fdaf946c400@ieee.org> Date: Mon, 18 Mar 2024 13:41:38 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver Content-Language: en-US To: Markus Elfring , Ayush Singh , Vaishnav M A , devicetree@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lorforlinux@beagleboard.org, greybus-dev@lists.linaro.org Cc: LKML , Alex Elder , Arnd Bergmann , Conor Dooley , Derek Kiernan , Dragan Cvetic , Greg Kroah-Hartman , Jason Kridner , Johan Hovold , Krzysztof Kozlowski , Mark Brown , Nishanth Menon , Rob Herring , Robert Nelson , Tero Kristo , Vaishnav M A , Vignesh Raghavendra References: <20240317193714.403132-5-ayushdevel1325@gmail.com> <4fe6f68a-786c-4e3d-b97d-847d6965d1d3@web.de> From: Alex Elder In-Reply-To: <4fe6f68a-786c-4e3d-b97d-847d6965d1d3@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/18/24 12:58 PM, Markus Elfring wrote: > … >> +++ b/drivers/misc/mikrobus/mikrobus_core.c > … >> +static int mikrobus_pinctrl_setup(struct mikrobus_port *port, >> + struct addon_board_info *board) >> +{ >> + int ret; >> + >> + if (!board || board->pin_state[MIKROBUS_PIN_PWM] == MIKROBUS_STATE_PWM) >> + ret = mikrobus_pinctrl_select(port, "pwm_default"); >> + else >> + ret = mikrobus_pinctrl_select(port, "pwm_gpio"); > … > > How do you think about to avoid the specification of a bit of duplicate source code here > by using conditional operator expressions? > > ret = mikrobus_pinctrl_select(port, > ((!board || > board->pin_state[MIKROBUS_PIN_PWM] == MIKROBUS_STATE_PWM) > ? "pwm_default" > : "pwm_gpio")); No. It's a complex enough bit of logic without trying to bury it inside the parameters passed to the function. -Alex > > > Regards, > Markus >