From: Alexandre Mergnat <amergnat@baylibre.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
pavel@ucw.cz
Cc: lee@kernel.org, sean.wang@mediatek.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v2 4/7] leds: leds-mt6323: Open code and drop MT6323_CAL_HW_DUTY macro
Date: Thu, 13 Apr 2023 15:06:25 +0200 [thread overview]
Message-ID: <3ebf7c2b-f9fb-6c1c-308b-47f28ba04ead@baylibre.com> (raw)
In-Reply-To: <20230412153310.241046-5-angelogioacchino.delregno@collabora.com>
On 12/04/2023 17:33, AngeloGioacchino Del Regno wrote:
> There is only one instance of using this macro and it's anyway not
> simplifying the flow, or increasing the readability of this driver.
>
> Drop this macro by open coding it in mt6323_led_set_blink().
>
> No functional changes.
>
> Signed-off-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@collabora.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
--
Regards,
Alexandre
next prev parent reply other threads:[~2023-04-13 13:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 15:33 [PATCH v2 0/7] Add support for MT6331 and MT6332 LEDs AngeloGioacchino Del Regno
2023-04-12 15:33 ` [PATCH v2 1/7] dt-bindings: leds: leds-mt6323: Document mt6331 compatible AngeloGioacchino Del Regno
2023-04-13 8:35 ` Alexandre Mergnat
2023-04-12 15:33 ` [PATCH v2 2/7] dt-bindings: leds: leds-mt6323: Document mt6332 compatible AngeloGioacchino Del Regno
2023-04-13 8:35 ` Alexandre Mergnat
2023-04-13 10:47 ` Pavel Machek
2023-04-12 15:33 ` [PATCH v2 3/7] leds: leds-mt6323: Specify registers and specs in platform data AngeloGioacchino Del Regno
2023-04-13 10:11 ` Alexandre Mergnat
2023-04-13 10:57 ` Pavel Machek
2023-04-12 15:33 ` [PATCH v2 4/7] leds: leds-mt6323: Open code and drop MT6323_CAL_HW_DUTY macro AngeloGioacchino Del Regno
2023-04-13 13:06 ` Alexandre Mergnat [this message]
2023-04-12 15:33 ` [PATCH v2 5/7] leds: leds-mt6323: Drop MT6323_ prefix from macros and defines AngeloGioacchino Del Regno
2023-04-13 10:59 ` Pavel Machek
2023-04-13 13:41 ` Alexandre Mergnat
2023-04-12 15:33 ` [PATCH v2 6/7] leds: leds-mt6323: Add support for MT6331 leds AngeloGioacchino Del Regno
2023-04-13 11:01 ` Pavel Machek
2023-04-13 13:19 ` Alexandre Mergnat
2023-04-12 15:33 ` [PATCH v2 7/7] leds: leds-mt6323: Add support for WLEDs and MT6332 AngeloGioacchino Del Regno
2023-04-13 11:06 ` Pavel Machek
2023-04-13 11:29 ` AngeloGioacchino Del Regno
2023-04-13 11:32 ` AngeloGioacchino Del Regno
2023-04-14 7:07 ` Lee Jones
2023-04-14 7:09 ` AngeloGioacchino Del Regno
2023-04-13 14:15 ` Alexandre Mergnat
2023-04-14 10:19 ` AngeloGioacchino Del Regno
2023-04-13 10:49 ` [PATCH v2 0/7] Add support for MT6331 and MT6332 LEDs Pavel Machek
2023-04-13 11:31 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ebf7c2b-f9fb-6c1c-308b-47f28ba04ead@baylibre.com \
--to=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).