[PATCH RESEND v4] dt-bindings: pwm: Convert Amlogic Meson PWM binding

[PATCH RESEND v4] dt-bindings: pwm: Convert Amlogic Meson PWM binding

[Heiner Kallweit]

Convert Amlogic Meson PWM binding to yaml.

Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
Seems patch got lost over the question who takes it.
Please apply through the pwm tree.

v2:
- fix clocks and clock-names
- consider that more than one compatible may be set
v3:
- remove minItem/maxItem properties for compatible
v4:
- remove not needed "items" before "enum"
---
 .../devicetree/bindings/pwm/pwm-amlogic.yaml  | 70 +++++++++++++++++++
 .../devicetree/bindings/pwm/pwm-meson.txt     | 29 --------
 2 files changed, 70 insertions(+), 29 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
 delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-meson.txt

diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
new file mode 100644
index 000000000..527864a4d
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/pwm-amlogic.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Amlogic PWM
+
+maintainers:
+  - Heiner Kallweit <hkallweit1@gmail.com>
+
+allOf:
+  - $ref: pwm.yaml#
+
+properties:
+  compatible:
+    oneOf:
+      - enum:
+          - amlogic,meson8b-pwm
+          - amlogic,meson-gxbb-pwm
+          - amlogic,meson-gxbb-ao-pwm
+          - amlogic,meson-axg-ee-pwm
+          - amlogic,meson-axg-ao-pwm
+          - amlogic,meson-g12a-ee-pwm
+          - amlogic,meson-g12a-ao-pwm-ab
+          - amlogic,meson-g12a-ao-pwm-cd
+          - amlogic,meson-s4-pwm
+      - items:
+          - const: amlogic,meson-gx-pwm
+          - const: amlogic,meson-gxbb-pwm
+      - items:
+          - const: amlogic,meson-gx-ao-pwm
+          - const: amlogic,meson-gxbb-ao-pwm
+      - items:
+          - const: amlogic,meson8-pwm
+          - const: amlogic,meson8b-pwm
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    minItems: 1
+    maxItems: 2
+
+  clock-names:
+    oneOf:
+      - items:
+          - enum: [clkin0, clkin1]
+      - items:
+          - const: clkin0
+          - const: clkin1
+
+  "#pwm-cells":
+    const: 3
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    pwm@8550 {
+      compatible = "amlogic,meson-gxbb-pwm";
+      reg = <0x08550 0x10>;
+      clocks = <&xtal>, <&xtal>;
+      clock-names = "clkin0", "clkin1";
+      #pwm-cells = <3>;
+    };
diff --git a/Documentation/devicetree/bindings/pwm/pwm-meson.txt b/Documentation/devicetree/bindings/pwm/pwm-meson.txt
deleted file mode 100644
index bd02b0a14..000000000
--- a/Documentation/devicetree/bindings/pwm/pwm-meson.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-Amlogic Meson PWM Controller
-============================
-
-Required properties:
-- compatible: Shall contain "amlogic,meson8b-pwm"
-                         or "amlogic,meson-gxbb-pwm"
-                         or "amlogic,meson-gxbb-ao-pwm"
-                         or "amlogic,meson-axg-ee-pwm"
-                         or "amlogic,meson-axg-ao-pwm"
-                         or "amlogic,meson-g12a-ee-pwm"
-                         or "amlogic,meson-g12a-ao-pwm-ab"
-                         or "amlogic,meson-g12a-ao-pwm-cd"
-- #pwm-cells: Should be 3. See pwm.yaml in this directory for a description of
-  the cells format.
-
-Optional properties:
-- clocks: Could contain one or two parents clocks phandle for each of the two
-  PWM channels.
-- clock-names: Could contain at least the "clkin0" and/or "clkin1" names.
-
-Example:
-
-	pwm_ab: pwm@8550 {
-		compatible = "amlogic,meson-gxbb-pwm";
-		reg = <0x0 0x08550 0x0 0x10>;
-		#pwm-cells = <3>;
-		clocks = <&xtal>, <&xtal>;
-		clock-names = "clkin0", "clkin1";
-	}
-- 
2.39.1

Re: [PATCH RESEND v4] dt-bindings: pwm: Convert Amlogic Meson PWM binding

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

On Mon, Feb 20, 2023 at 10:19:30PM +0100, Heiner Kallweit wrote:
> Convert Amlogic Meson PWM binding to yaml.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> Seems patch got lost over the question who takes it.
> Please apply through the pwm tree.

Hmm, I found
https://lore.kernel.org/linux-pwm/aaa73903-1837-d9c8-8c45-54b4473fd548@gmail.com
which had no Reviewed-by tag where Krzysztof Kozlowski replied writing:
"You got here a tag and my comment was about minor issue, so please keep
that tag." I didn't find a thread where such a tag was given, though. I
only found a review reply on v3 where Krzysztof requested a change (and
didn't provide a tag).

The Reviewed-by tag for Rob probably originates from
https://lore.kernel.org/linux-pwm/20230130212121.GA3468100-robh@kernel.org/.

And there is another variant where this patch was part of a series at
https://lore.kernel.org/linux-pwm/5b83767e-c53d-316f-df10-45a39dbd9c88@gmail.com
where it got an ack from me which wasn't included here.

To fix this:

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

but please note that you can save some scarce maintainer time if you're
more careful here.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH RESEND v4] dt-bindings: pwm: Convert Amlogic Meson PWM binding

[Krzysztof Kozlowski]

On 10/03/2023 19:11, Uwe Kleine-König wrote:
> On Mon, Feb 20, 2023 at 10:19:30PM +0100, Heiner Kallweit wrote:
>> Convert Amlogic Meson PWM binding to yaml.
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> Seems patch got lost over the question who takes it.
>> Please apply through the pwm tree.
> 
> Hmm, I found
> https://lore.kernel.org/linux-pwm/aaa73903-1837-d9c8-8c45-54b4473fd548@gmail.com
> which had no Reviewed-by tag where Krzysztof Kozlowski replied writing:
> "You got here a tag and my comment was about minor issue, so please keep
> that tag." I didn't find a thread where such a tag was given, though. I
> only found a review reply on v3 where Krzysztof requested a change (and
> didn't provide a tag).
> 
> The Reviewed-by tag for Rob probably originates from
> https://lore.kernel.org/linux-pwm/20230130212121.GA3468100-robh@kernel.org/.

Yes, Rob provided that tag. Since it is included here, looks fine.

> 
> And there is another variant where this patch was part of a series at
> https://lore.kernel.org/linux-pwm/5b83767e-c53d-316f-df10-45a39dbd9c88@gmail.com
> where it got an ack from me which wasn't included here.
> 
> To fix this:
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> but please note that you can save some scarce maintainer time if you're
> more careful here.

Best regards,
Krzysztof

Re: [PATCH RESEND v4] dt-bindings: pwm: Convert Amlogic Meson PWM binding

[Thierry Reding]

On Mon, 20 Feb 2023 22:19:30 +0100, Heiner Kallweit wrote:
> Convert Amlogic Meson PWM binding to yaml.
> 
> 

Applied, thanks!

[1/1] dt-bindings: pwm: Convert Amlogic Meson PWM binding
      commit: 43a1c4ff3977f0ccd1d99e36d74e525aced5bb3a

Best regards,
-- 
Thierry Reding <thierry.reding@gmail.com>