From: Matthias Brugger <matthias.bgg@gmail.com>
To: Fabien Parent <fparent@baylibre.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org
Cc: robh+dt@kernel.org, amitk@kernel.org, daniel.lezcano@linaro.org,
rui.zhang@intel.com
Subject: Re: [PATCH 3/3] thermal: mtk_thermal: make device_reset optional
Date: Tue, 27 Oct 2020 11:11:01 +0100 [thread overview]
Message-ID: <3edf970c-0435-3e8f-b262-4cc954032d53@gmail.com> (raw)
In-Reply-To: <20201021164231.3029956-3-fparent@baylibre.com>
On 21/10/2020 18:42, Fabien Parent wrote:
> MT8516 does not support thermal reset. Use device_reset_optional
> instead of device_reset.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/thermal/mtk_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 0bd7aa564bc2..149c6d7fd5a0 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -1052,7 +1052,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - ret = device_reset(&pdev->dev);
> + ret = device_reset_optional(&pdev->dev);
> if (ret)
> return ret;
>
>
next prev parent reply other threads:[~2020-10-27 10:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 16:42 [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional Fabien Parent
2020-10-21 16:42 ` [PATCH 2/3] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC Fabien Parent
2020-10-26 14:49 ` Rob Herring
2020-10-21 16:42 ` [PATCH 3/3] thermal: mtk_thermal: make device_reset optional Fabien Parent
2020-10-27 10:11 ` Matthias Brugger [this message]
2020-10-26 14:49 ` [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional Rob Herring
2020-10-27 10:19 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3edf970c-0435-3e8f-b262-4cc954032d53@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).