Devicetree
 help / color / mirror / Atom feed
From: Jared McArthur <j-mcarthur@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>, Tero Kristo <kristo@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, Sen Wang <sen@ti.com>,
	Moteen Shah <m-shah@ti.com>
Subject: Re: [PATCH v2 1/1] arm64: dts: ti: k3-j722s-evm: Switch audio codec clock from audio_refclk1 to external clock
Date: Thu, 3 Sep 2026 15:09:44 -0500	[thread overview]
Message-ID: <3ee0f8db-b844-4148-b484-64bcb329824d@ti.com> (raw)
In-Reply-To: <20260903200040.yxufreslq3ahsx74@buddhist>

On 9/3/26 15:00, Nishanth Menon wrote:
> On 16:05-20260804, Jared McArthur wrote:
>> In revision PROC170E1 of the J722SXH01EVM [0], the audio codec's
>> (TLV320AIC3106IRGZT [1]) MCLK was provided by the AUDIO_EXT_REFCLK1
>> (96MHz). Revisions PROC170E2 and later switched the MCLK's source
>> to an external LMK6CE012288CDLFT [2] oscillator (12.288MHz). The
>> PROC170E1 revision of the board is not publicly available.
>>
>> Fix the audio codec's clock by creating a new fixed clock node with
>> a frequency of 12.288MHz, and switch the audio codec's clock from
>> the audio_refclk1 to the new fixed clock. Remove pinmuxing and clock
>> muxing for the audio_refclk1.
>>
>> [0] https://www.ti.com/lit/zip/SPRR495
>> [1] https://www.ti.com/lit/gpn/TLV320AIC3106
>> [2] https://www.ti.com/lit/gpn/lmk6c
>>
> 
> Do we need:
> Fixes: 3a36c535dfd2 ("arm64: dts: ti: k3-j722s-evm: Enable analog audio support")
> 
> ?
> 

Thank you for the comment.

I can add the fixes tag. I was unsure about adding it originally,
because the commit did work for the original revision. To me,
it's debatable whether the commit introduced a bug, because the
bug is due to a hardware change.

-- 
Best,
Jared McArthur


  reply	other threads:[~2026-09-03 20:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 21:05 [PATCH v2 1/1] arm64: dts: ti: k3-j722s-evm: Switch audio codec clock from audio_refclk1 to external clock Jared McArthur
2026-08-10 22:15 ` Wang, Sen
2026-09-03 20:00 ` Nishanth Menon
2026-09-03 20:09   ` Jared McArthur [this message]
2026-09-04 16:03 ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ee0f8db-b844-4148-b484-64bcb329824d@ti.com \
    --to=j-mcarthur@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-shah@ti.com \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=sen@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox