From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: wangweidong.a@awinic.com, lgirdwood@gmail.com,
broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
perex@perex.cz, tiwai@suse.com, rf@opensource.cirrus.com,
shumingf@realtek.com, ckeepax@opensource.cirrus.com,
herve.codina@bootlin.com, 13916275206@139.com,
ryans.lee@analog.com, linus.walleij@linaro.org,
sebastian.reichel@collabora.com, fido_max@inbox.ru,
povik+lin@cutebit.org, arnd@arndb.de,
harshit.m.mogalapalli@oracle.com, liweilei@awinic.com,
yijiangtao@awinic.com, colin.i.king@gmail.com, trix@redhat.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 4/5] ASoC: codecs: Change the aw88261 variable name and i2c driver name
Date: Wed, 13 Sep 2023 09:03:08 +0200 [thread overview]
Message-ID: <3ee11823-a441-b646-bdd7-aedd3a3a55e5@linaro.org> (raw)
In-Reply-To: <20230912065852.347000-5-wangweidong.a@awinic.com>
On 12/09/2023 08:58, wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>
>
> Change "sound-channel" to "awinic,audio-channel"
> Change "aw88261_smartpa" to "aw88261"
> - prof_name = aw88261_dev_get_prof_name(aw88261->aw_pa, count);
> - if (!prof_name) {
> + ret = aw88261_dev_get_prof_name(aw88261->aw_pa, count, &prof_name);
> + if (ret) {
> strscpy(uinfo->value.enumerated.name, "null",
> strlen("null") + 1);
> return 0;
> @@ -1189,7 +1190,7 @@ static void aw88261_parse_channel_dt(struct aw88261 *aw88261)
> u32 channel_value = AW88261_DEV_DEFAULT_CH;
> u32 sync_enable = false;
>
> - of_property_read_u32(np, "sound-channel", &channel_value);
> + of_property_read_u32(np, "awinic,audio-channel", &channel_value);
> of_property_read_u32(np, "sync-flag", &sync_enable);
What about this?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-13 7:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 6:58 [PATCH V2 0/5] ASoC: codecs: Add aw87390 amplifier driver wangweidong.a
2023-09-12 6:58 ` [PATCH V2 1/5] ASoC: dt-bindings: Adds properties to "awinic,aw88395" wangweidong.a
2023-09-12 16:21 ` Rob Herring
2023-09-13 8:06 ` wangweidong.a
2023-09-13 7:02 ` Krzysztof Kozlowski
2023-09-13 8:03 ` wangweidong.a
2023-09-12 6:58 ` [PATCH V2 2/5] ASoC: dt-bindings: Add schema for "awinic,aw87390" wangweidong.a
2023-09-12 17:50 ` Rob Herring
2023-09-12 6:58 ` [PATCH V2 3/5] ASoC: codecs: Add code for bin parsing compatible with aw87390 wangweidong.a
2023-09-12 6:58 ` [PATCH V2 4/5] ASoC: codecs: Change the aw88261 variable name and i2c driver name wangweidong.a
2023-09-13 7:03 ` Krzysztof Kozlowski [this message]
2023-09-13 8:00 ` wangweidong.a
2023-09-12 6:58 ` [PATCH V2 5/5] ASoC: codecs: Add aw87390 amplifier driver wangweidong.a
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ee11823-a441-b646-bdd7-aedd3a3a55e5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=colin.i.king@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fido_max@inbox.ru \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=perex@perex.cz \
--cc=povik+lin@cutebit.org \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=ryans.lee@analog.com \
--cc=sebastian.reichel@collabora.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=trix@redhat.com \
--cc=wangweidong.a@awinic.com \
--cc=yijiangtao@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).