Re: [PATCH v3 0/3] StarFive's SDIO/eMMC driver support

From: William Qiu <william.qiu@starfivetech.com>
To: Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-mmc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/3] StarFive's SDIO/eMMC driver support
Date: Wed, 15 Feb 2023 18:16:35 +0800	[thread overview]
Message-ID: <3ee9b726-10db-5d05-b24a-010c8bf5b59d@starfivetech.com> (raw)
In-Reply-To: <CAJM55Z8gpBDu9818GPLRYJ9DBa+NfXW0uo76_bkwWm6RS1S9wg@mail.gmail.com>

On 2023/2/15 18:00, Emil Renner Berthing wrote:
> On Tue, 14 Feb 2023 at 13:21, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>>
>> On Fri, 3 Feb 2023 at 09:19, William Qiu <william.qiu@starfivetech.com> wrote:
>> >
>> > Hi,
>> >
>> > This patchset adds initial rudimentary support for the StarFive
>> > designware mobile storage host controller driver. And this driver will
>> > be used in StarFive's VisionFive 2 board. The main purpose of adding
>> > this driver is to accommodate the ultra-high speed mode of eMMC.
>> >
>> > The last patch should be applied after the patchset [1]:
>> > [1] https://lore.kernel.org/all/20221220011247.35560-1-hal.feng@starfivetech.com/
>> >
>> > Changes since v2:
>> > - Wraped commit message according to Linux coding style.
>> > - Rephrased the description of the patches.
>> > - Changed the description of syscon regsiter.
>> > - Dropped redundant properties.
>> >
>> > The patch series is based on v6.1.
>> >
>> > William Qiu (3):
>> >   dt-bindings: mmc: Add StarFive MMC module
>> >   mmc: starfive: Add sdio/emmc driver support
>> >   riscv: dts: starfive: Add mmc node
>> >
>> >  .../bindings/mmc/starfive,jh7110-mmc.yaml     |  77 ++++++++
>> >  MAINTAINERS                                   |   6 +
>> >  .../jh7110-starfive-visionfive-2.dtsi         |  23 +++
>> >  arch/riscv/boot/dts/starfive/jh7110.dtsi      |  37 ++++
>> >  drivers/mmc/host/Kconfig                      |  10 +
>> >  drivers/mmc/host/Makefile                     |   1 +
>> >  drivers/mmc/host/dw_mmc-starfive.c            | 185 ++++++++++++++++++
>> >  7 files changed, 339 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
>> >  create mode 100644 drivers/mmc/host/dw_mmc-starfive.c
>> >
>>
>> Patch 1 and patch 2 applied for next, thanks!
>>
>> Note that I fixed some checkpatch errors/warnings. Next time, please
>> run ./scripts/checkpatch.pl before you submit your patches.
> 
> Hi,
> 
> Something here is not right. The bindings document "starfive,sysreg",
> but the code is looking for "starfive,syscon".
> William, did you test this and run dtbs_check before sending this series?
> 
> /Emil

Hi Emil,

Sorry about that, it's my negligence that I did dtbs_check without 
checking the configuration of CONFIG_SOC_STARFIVE. I made a modification 
in the next version and add binding for all the syscon at the same time. Next
time I'll make sure the check is correct.I'm sorry again for this oversight.
I'll send v4 patch series today.

Best Regards
William
> 
>> Kind regards
>> Uffe
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv