Devicetree
 help / color / mirror / Atom feed
From: "chr[]" <chris@rudorff.com>
To: Linus Walleij <linusw@kernel.org>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: light: Update DT bindings for GP2AP002
Date: Sat, 17 Oct 2026 11:18:35 +0200	[thread overview]
Message-ID: <3ef190ac-eac2-4c0d-b3b2-6fb627f086ef@rudorff.com> (raw)
In-Reply-To: <CAD++jLkSjbMRV_53rjpd1D+vxg=OVVWzVwiddUL0eqmSBoONHw@mail.gmail.com>

Hi Linus,

Am 16.10.26 um 23:01 schrieb Linus Walleij:
> Hi Christoph,
> 
> thanks for your patch!
> 
> On Fri, Oct 16, 2026 at 4:43 PM Christoph Rudorff <chris@rudorff.com> wrote:
> 
>> +  vled-supply:
>> +    description: LED power supply a phandle to a regulator
> 
> What datasheet is this from?
> 
> My datasheet for the GP2AP002S00F clearly has only
> VIO and VCC, enjoy:
> https://dflund.se/~triad/krad/GP2AP002S00F.pdf

That's the paper I'm looking at. Pin LEDA wants power!
See page 8 "Recommended external circuit"

> 
> There is however two *outputs* from the GP2AP002S00F
> called LEDA and LEDC.
> 
> These read "LED Anode" and "LED Cathode" and is where
> the IR LED is supposed to be connected.

The LED is build in. And it wants power:
see page 4 "Absolute Maximum Ratings", 3x "supply"

Vcc and Vled want the same voltage so they may have the same supply.
In the downstream kernel they #ifdef that case having an optional third 
supply and #ifdef two options for that.

> 
> I'm just puzzled by this patch.
> 

In the end it makes it work on my device.

> Yours,
> Linus Walleij

@all,

thanks for your reviews, there will be version 2, soon.

Regards,

Christoph Rudorff



  reply	other threads:[~2026-10-17  9:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 14:43 [PATCH 0/3] from my MSM8916-mainline: Christoph Rudorff
2026-10-16 14:43 ` [PATCH 1/3] iio: light: gp2ap002: add led power supply Christoph Rudorff
2026-10-16 14:48   ` sashiko-bot
2026-10-17  0:05   ` Jonathan Cameron
2026-10-16 14:43 ` [PATCH 2/3] iio: light: Update DT bindings for GP2AP002 Christoph Rudorff
2026-10-16 14:45   ` Krzysztof Kozlowski
2026-10-16 14:58     ` chr[]
2026-10-16 14:49   ` sashiko-bot
2026-10-16 21:01   ` Linus Walleij
2026-10-17  9:18     ` chr[] [this message]
2026-10-16 14:43 ` [PATCH 3/3] arm64: dts: qcom: msm8916-samsung-j5: Add proximity sensor Christoph Rudorff
2026-10-16 15:11   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ef190ac-eac2-4c0d-b3b2-6fb627f086ef@rudorff.com \
    --to=chris@rudorff.com \
    --cc=andersson@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox