From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6AD2C43334 for ; Thu, 23 Jun 2022 13:26:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231237AbiFWN0u (ORCPT ); Thu, 23 Jun 2022 09:26:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229943AbiFWN0t (ORCPT ); Thu, 23 Jun 2022 09:26:49 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E3E149CA6 for ; Thu, 23 Jun 2022 06:26:47 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id o9so19307648edt.12 for ; Thu, 23 Jun 2022 06:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=BWtywWXxkwvovMIXtrTmO3/YOYg8/WdqZTGc+AK29lA=; b=sZ7ku9dgfbUr4sAKkhhOykgJ+ezo2z/y+eqV6NdXPESqQPurnxYGemNE33Be0ZMwFB fPfVCELnAEkQC5AMV3vRq0EAF31YOZEWoI8YgvJ6evFlTtKqwN61PG4JV0nppugz32b/ DXUh1qqSNi76Qh6x4qMH8nAIXm3EQ6fi8+9xHDnCdYhwk29lys3/aiXJsaPuRwPt03CA 8JTUsMn033xEFscHJBwJR+EV69O4CgfOHJq6ptELeDCXBxxMQGHY/N5Ilhbz+OQpXADK G8CMrIjQ4wpkXD0pWxsesEp/2pg3JDRlmc8hwmgr2dPm+CLb0iCNlUo2kudCZOx9jCN1 E5Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BWtywWXxkwvovMIXtrTmO3/YOYg8/WdqZTGc+AK29lA=; b=GCSm9garrRGCND8ZKB2Pv92pj6Ju70TwAvawmtXJ44L0oLyuh5G53SIc3epksx5sDx Wc6zx8ZnZHAnXIG4rDEJ4tQaBfEm/QgiXzQC2v2/5/AbKsbnDrsbU2nECMUalfhY8U8f low+gZGOfff2QMWEy14AgY7Xc29rvtBAKoydOXd8fDQAXXW35fmZLt/8I8Tx/UH7jRdf 7hRmymbEQ9/P2jVSKGhtZtvfR7DhoNO67/8nVw3oI5nmiS303Ucur6x17MUBjnjZkzky j2Jiyd9YIbmAIxRxIlz+MKblWUrpycqzHjfph6xypD3o3KmHach9mNVZMKWrbXyDjF7b tpAw== X-Gm-Message-State: AJIora/SHzrh/NrGX0J2bcPTdKSsnrpn1ViOV7yYaPY+ZWB6+PHEuLr0 zdnEkEgot3pDEm+7K5WTzeXuHw== X-Google-Smtp-Source: AGRyM1sXuGfb1U67lmsrb9UiJ1H/KgcSb5tCjSll3oNHilBT7iIdQgnIYQn/FF5ye6ZvQmmdZB+sng== X-Received: by 2002:a05:6402:3227:b0:435:8e00:62b4 with SMTP id g39-20020a056402322700b004358e0062b4mr10697408eda.325.1655990805936; Thu, 23 Jun 2022 06:26:45 -0700 (PDT) Received: from [192.168.0.230] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id p1-20020a05640210c100b004357dca07cdsm10486338edu.88.2022.06.23.06.26.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jun 2022 06:26:45 -0700 (PDT) Message-ID: <3f04d27f-4949-3544-9d39-73151a303569@linaro.org> Date: Thu, 23 Jun 2022 15:26:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 3/3] regulator: qcom_smd: Add PM8909 RPM regulators Content-Language: en-US To: Stephan Gerhold , Mark Brown Cc: Bjorn Andersson , Andy Gross , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220623094614.1410180-1-stephan.gerhold@kernkonzept.com> <20220623094614.1410180-4-stephan.gerhold@kernkonzept.com> From: Krzysztof Kozlowski In-Reply-To: <20220623094614.1410180-4-stephan.gerhold@kernkonzept.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/06/2022 11:46, Stephan Gerhold wrote: > static const struct rpm_regulator_data rpm_pm8916_regulators[] = { > { "s1", QCOM_SMD_RPM_SMPA, 1, &pm8916_buck_lvo_smps, "vdd_s1" }, > { "s2", QCOM_SMD_RPM_SMPA, 2, &pm8916_buck_lvo_smps, "vdd_s2" }, > @@ -1222,6 +1245,7 @@ static const struct rpm_regulator_data rpm_pm2250_regulators[] = { > static const struct of_device_id rpm_of_match[] = { > { .compatible = "qcom,rpm-mp5496-regulators", .data = &rpm_mp5496_regulators }, > { .compatible = "qcom,rpm-pm8841-regulators", .data = &rpm_pm8841_regulators }, > + { .compatible = "qcom,rpm-pm8909-regulators", .data = &rpm_pm8909_regulators }, > { .compatible = "qcom,rpm-pm8916-regulators", .data = &rpm_pm8916_regulators }, > { .compatible = "qcom,rpm-pm8226-regulators", .data = &rpm_pm8226_regulators }, > { .compatible = "qcom,rpm-pm8941-regulators", .data = &rpm_pm8941_regulators }, Isn't this a new compatible? Looks like, so it needs bindings. Best regards, Krzysztof