devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder
@ 2022-11-09 12:16 Kalyan Thota
  2022-11-09 12:16 ` [PATCH 2/4] drm/msm/disp/dpu1: populate disp_info if an interface is external Kalyan Thota
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: Kalyan Thota @ 2022-11-09 12:16 UTC (permalink / raw)
  To: dri-devel, linux-arm-msm, freedreno, devicetree
  Cc: Kalyan Thota, linux-kernel, robdclark, dianders, swboyd,
	quic_vpolimer, dmitry.baryshkov, quic_abhinavk

Pin each crtc with one encoder. This arrangement will
disallow crtc switching between encoders and also will
facilitate to advertise certain features on crtc based
on encoder type.

Signed-off-by: Kalyan Thota <quic_kalyant@quicinc.com>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index 7a5fabc..552a89c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -798,19 +798,19 @@ static int _dpu_kms_drm_obj_init(struct dpu_kms *dpu_kms)
 	max_crtc_count = min(max_crtc_count, primary_planes_idx);
 
 	/* Create one CRTC per encoder */
+	encoder = list_first_entry(&(dev)->mode_config.encoder_list,
+		struct drm_encoder, head);
 	for (i = 0; i < max_crtc_count; i++) {
 		crtc = dpu_crtc_init(dev, primary_planes[i], cursor_planes[i]);
-		if (IS_ERR(crtc)) {
+		if (IS_ERR(crtc) || IS_ERR_OR_NULL(encoder)) {
 			ret = PTR_ERR(crtc);
 			return ret;
 		}
 		priv->crtcs[priv->num_crtcs++] = crtc;
+		encoder->possible_crtcs = 1 << drm_crtc_index(crtc);
+		encoder = list_next_entry(encoder, head);
 	}
 
-	/* All CRTCs are compatible with all encoders */
-	drm_for_each_encoder(encoder, dev)
-		encoder->possible_crtcs = (1 << priv->num_crtcs) - 1;
-
 	return 0;
 }
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2022-11-11 15:36 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-09 12:16 [PATCH 1/4] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder Kalyan Thota
2022-11-09 12:16 ` [PATCH 2/4] drm/msm/disp/dpu1: populate disp_info if an interface is external Kalyan Thota
2022-11-09 12:22   ` Dmitry Baryshkov
2022-11-09 12:16 ` [PATCH 3/4] drm/msm/disp/dpu1: helper function to determine if encoder is virtual Kalyan Thota
2022-11-09 12:23   ` Dmitry Baryshkov
2022-11-09 12:16 ` [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc Kalyan Thota
2022-11-09 12:32   ` Dmitry Baryshkov
2022-11-09 12:39     ` Kalyan Thota
2022-11-09 12:47       ` Dmitry Baryshkov
2022-11-09 13:23     ` Kalyan Thota
2022-11-09 15:40       ` Kalyan Thota
2022-11-11 13:55     ` Kalyan Thota
2022-11-11 15:31   ` kernel test robot
2022-11-09 12:19 ` [PATCH 1/4] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).