From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="BWFbCeo0" Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A92641988; Tue, 28 Nov 2023 11:52:22 -0800 (PST) Received: from notapiano (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id EC19B6602F2B; Tue, 28 Nov 2023 19:52:16 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701201140; bh=lTlr8qen9KRZ2EZ5Mj/C5s4YyiYXfeKPKLVSZIrbTaI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BWFbCeo0pR89kb8EP/q48zvjI3cmzqzkOP5Ssg6KCYoxmkYsWhGw7YnYwnK0Ydqx9 shS65Zdg/bf6ykTyCPIAoN+VgUo6f2E5W0QcfQUeciCr3rka0YrpUzn+HSv/Bj7Zct H7Infuv8i02YACPgJR2RW94Pq1aXDa0SK6yC1DMGOERLw6n3KijfKvg4e7UliZB2FY gALs+B7NKhpeP+t7oyOtEriPW0ZcVjhpIUPqzuejbdo7CDI5XAGpOkkGmtxmvMbKR9 Y183UDfOcNi0JPgzAIknumKFCAi/HtwqTGlS66GpmKmxmcaHod/LOIaopU07q5hAKg UIW+brHODLCag== Date: Tue, 28 Nov 2023 14:52:12 -0500 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: "Bird, Tim" Cc: Shuah Khan , Greg Kroah-Hartman , Bjorn Helgaas , Saravana Kannan , Rob Herring , "kernelci@lists.linux.dev" , David Gow , Guenter Roeck , "linux-kselftest@vger.kernel.org" , "linux-usb@vger.kernel.org" , "kernel@collabora.com" , Dan Carpenter , "linux-pci@vger.kernel.org" , Doug Anderson , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH v2 2/2] kselftest: devices: Add sample board file for google,spherion Message-ID: <3f22eea4-121d-4d5b-b7af-71961a2ab5e9@notapiano> References: <20231127233558.868365-1-nfraprado@collabora.com> <20231127233558.868365-3-nfraprado@collabora.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Nov 28, 2023 at 05:54:57PM +0000, Bird, Tim wrote: > > -----Original Message----- > > From: Nícolas F. R. A. Prado > > On Tue, Nov 28, 2023 at 12:10:46AM +0000, Bird, Tim wrote: > > > > -----Original Message----- > > > > From: Nícolas F. R. A. Prado > > > > Add a sample board file describing the file's format and with the list > > > > of devices expected to be probed on the google,spherion machine as an > > > > example. > > > > > > > > Signed-off-by: Nícolas F. R. A. Prado > > > > --- > > > > > > > > (no changes since v1) > > > > > > > > .../testing/selftests/devices/boards/google,spherion | 12 ++++++++++++ > > > > > > Overall, while trying to maintain a comprehensive set of board definitions > > > seems hard, I think having a few as examples is useful. > > > > > > I'm not a big fan of naming these with a comma in the name. Is there a reason > > > you are not using dash or underscore? > > > > I'm using the name that we get from the DT compatible, so the right file can be > > automatically selected by the test. > > > > > > > > Do you anticipate a convention of tuples for > > > the filename? > > > > I'd just stick to the DT compatible as it's the simplest option and should work > > just the same, assuming I understood correctly what you mean. > > OK - I see that was mentioned in the original submission. I should > have read more closely. > > It makes sense. Maybe it's worth mentioning in the commit message that the > filename is the compatible string from the DT for this board? > > This convention, IMHO, should be documented somewhere. I have that as part of the comment at the top of the test script in patch 1: # The per-platform list of devices to be tested is stored inside the boards/ # directory and chosen based on compatible. And also in the commit message of patch 1. But I guess this sample file is the most likely one to be read when someone writes a new board file, so I'll document it here too for next version. Thanks, Nícolas