From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6D09392C27 for ; Wed, 12 Aug 2026 04:10:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786507837; cv=none; b=sfZtLLn0RFawvWOjQ/8zSW53bAynQd3mldCq9mnTOfUspzmhRweRpKamqD8tJdV8tgABuD/d+B+4Wgb+qhZNqZ/wyKlO6aMp79tR6CHmz5yR8VEbDrC58dUP5oyFgah6OhQmkQ3k+qAapFFo7r4XFqiksKRp8y2yC9KwPll/0CE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786507837; c=relaxed/simple; bh=gLj1Ji6Xt/i+3gADU6vlqWABAXOi9w/AGkhICO8XBHM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZKnc3uNWTvVuj/bFU/QItXdBTIGhUOlIodx+UZ9DSdUeblHnxOQ23UvWdoOmvXHHC0hoO8XEL60HN7XbYZ7hz6JfTejKxclTr9QbaN2lBLMZDSJ2nwaXb3IWbq6YqLf8GMqdyf2ED2Xqb257C1FaMn8tmFccxyWOtBIJG28FOKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ov/79yIK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DVDHOydY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ov/79yIK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DVDHOydY" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67C48lJJ2625717 for ; Wed, 12 Aug 2026 04:10:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ycqNmOINwoVyj/6s4hroIe44DSPjnnHA0sh0w16wSIg=; b=ov/79yIKXvAbl7rM gYND3eTjFUs+JZgPzkNFHZ2Zh6NcHTr2VVuN4Fk/ceLVedJVotBANBVQbk+nafNH FpP74DPcK+eZGYkhzyvdTLaA5tkiENpE2Q8oF2BaXL9pf5rtJygxsqijGYWxVfKc swTUTIyxfm8TifjW4txS4Jx3VPu5rZEE8J/Ejt7GX6zshvbOlE2s8SJNKEm9i3Fg LkRmu1EQLPwlx0HLxXtu2TV7+i6SmN1u1MGjkdXEcfLYR7WR86O2lByCWA7Cg/1G Wf5jE0XDF0SoiWhxPMekbJqytfdkuWQQBuDkYBR51iOqUIK1d64bXxio37sy/LQm XhWFmw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0hj1g063-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 04:10:34 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-ca8aee88725so712238a12.3 for ; Tue, 11 Aug 2026 21:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786507833; x=1787112633; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ycqNmOINwoVyj/6s4hroIe44DSPjnnHA0sh0w16wSIg=; b=DVDHOydYZcYUWOtY+WUL3NpjnewryAkPyirPCZJc01hy77M13gUw0YPFeUodOBL+Od irhYizL0T75Y318F4R7nulBlMODn5gSTquwvQFBDrW3zQju+i7+EX9JvQ1U5SO3Ds4IR TTicc6YTvEkMgyNLJRGAlUsHYGK0dzMf0Rp+kHZLpo3dmG8aBjs2yFQbrBiQzUT5tfED 6ixX3P4jyJHTZG2CvQ1xhq78ARCqQoGW1r/CNULRW5VQ1cVmdl5kenbXAaDs/WPWKgqK k083XpJhU5dDzxcR9yr/Sm6ZxzUZprlqhmiEc3TxipiNg7P31FjfFHCyyBB13Ls+JAI4 JEBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786507833; x=1787112633; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ycqNmOINwoVyj/6s4hroIe44DSPjnnHA0sh0w16wSIg=; b=rN3vdiAIbQTGpYCa0isSz++tk0RW5LViASa2qGMyZwzHDk+F6w3CXH01wKkVgzgzgZ AGpEb5YYPYknPboKLG97/JTE+W3YteCUkioxNTM88uXYOvx1lBWhqx+rujuUpUHYLKZM lj0/Dz3GZ0vRfr0BTb/gn2thJxkt628SoP5AosD9+fmjJbBs+GvEHDktHYVuxweJm87z s8LJCrs2LWPqeNmK9DMd6J3eWAz5jcD1A7MCBwi7PG3tzm/sSBXWjm2fyEx+wx2PjWsi UH9KOcaV8Y3ZTBAXEMpHtBsdjFK+2hqvbEEYXISyC5ClX7tUApVzxBaBDuxIGTnin6Je FiPA== X-Forwarded-Encrypted: i=1; AHgh+RpLxt2AYrleGFBRE1R47n9DhKiyOY9Io5iUr1FmishyKl8DBW9j2k0oazKlQVO8mJXEkvpDGPDj6JuE@vger.kernel.org X-Gm-Message-State: AOJu0YzJ2/+5mbvE/DKmjbwCv9xZ1u5K35zpiHuTee932RAojUPoBJrR raNuIydi/RyHhuV/sV7ki2TI5SKp6yRbP+WO6sqa6SwpeV0wTI+9FSbtu93gYHzkJWV0SGaUH2O ykCG5+PwoGlhIAWOh7r1VdEaTvq3iHFlQVkfsLd1kkwZeSoycywtXiD6l37X/fLwS X-Gm-Gg: AR+sD1202hqJM45QR1w1VrVHXSre8ZWc/hD8ZLW+H+PFw2UWAibe/g3SO9ZpIBrMckK vJZ8s6f3H4kzovYfO780YXyoDI/7J7zVbx0QiuPZs89xMZOxzW+jvdT+xHqn7jY93hKf4KX4IKz 3MTBlpRa27ho5gS7bFHy6yb/WFXyXSPueG8PUxqqX42z7+AcXzskwpJAurFnlzSPk3QNySdT4VY GfCAcXuMC1NM80/0+GCOQhGod82DAquXtdw0LKm5rNXFPKN11vR/V7Je8pvdz8WHXU8X8E9aTga bcnZQOEFvhLvox2TwlTBBHqUNzLrNJD/8463gp1O2I+AP35Kk1iLI7Az1Idk4muvqnVK66zbE1A npDa+Tc/5ilAyxK+cipATh0ms8zNxtDxzww== X-Received: by 2002:a05:6a20:da14:b0:3c4:3112:33 with SMTP id adf61e73a8af0-3cc3f51c7a5mr2557866637.6.1786507833527; Tue, 11 Aug 2026 21:10:33 -0700 (PDT) X-Received: by 2002:a05:6a20:da14:b0:3c4:3112:33 with SMTP id adf61e73a8af0-3cc3f51c7a5mr2557821637.6.1786507833113; Tue, 11 Aug 2026 21:10:33 -0700 (PDT) Received: from [10.218.18.194] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf628e0edsm5538714eec.18.2026.08.11.21.10.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2026 21:10:32 -0700 (PDT) Message-ID: <3f2cb2e9-d242-468e-8582-26caabba7832@oss.qualcomm.com> Date: Wed, 12 Aug 2026 09:40:25 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/9] PCI: qcom: Add PCIe support for Shikra SoC To: Manivannan Sadhasivam Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Andersson , Chaitanya Chundru , Bartosz Golaszewski , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20260701-shikra-upstream-v1-0-e1a721eb8943@oss.qualcomm.com> Content-Language: en-US From: Sushrut Shree Trivedi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: kTxzY53yuIrB-plXO7pTc3mdBSOQ9_JB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDAyOSBTYWx0ZWRfX/MWeqQ7TBIo2 p3tC86YvWHQzZ0YqYhYyUUUsAM1pzwNycJpB24oE3JHkfEqzyI2cypS1j7Ih8qDzsSSWyYdoYE9 uHFT3vmnQy+9T/07LJPmBldYE9Avb3EwHtTsNXGVwC5RKpiNR3XSFCKPMKqkYy0jCS8O1RU1/ne utp2SR+5o6+sKU0HV+GO0g/bgwmsoD/VGh6uUk6P+jKG8r4PCH57HO+kdJYGa8oeYLs3hlFD/m1 /okbzbPSEq7hVt3WZT3vUjbN+Ah1wlk+yyfHIk29DfgBf1tWvJiaVOKFMQbdWd/5c6sEcf+04KA oqk9XUjWB/HMyOj1yqh/JAmaWor7J7Bp8Nw+M5GCTD9AWei8uOeAhWpDCAHhHzSdIiLdH53isv5 qhV1y1NhtwHtraAqP8GRz51BsxcqQP7DOUJqwaNpJ937UrPUxAQLmolS1y3ARa0wbjQxGwAVTnZ EDGFhkisnjogHOjV1PA== X-Authority-Analysis: v=2.4 cv=K6ES2SWI c=1 sm=1 tr=0 ts=6a7bf23a cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=ee_2aqc6AAAA:8 a=EUspDBNiAAAA:8 a=clU37HkR2gB4O1HD2CAA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=VOpmJXOdbJOWo2YY3GeN:22 X-Proofpoint-GUID: kTxzY53yuIrB-plXO7pTc3mdBSOQ9_JB X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDAyOSBTYWx0ZWRfX38RcTdPbDBp/ O1Q/k7W0/2Vzu4B1PKb09259dPludIwDMVjUKW1DHCj7fILjbMcogH+F+UXcYT1/FXQZgmGsaQS W5e9//B4M6t9yeHIEkqWZkR6LfmdU00= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_01,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120029 On 7/8/2026 1:32 PM, Manivannan Sadhasivam wrote: > On Wed, Jul 01, 2026 at 12:32:42AM +0530, Sushrut Shree Trivedi wrote: >> Add PCIe support for Shikra target, by adding dt-bindings for phy, >> controller and corresponding phy & controller drivers/device-tree >> changes. >> >> Shikra RC is connected to TC9563 PCIe switch on all three >> EVK variants: CQS, CQM and IQS. The individual downstream ports >> of TC9563 connect like below: >> >> DSP1: M.2 B-Key for 5G Modem >> DSP2: M.2 M-Key for NVMe >> DSP3: Embedded ethernet device >> >> Power and reset to M.2 B and M.2 M slot are controlled via >> TC9563 GPIO's. Hence, add DT nodes to enable TC9563 switch >> and include corresponding changes to configure power/reset >> to TC9563 endpoints as part of power on sequence. >> >> Signed-off-by: Sushrut Shree Trivedi >> --- >> Sushrut Shree Trivedi (9): >> dt-bindings: phy: sc8280xp-qmp-pcie: Document Shikra PCIe phy >> dt-bindings: PCI: qcom: Document the Shikra PCIe Controller >> dt-bindings: PCI: Add bindings for endpoint gpios >> PCI: qcom: Add support for Shikra >> phy: qcom: qmp-pcie: Add QMP PCIe PHY support for Shikra >> PCI/pwrctrl: tc9563: Add API to control endpoint power and reset > TC9563 should be modeled as a GPIO controller to drive the PERST# and power-on > GPIOs. There is a patch series under review [1] that adds this support. So it > doesn't make sense to duplicate the effort here (which itself is hackish). So > please drop all the switch related patches from this series and resubmit them > once the above mentioned series from Alex gets merged. > > But you can continue with the Shikra PCIe RC/PHY patches. > > - Mani > > [1] https://lore.kernel.org/all/20260605010022.968612-1-elder@riscstar.com ACK'd > >> arm64: dts: qcom: shikra: Add PCIe PHY and controller nodes >> arm64: dts: qcom: shikra-evk: Add TC9563 PCIe switch node for PCIe >> arm64: dts: qcom: shikra-(cqm/cqs/iqs)-evk: Enable PCIe PHY node >> >> .../devicetree/bindings/pci/qcom,shikra-pcie.yaml | 211 +++++++++++++++++++++ >> .../devicetree/bindings/pci/toshiba,tc9563.yaml | 22 ++- >> .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 2 + >> arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 7 + >> arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 7 + >> arch/arm64/boot/dts/qcom/shikra-evk.dtsi | 152 +++++++++++++++ >> arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 7 + >> arch/arm64/boot/dts/qcom/shikra.dtsi | 154 +++++++++++++++ >> drivers/pci/controller/dwc/pcie-qcom.c | 1 + >> drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 152 ++++++++++++--- >> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 73 +++++++ >> 11 files changed, 764 insertions(+), 24 deletions(-) >> --- >> base-commit: 565fa02f75448ce1ddd18bda6b31ad985cf75411 >> change-id: 20260701-shikra-upstream-14b8668f1001 >> >> Best regards, >> -- >> Sushrut Shree Trivedi >> >>