Re: [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 11/04/2022 13:18, Tony Lindgren wrote:
> Let's update the TI timer binding to use yaml. As this binding is specific
> to the TI dual-mode timers also known as dm-timers, let's use file name
> ti,timer-dm.yaml to avoid confusion with other timers.
> 
> We also correct the issue with the old binding that was out of date for
> several properties.
> 
> The am43 related timers are undocumented, but compatible with the am3
> timers. Let's add the am43 timers too.
> 
> The dm814 and dm816 timers are missing, let's add them.
> 
> Some timers on some SoCs are dual mapped, like the ABE timers on omap4
> and 5. The reg property maxItems must be updated to 2.

(...)

> +  reg:
> +    minItems: 1
> +    maxItems: 2
> +    description: Timer IO register range
> +

Apart from what Grygorii said, it would be useful if you add "if:then:"
case constraining it per implementation (as I understood from commit msg
only some use double mapping).

This looks like:
https://elixir.bootlin.com/linux/v5.18-rc2/source/Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml#L53

Similarly should be done for clocks, unless it's impossible (same
compatible uses different setups of clocks).

BTW, it's a bit confusing it is not a v2...


Best regards,
Krzysztof