From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/8] arm64: dts: qcom: sm8650-mtp: add interconnect dependent device nodes
Date: Sat, 18 Nov 2023 01:25:37 +0100 [thread overview]
Message-ID: <3f3f7c21-0d03-4b59-b12c-a72e1d2b82af@linaro.org> (raw)
In-Reply-To: <20231106-topic-sm8650-upstream-dt-v2-7-44d6f9710fa7@linaro.org>
On 6.11.2023 09:39, Neil Armstrong wrote:
> Now interconnect dependent devices are added in sm8650 DTSI,
> now enable more devices for the Qualcomm SM8650 MTP board:
> - PCIe
> - Display
> - DSPs
> - SDCard
> - UFS
> - USB role switch with PMIC Glink
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Little nits:
[...]
> &tlmm {
> gpio-reserved-ranges = <32 8>;
> +
> + sde_dsi_active: sde-dsi-active-state {
Dmitry voiced concerns about having the "SDE_" part here lately
is it part of the actual pin name (in the schematic)?
[...]
>
> &usb_1_dwc3 {
> - dr_mode = "peripheral";
> + dr_mode = "otg";
Isn't that the default?
Konrad
next prev parent reply other threads:[~2023-11-18 0:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 8:39 [PATCH v2 0/8] arm64: dts: qcom: Introduce SM8650 platforms device tree Neil Armstrong
2023-11-06 8:39 ` [PATCH v2 1/8] dt-bindings: arm: qcom: document SM8650 and the reference boards Neil Armstrong
2023-11-06 8:39 ` [PATCH v2 2/8] arm64: dts: qcom: add initial SM8650 dtsi Neil Armstrong
2023-11-18 0:21 ` Konrad Dybcio
2023-11-20 8:12 ` Neil Armstrong
2023-11-06 8:39 ` [PATCH v2 3/8] arm64: dts: qcom: pm8550ve: make PMK8550VE SID configurable Neil Armstrong
2023-11-06 8:39 ` [PATCH v2 4/8] arm64: dts: qcom: sm8650: add initial SM8650 MTP dts Neil Armstrong
2023-11-20 3:28 ` kernel test robot
2023-11-06 8:39 ` [PATCH v2 5/8] arm64: dts: qcom: sm8650: add initial SM8650 QRD dts Neil Armstrong
2023-11-06 8:39 ` [PATCH v2 6/8] arm64: dts: qcom: sm8650: add interconnect dependent device nodes Neil Armstrong
2023-11-06 8:39 ` [PATCH v2 7/8] arm64: dts: qcom: sm8650-mtp: " Neil Armstrong
2023-11-18 0:25 ` Konrad Dybcio [this message]
2023-11-20 8:11 ` Neil Armstrong
2023-11-06 8:39 ` [PATCH v2 8/8] arm64: dts: qcom: sm8650-qrd: " Neil Armstrong
2023-11-18 0:25 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f3f7c21-0d03-4b59-b12c-a72e1d2b82af@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).