From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B04ECC4332F for ; Tue, 26 Apr 2022 07:26:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244796AbiDZH3R (ORCPT ); Tue, 26 Apr 2022 03:29:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344024AbiDZH3M (ORCPT ); Tue, 26 Apr 2022 03:29:12 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06BB7BC26 for ; Tue, 26 Apr 2022 00:26:05 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id v4so8642471ljd.10 for ; Tue, 26 Apr 2022 00:26:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Ip4yKprUwa5CWGfKSGf6LxYHkAhSkHn2zyYdRVkuKYU=; b=lM/cGyNPCgOlRbQmCDv2N0LFI8Z/V1E3GPTN3qhv6IeGaKXN89UYs3/xI2kcwElbtG g4o7WQ9jIP5pxzL9gWHSBOjFqAIZilmXBnEWYQbWRlG+Vvr6Uu2mZXDNgx7F6qhoP6p7 KaIajNLuJH6vtSFd0Cptuqa6QLdml1zWy9D/S4XCiWhQOyKo2zKpYW8fOhzah8JTnb86 byhACWCLlrYEWu40468Fal0BIm0Ber8W91ukxTecLm6UqPyfCBNLhBWoewva5Gu7p9wu q6TWpnHeZ36EqEBakXDRlUbSiJXMjItpxV2Ynu6tgFrxGp+jmdY5mQuKU/zP36H7BgBq q9kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Ip4yKprUwa5CWGfKSGf6LxYHkAhSkHn2zyYdRVkuKYU=; b=lvJEdH11e9VjhcCLuY6/eZAJz6uv8r3f/0tmwUOa6z1Hd15w7x16JV05nyDnhVn4bg ArvaOF7wdedpIpcQLQumeBFcAzskAd4rhDrUwCM280U929kdRpM5KK1He55IL5NBP41b gl+QDA1TCXpi2dW4LFbpOE3LDzmcCjp4zwgClFGOmw4EkRRwQhDdZ3EYF35umTz38+S+ bUCTDVprbxBGyvnX3So3WyeHDQWo49C65y5Nr7bEFqqXRHHg00u1e2JNnBL3yoQkQJIe AwvYBFMfyT5R0oRQtNHgKQvXcpKTx86yjiCcn1be/GkVLw+JfWWaB+FjEb3OS1549lyY 1naQ== X-Gm-Message-State: AOAM530VZHOd/JGSmGWvw4KNUuWhDwZu5sc33hVkFO1OqOwRXvVP4LeL gXIM/wXHHLmMYS/n7D4HcMx5wg== X-Google-Smtp-Source: ABdhPJwYgtV/i5ybL48Y+kjThwzp8oCL1bzTgORpgBsO3BcnlY+Ccb/X9tyWeGjjIRdQU0g/NK/9JQ== X-Received: by 2002:a2e:bf12:0:b0:249:3a3b:e91a with SMTP id c18-20020a2ebf12000000b002493a3be91amr13833393ljr.343.1650957963192; Tue, 26 Apr 2022 00:26:03 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id h13-20020a056512338d00b0047203470747sm795653lfg.245.2022.04.26.00.26.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 00:26:02 -0700 (PDT) Message-ID: <3f407912-be75-19a8-d406-ae042d23fd9e@linaro.org> Date: Tue, 26 Apr 2022 10:26:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3 3/3] dt-bindings: clock: qcom,gcc-apq8064: split tsens to the child node Content-Language: en-GB To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Amit Kucheria , Thara Gopinath , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org References: <20220425212750.2749135-1-dmitry.baryshkov@linaro.org> <20220425212750.2749135-4-dmitry.baryshkov@linaro.org> <8579a3df-1a1d-c258-f65e-531cf0731949@linaro.org> From: Dmitry Baryshkov In-Reply-To: <8579a3df-1a1d-c258-f65e-531cf0731949@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/04/2022 10:08, Krzysztof Kozlowski wrote: > On 25/04/2022 23:27, Dmitry Baryshkov wrote: >> Split tsens properties to the child node of the gcc. This follows the >> lead of ipq8064 (which also uses a separate node for tsens) and makes >> device tree closer to other platforms, where tsens is a completely >> separate device. >> >> Signed-off-by: Dmitry Baryshkov >> --- >> .../bindings/clock/qcom,gcc-apq8064.yaml | 45 +++++++------------ >> 1 file changed, 17 insertions(+), 28 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml >> index b867da12761e..f2762599f679 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml >> @@ -23,47 +23,36 @@ description: | >> >> properties: >> compatible: >> - enum: >> - - qcom,gcc-apq8064 >> - - qcom,gcc-msm8060 > > Hm, such list does not exist in mainline, so is your set rebased on > something? See also: > https://lore.kernel.org/linux-devicetree/20220425133527.3723233-1-robh@kernel.org/ > https://lore.kernel.org/linux-devicetree/20220426064241.6379-1-krzysztof.kozlowski@linaro.org/ Ugh, yes. I missed a patch during git send-email. I've sent it separately (dt-bindings: clock: gcc-apq8064: move qcom,apq8084 back to gcc-other.yaml) > > >> - >> - nvmem-cells: >> - minItems: 1 >> - maxItems: 2 >> - description: >> - Qualcomm TSENS (thermal sensor device) on some devices can >> - be part of GCC and hence the TSENS properties can also be part >> - of the GCC/clock-controller node. >> - For more details on the TSENS properties please refer >> - Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> - >> - nvmem-cell-names: >> - minItems: 1 >> items: >> - - const: calib >> - - const: calib_backup > > I see the removal of tsens properties, but I do not see the other part > of split - adding them as child. It does not come from qcom,gcc.yaml, > either. > >> - >> - '#thermal-sensor-cells': >> - const: 1 >> + - enum: >> + - qcom,gcc-apq8064 >> + - qcom,gcc-msm8060 >> + - const: syscon >> >> required: >> - compatible >> - - nvmem-cells >> - - nvmem-cell-names >> - - '#thermal-sensor-cells' >> >> unevaluatedProperties: false >> >> examples: >> - | >> clock-controller@900000 { >> - compatible = "qcom,gcc-apq8064"; >> + compatible = "qcom,gcc-apq8064", "syscon"; >> reg = <0x00900000 0x4000>; >> - nvmem-cells = <&tsens_calib>, <&tsens_backup>; >> - nvmem-cell-names = "calib", "calib_backup"; >> #clock-cells = <1>; >> #reset-cells = <1>; >> #power-domain-cells = <1>; >> - #thermal-sensor-cells = <1>; >> + >> + thermal-sensor { >> + compatible = "qcom,msm8960-tsens"; >> + >> + nvmem-cells = <&tsens_calib>, <&tsens_backup>; >> + nvmem-cell-names = "calib", "calib_backup"; >> + interrupts = <0 178 4>; > > 0 and 4 look like GIC/interrupt flags, so please use defines. > >> + interrupt-names = "uplow"; >> + >> + #qcom,sensors = <11>; >> + #thermal-sensor-cells = <1>; >> + }; > > Indentation looks weird here. > >> }; >> ... > > > Best regards, > Krzysztof -- With best wishes Dmitry