devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Josua Mayer <josua@solid-run.com>, Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 02/11] dt-bindings: marvell: a38x: convert the soc compatibles description to yaml
Date: Thu, 4 Jan 2024 09:39:48 +0100	[thread overview]
Message-ID: <3f463dbd-14f7-4c2d-a464-647060cf45b8@linaro.org> (raw)
In-Reply-To: <20231230-support-clearfog-gtr-l8-sfp-v4-2-1d7f0e2c7128@solid-run.com>

On 30/12/2023 16:44, Josua Mayer wrote:
> Convert the existing txt binding for armada-38x socs to DT schema
> format.
> 

Where is the conversion? I don't see. Conversion means "remove and add"
in a diff. I see only second part.

> Note that the current bindings only document the SoC (armada380,
> armada385, armada388). This is undesirable, instead there should be
> entries for actual boards.
> 
> For now only convert to yaml, the content can be corrected separately.
> 
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
>  .../bindings/arm/marvell/armada-38x.yaml           | 33 ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> new file mode 100644
> index 000000000000..5af222e6db18
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Armada 38x Platforms
> +
> +maintainers:
> +  - Gregory CLEMENT <gregory.clement@bootlin.com>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +
> +      - description: Armada 380 SoC
> +        items:
> +          - const: marvell,armada380
> +
> +      - description: Armada 385 SoC
> +        items:
> +          - const: marvell,armada385
> +          - const: marvell,armada380
> +

No, we have been here.

NAK.

Best regards,
Krzysztof


  reply	other threads:[~2024-01-04  8:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-30 15:44 [PATCH v4 00/11] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards Josua Mayer
2023-12-30 15:44 ` [PATCH v4 01/11] dt-bindings: marvell: a38x: remove invalid txt bindings for armada 38x SoCs Josua Mayer
2024-01-04  8:39   ` Krzysztof Kozlowski
2023-12-30 15:44 ` [PATCH v4 02/11] dt-bindings: marvell: a38x: convert the soc compatibles description to yaml Josua Mayer
2024-01-04  8:39   ` Krzysztof Kozlowski [this message]
2024-01-04 12:14     ` Josua Mayer
2023-12-30 15:44 ` [PATCH v4 03/11] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards Josua Mayer
2024-01-04  8:41   ` Krzysztof Kozlowski
2023-12-30 15:44 ` [PATCH v4 04/11] dt-bindings: marvell: a38x: add kobol helios-4 board Josua Mayer
2024-01-04  8:43   ` Krzysztof Kozlowski
2024-01-04 12:28     ` Josua Mayer
2023-12-30 15:44 ` [PATCH v4 05/11] dt-bindings: marvell: a38x: add solidrun armada 385 clearfog gtr boards Josua Mayer
2024-01-04  8:43   ` Krzysztof Kozlowski
2023-12-30 15:44 ` [PATCH v4 06/11] arm: dts: marvell: clearfog: add pro variant compatible in legacy dts Josua Mayer
2023-12-30 15:44 ` [PATCH v4 07/11] arm: dts: marvell: clearfog-gtr: add board-specific compatible strings Josua Mayer
2023-12-30 15:44 ` [PATCH v4 08/11] arm: dts: marvell: clearfog-gtr: sort pinctrl nodes alphabetically Josua Mayer
2023-12-30 15:44 ` [PATCH v4 09/11] arm: dts: marvell: clearfog-gtr: add missing pinctrl for all used gpios Josua Mayer
2023-12-30 15:44 ` [PATCH v4 10/11] arm: dts: marvell: clearfog-gtr-l8: add support for second sfp connector Josua Mayer
2023-12-30 15:44 ` [PATCH v4 11/11] arm: dts: marvell: clearfog-gtr-l8: align port numbers with enclosure Josua Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f463dbd-14f7-4c2d-a464-647060cf45b8@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=josua@solid-run.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).