devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org
Cc: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Manivannan Sadhasivam <mani@kernel.org>
Subject: Re: [PATCH v2 05/17] dt-bindings: mtd: qcom: Fix a property position
Date: Mon, 19 Jun 2023 08:54:13 +0200	[thread overview]
Message-ID: <3f4f4beb-4136-312a-be0b-5ec018b4329d@linaro.org> (raw)
In-Reply-To: <20230606175246.190465-6-miquel.raynal@bootlin.com>

On 06/06/2023 19:52, Miquel Raynal wrote:
> qcom,boot-partitions is a NAND chip property, not a NAND controller
> property. Move the description of the property into the NAND chip
> section and just enable the property in the if/else block.
> 
> Fixes: 5278cc93a97f ("dt-bindings: mtd: qcom_nandc: document qcom,boot-partitions binding")
> Cc: Manivannan Sadhasivam <mani@kernel.org>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  .../devicetree/bindings/mtd/qcom,nandc.yaml   | 41 +++++++++++--------
>  1 file changed, 25 insertions(+), 16 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml b/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml
> index 07024ee45951..7217d8a64d14 100644
> --- a/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml
> +++ b/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml
> @@ -45,6 +45,22 @@ patternProperties:
>          enum:
>            - 512
>  
> +      qcom,boot-partitions:
> +        $ref: /schemas/types.yaml#/definitions/uint32-matrix
> +        items:
> +          items:
> +            - description: offset
> +            - description: size
> +        description:
> +          Boot partition use a different layout where the 4 bytes of spare
> +          data are not protected by ECC. Use this to declare these special
> +          partitions by defining first the offset and then the size.
> +
> +          It's in the form of <offset1 size1 offset2 size2 offset3 ...>
> +          and should be declared in ascending order.
> +
> +          Refer to the ipq8064 example on how to use this special binding.
> +
>  allOf:
>    - $ref: "nand-controller.yaml#"

Also based on some old tree.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


  reply	other threads:[~2023-06-19  6:54 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 17:52 [PATCH v2 00/17] Prevent NAND chip unevaluated properties Miquel Raynal
2023-06-06 17:52 ` [PATCH v2 01/17] dt-bindings: mtd: Accept nand related node names Miquel Raynal
2023-06-19  6:28   ` Krzysztof Kozlowski
2023-06-06 17:52 ` [PATCH v2 02/17] dt-bindings: mtd: Create a file for raw NAND chip properties Miquel Raynal
2023-06-19  6:28   ` Krzysztof Kozlowski
2023-06-19  6:59     ` Miquel Raynal
2023-06-06 17:52 ` [PATCH v2 03/17] dt-bindings: mtd: Mark nand-ecc-placement deprecated Miquel Raynal
2023-06-19  6:34   ` Krzysztof Kozlowski
2023-06-06 17:52 ` [PATCH v2 04/17] dt-bindings: mtd: Describe nand-ecc-mode Miquel Raynal
2023-06-19  6:51   ` Krzysztof Kozlowski
2023-06-06 17:52 ` [PATCH v2 05/17] dt-bindings: mtd: qcom: Fix a property position Miquel Raynal
2023-06-19  6:54   ` Krzysztof Kozlowski [this message]
2023-06-19  7:19     ` Miquel Raynal
2023-06-06 17:52 ` [PATCH v2 06/17] dt-bindings: mtd: qcom: Prevent NAND chip unevaluated properties Miquel Raynal
2023-06-06 22:27   ` Chris Packham
2023-06-07  7:53     ` Miquel Raynal
2023-06-07 20:47       ` Chris Packham
2023-06-06 17:52 ` [PATCH v2 07/17] dt-bindings: mtd: ingenic: " Miquel Raynal
2023-06-06 18:52   ` Rob Herring
2023-06-07  9:33     ` Miquel Raynal
2023-06-08 15:20       ` Rob Herring
2023-06-09  8:36         ` Miquel Raynal
2023-06-06 17:52 ` [PATCH v2 08/17] dt-bindings: mtd: sunxi: " Miquel Raynal
2023-06-06 18:52   ` Rob Herring
2023-06-06 17:52 ` [PATCH v2 09/17] dt-bindings: mtd: meson: " Miquel Raynal
2023-06-06 18:52   ` Rob Herring
2023-06-06 17:52 ` [PATCH v2 10/17] dt-bindings: mtd: brcmnand: " Miquel Raynal
2023-06-06 18:52   ` Rob Herring
2023-06-06 17:52 ` [PATCH v2 11/17] dt-bindings: mtd: denali: " Miquel Raynal
2023-06-06 18:52   ` Rob Herring
2023-06-06 17:52 ` [PATCH v2 12/17] dt-bindings: mtd: intel: " Miquel Raynal
2023-06-06 18:52   ` Rob Herring
2023-06-06 17:52 ` [PATCH v2 13/17] dt-bindings: mtd: rockchip: " Miquel Raynal
2023-06-06 18:52   ` Rob Herring
2023-06-06 17:52 ` [PATCH v2 14/17] dt-bindings: mtd: stm32: " Miquel Raynal
2023-06-06 17:52 ` [PATCH v2 15/17] dt-bindings: mtd: mediatek: Reference raw-nand-chip.yaml Miquel Raynal
2023-06-06 18:52   ` Rob Herring
2023-06-06 17:52 ` [PATCH v2 16/17] dt-bindings: mtd: mediatek: Prevent NAND chip unevaluated properties Miquel Raynal
2023-06-06 18:52   ` Rob Herring
2023-06-06 17:52 ` [PATCH v2 17/17] dt-bindings: mtd: ti,am654: Prevent " Miquel Raynal
2023-06-09 20:51 ` [PATCH v2 00/17] Prevent NAND chip " Rob Herring
2023-06-10  9:27 ` Krzysztof Kozlowski
2023-06-13 11:43   ` Miquel Raynal
2023-06-15  8:26     ` Miquel Raynal
2023-09-27  7:20 ` Maxime Ripard
2023-09-27 15:35   ` Maxime Ripard
2023-09-27  7:20 ` Maxime Ripard
2023-09-27  7:20 ` Maxime Ripard
2023-09-27  7:21 ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f4f4beb-4136-312a-be0b-5ec018b4329d@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Chris.Packham@alliedtelesis.co.nz \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mani@kernel.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).