From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 483D0C77B72 for ; Fri, 14 Apr 2023 11:28:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230099AbjDNL2p (ORCPT ); Fri, 14 Apr 2023 07:28:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbjDNL2n (ORCPT ); Fri, 14 Apr 2023 07:28:43 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42A7E6A6B for ; Fri, 14 Apr 2023 04:28:40 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-94a9606518cso296163866b.2 for ; Fri, 14 Apr 2023 04:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681471719; x=1684063719; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4aiRpESCbLxQk+SHaAMEqLmff7Uno7K02X/hy0RYyko=; b=dl3Hg++Qv6HfQT/L9JjS5DV2rWbm0glWZt1wU9yWmWgajcJZlOzZzJLa+8AONcugzk 7pS5VpouSIAQ3edfaPssbx5NVRdQbtCjDh5YISgKCabxnDoLPq93amDKmL1mQpOjIBBN MFwdFn2f6zQ9PDGvEDiM5GVPXZqzMJUQPrnSHVeMPzIlC7mUptjMKlEe0ZXHFK5PMFGV zznUTSnKxEmIjt01wKa0FyQdcdD5Apmo+kePLjt0EysiN+++oq5u/8XfOZl9wVmn70WK 5qw+oPQCyJpbo5IO0ML3LsNRW11hsI19uepOIwSn2ZZjQh3cVKslxbKkUHGVXWoq7EDd Qg5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681471719; x=1684063719; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4aiRpESCbLxQk+SHaAMEqLmff7Uno7K02X/hy0RYyko=; b=KvyBREoEl/xX7umBoJQy3SorK66F2YXmeiI03uMHOKGSTjj2bZ1ETV6OSB247YIicW FdCsH/HocSa6Uc9lrnvpGSxRpcSQ1bmP9ayEI8mj//bl0yMNywPHtBDSMU6PYvzyV2zb 6ngq2tOu0z0yXJt7Bcv8Hwgr8EZeMmBdlabjZdyCQ5tTGiyj9Ac4eVIzL8Fr/yMnRTPD 2DBc919yTIb0qotyoX6CcPI/cQIFoYmmfHCCpNGhBrVTFijzZAaV0nRnIsy2koueBYKl DcjFw8bV0W5nBL30eJXnG16iokpPNgKPGgTzOJMvJg7jDBE9/oFPLUFDMdPUv5puUrAZ DMdA== X-Gm-Message-State: AAQBX9c/GIITLFxpJFnzg7DJmFFqrX0OcmMXXkAImzzWSEj+6V0RIu2E fBDMywo3yplbIeq+HG7Pl2hWIWOkdthfJClfICw= X-Google-Smtp-Source: AKy350a3Sy2CqykR/sk8IhliNFf2Djv54ny9JClOEK+yPtCZ5o7ogUd06Gii/jIrfmuVUmcNljWjSw== X-Received: by 2002:aa7:d7d4:0:b0:504:8c1a:70db with SMTP id e20-20020aa7d7d4000000b005048c1a70dbmr6581398eds.32.1681471718716; Fri, 14 Apr 2023 04:28:38 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:40b9:8c57:b112:651d? ([2a02:810d:15c0:828:40b9:8c57:b112:651d]) by smtp.gmail.com with ESMTPSA id w15-20020aa7da4f000000b00504890a0de5sm2023467eds.34.2023.04.14.04.28.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 04:28:38 -0700 (PDT) Message-ID: <3f6d77cc-5a9b-47b4-db41-5fd172d2ecb6@linaro.org> Date: Fri, 14 Apr 2023 13:28:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Use generic name for es8316 on rk3588-rock-5b Content-Language: en-US To: Cristian Ciocaltea , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Christopher Obbard , Michael Riesch , Sebastian Reichel , Shreeya Patel Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230414093411.113787-1-cristian.ciocaltea@collabora.com> <20230414093411.113787-3-cristian.ciocaltea@collabora.com> <4d66fb01-76da-be30-26dd-908ee1a22eb1@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <4d66fb01-76da-be30-26dd-908ee1a22eb1@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/04/2023 12:53, Cristian Ciocaltea wrote: > On 4/14/23 13:26, Krzysztof Kozlowski wrote: >> On 14/04/2023 11:34, Cristian Ciocaltea wrote: >>> Use generic 'audio-codec' name for es8316 node on Rock 5B board. >>> >>> Signed-off-by: Cristian Ciocaltea >>> --- >>> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>> index 62750beb12aa..8cc97d146a73 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >>> @@ -72,7 +72,7 @@ hym8563: rtc@51 { >>> &i2c7 { >>> status = "okay"; >>> >>> - es8316: es8316@11 { >>> + es8316: audio-codec@11 { >> >> This is a trivial change. Fix all instances in all subarch/platform DTS. >> Not board-per-board. > > Looks like only the rockchip DTS are affected, but not quite sure how to > proceed in the case of 'es8316: codec@', should I change them to > 'es8316: audio-codec@' as well? > > arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts: es8316: es8316@11 { No, fix only this. Best regards, Krzysztof