[PATCH 0/3] Add regulators to Rock 5B's CPU big cores

[PATCH 0/3] Add regulators to Rock 5B's CPU big cores

[Cristian Ciocaltea]

The CPU big cores on the Rock 5B board are powered by the RK8602/RK8603
regulators. Since the support for those regulators has been recently 
merged via [1], add the necessary device tree nodes and bind them to 
the corresponding CPU nodes.

Additionally, provide a couple of unrelated DTS fixes/improvements.

[1] https://lore.kernel.org/lkml/20230406194158.963352-1-cristian.ciocaltea@collabora.com/

Cristian Ciocaltea (3):
  arm64: dts: rockchip: Drop RTC clock-frequency on rk3588-rock-5b
  arm64: dts: rockchip: Use generic name for es8316 on rk3588-rock-5b
  arm64: dts: rockchip: Add vdd_cpu_big regulators to rk3588-rock-5b

 .../boot/dts/rockchip/rk3588-rock-5b.dts      | 59 ++++++++++++++++++-
 1 file changed, 57 insertions(+), 2 deletions(-)

-- 
2.40.0

[PATCH 1/3] arm64: dts: rockchip: Drop RTC clock-frequency on rk3588-rock-5b

[Cristian Ciocaltea]

The hym8563 RTC driver doesn't handle the 'clock-frequency' property,
which is also indicated by the following dtbs_check warning:

  rk3588-rock-5b.dtb: rtc@51: Unevaluated properties are not allowed ('clock-frequency' was unexpected)
  From schema: Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml

Drop the unsupported property.

Fixes: 1e9c2404d887 ("arm64: dts: rockchip: Enable RTC support for Rock 5B")
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 88b9f7ddf291..62750beb12aa 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -60,7 +60,6 @@ hym8563: rtc@51 {
 		compatible = "haoyu,hym8563";
 		reg = <0x51>;
 		#clock-cells = <0>;
-		clock-frequency = <32768>;
 		clock-output-names = "hym8563";
 		pinctrl-names = "default";
 		pinctrl-0 = <&hym8563_int>;
-- 
2.40.0

[PATCH 2/3] arm64: dts: rockchip: Use generic name for es8316 on rk3588-rock-5b

[Cristian Ciocaltea]

Use generic 'audio-codec' name for es8316 node on Rock 5B board.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 62750beb12aa..8cc97d146a73 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -72,7 +72,7 @@ hym8563: rtc@51 {
 &i2c7 {
 	status = "okay";
 
-	es8316: es8316@11 {
+	es8316: audio-codec@11 {
 		compatible = "everest,es8316";
 		reg = <0x11>;
 		clocks = <&cru I2S0_8CH_MCLKOUT>;
-- 
2.40.0

Re: [PATCH 2/3] arm64: dts: rockchip: Use generic name for es8316 on rk3588-rock-5b

[Krzysztof Kozlowski]

On 14/04/2023 11:34, Cristian Ciocaltea wrote:
> Use generic 'audio-codec' name for es8316 node on Rock 5B board.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 62750beb12aa..8cc97d146a73 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -72,7 +72,7 @@ hym8563: rtc@51 {
>  &i2c7 {
>  	status = "okay";
>  
> -	es8316: es8316@11 {
> +	es8316: audio-codec@11 {

This is a trivial change. Fix all instances in all subarch/platform DTS.
Not board-per-board.

Best regards,
Krzysztof

Re: [PATCH 2/3] arm64: dts: rockchip: Use generic name for es8316 on rk3588-rock-5b

[Cristian Ciocaltea]

On 4/14/23 13:26, Krzysztof Kozlowski wrote:
> On 14/04/2023 11:34, Cristian Ciocaltea wrote:
>> Use generic 'audio-codec' name for es8316 node on Rock 5B board.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> index 62750beb12aa..8cc97d146a73 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> @@ -72,7 +72,7 @@ hym8563: rtc@51 {
>>  &i2c7 {
>>  	status = "okay";
>>  
>> -	es8316: es8316@11 {
>> +	es8316: audio-codec@11 {
> 
> This is a trivial change. Fix all instances in all subarch/platform DTS.
> Not board-per-board.

Looks like only the rockchip DTS are affected, but not quite sure how to 
proceed in the case of 'es8316: codec@', should I change them to 
'es8316: audio-codec@' as well?

arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts:   es8316: es8316@11 {
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi:     es8316: codec@11 {
arch/arm64/boot/dts/rockchip/rk3399-rockpro64-v2.dts:   es8316: codec@10 {
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts:      es8316: codec@11 {

Re: [PATCH 2/3] arm64: dts: rockchip: Use generic name for es8316 on rk3588-rock-5b

[Krzysztof Kozlowski]

On 14/04/2023 12:53, Cristian Ciocaltea wrote:
> On 4/14/23 13:26, Krzysztof Kozlowski wrote:
>> On 14/04/2023 11:34, Cristian Ciocaltea wrote:
>>> Use generic 'audio-codec' name for es8316 node on Rock 5B board.
>>>
>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>> ---
>>>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> index 62750beb12aa..8cc97d146a73 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> @@ -72,7 +72,7 @@ hym8563: rtc@51 {
>>>  &i2c7 {
>>>  	status = "okay";
>>>  
>>> -	es8316: es8316@11 {
>>> +	es8316: audio-codec@11 {
>>
>> This is a trivial change. Fix all instances in all subarch/platform DTS.
>> Not board-per-board.
> 
> Looks like only the rockchip DTS are affected, but not quite sure how to 
> proceed in the case of 'es8316: codec@', should I change them to 
> 'es8316: audio-codec@' as well?
> 
> arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts:   es8316: es8316@11 {

No, fix only this.

Best regards,
Krzysztof

[PATCH 3/3] arm64: dts: rockchip: Add vdd_cpu_big regulators to rk3588-rock-5b

[Cristian Ciocaltea]

The RK8602 and RK8603 voltage regulators on the Rock 5B board provide
the power lines vdd_cpu_big0 and vdd_cpu_big1, respectively.

Add the necessary device tree nodes and bind them to the corresponding
CPU big core nodes.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 .../boot/dts/rockchip/rk3588-rock-5b.dts      | 56 +++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 8cc97d146a73..3e4aee8f70c1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -53,6 +53,62 @@ vcc5v0_sys: vcc5v0-sys-regulator {
 	};
 };
 
+&cpu_b0 {
+	cpu-supply = <&vdd_cpu_big0_s0>;
+};
+
+&cpu_b1 {
+	cpu-supply = <&vdd_cpu_big0_s0>;
+};
+
+&cpu_b2 {
+	cpu-supply = <&vdd_cpu_big1_s0>;
+};
+
+&cpu_b3 {
+	cpu-supply = <&vdd_cpu_big1_s0>;
+};
+
+&i2c0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c0m2_xfer>;
+	status = "okay";
+
+	vdd_cpu_big0_s0: regulator@42 {
+		compatible = "rockchip,rk8602";
+		reg = <0x42>;
+		fcs,suspend-voltage-selector = <1>;
+		regulator-name = "vdd_cpu_big0_s0";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <550000>;
+		regulator-max-microvolt = <1050000>;
+		regulator-ramp-delay = <2300>;
+		vin-supply = <&vcc5v0_sys>;
+
+		regulator-state-mem {
+			regulator-off-in-suspend;
+		};
+	};
+
+	vdd_cpu_big1_s0: regulator@43 {
+		compatible = "rockchip,rk8603", "rockchip,rk8602";
+		reg = <0x43>;
+		fcs,suspend-voltage-selector = <1>;
+		regulator-name = "vdd_cpu_big1_s0";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <550000>;
+		regulator-max-microvolt = <1050000>;
+		regulator-ramp-delay = <2300>;
+		vin-supply = <&vcc5v0_sys>;
+
+		regulator-state-mem {
+			regulator-off-in-suspend;
+		};
+	};
+};
+
 &i2c6 {
 	status = "okay";
 
-- 
2.40.0

Re: [PATCH 3/3] arm64: dts: rockchip: Add vdd_cpu_big regulators to rk3588-rock-5b

[Krzysztof Kozlowski]

On 14/04/2023 11:34, Cristian Ciocaltea wrote:
> The RK8602 and RK8603 voltage regulators on the Rock 5B board provide
> the power lines vdd_cpu_big0 and vdd_cpu_big1, respectively.
> 
> Add the necessary device tree nodes and bind them to the corresponding
> CPU big core nodes.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 56 +++++++++++++++++++
>  1 file changed, 56 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 8cc97d146a73..3e4aee8f70c1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -53,6 +53,62 @@ vcc5v0_sys: vcc5v0-sys-regulator {
>  	};
>  };
>  
> +&cpu_b0 {
> +	cpu-supply = <&vdd_cpu_big0_s0>;
> +};
> +
> +&cpu_b1 {
> +	cpu-supply = <&vdd_cpu_big0_s0>;
> +};
> +
> +&cpu_b2 {
> +	cpu-supply = <&vdd_cpu_big1_s0>;
> +};
> +
> +&cpu_b3 {
> +	cpu-supply = <&vdd_cpu_big1_s0>;
> +};
> +
> +&i2c0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&i2c0m2_xfer>;
> +	status = "okay";
> +
> +	vdd_cpu_big0_s0: regulator@42 {
> +		compatible = "rockchip,rk8602";

Looking at your next node, this is surprising... Double check if you
have correct compatibles everywhere.

> +		reg = <0x42>;
> +		fcs,suspend-voltage-selector = <1>;

Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).

> +		regulator-name = "vdd_cpu_big0_s0";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <550000>;
> +		regulator-max-microvolt = <1050000>;
> +		regulator-ramp-delay = <2300>;
> +		vin-supply = <&vcc5v0_sys>;
> +
> +		regulator-state-mem {
> +			regulator-off-in-suspend;
> +		};
> +	};
> +
> +	vdd_cpu_big1_s0: regulator@43 {
> +		compatible = "rockchip,rk8603", "rockchip,rk8602";
> +		reg = <0x43>;
> +		fcs,suspend-voltage-selector = <1>;

Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).

Best regards,
Krzysztof

Re: [PATCH 3/3] arm64: dts: rockchip: Add vdd_cpu_big regulators to rk3588-rock-5b

[Cristian Ciocaltea]

On 4/14/23 13:27, Krzysztof Kozlowski wrote:
> On 14/04/2023 11:34, Cristian Ciocaltea wrote:
>> The RK8602 and RK8603 voltage regulators on the Rock 5B board provide
>> the power lines vdd_cpu_big0 and vdd_cpu_big1, respectively.
>>
>> Add the necessary device tree nodes and bind them to the corresponding
>> CPU big core nodes.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 56 +++++++++++++++++++
>>  1 file changed, 56 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> index 8cc97d146a73..3e4aee8f70c1 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> @@ -53,6 +53,62 @@ vcc5v0_sys: vcc5v0-sys-regulator {
>>  	};
>>  };
>>  
>> +&cpu_b0 {
>> +	cpu-supply = <&vdd_cpu_big0_s0>;
>> +};
>> +
>> +&cpu_b1 {
>> +	cpu-supply = <&vdd_cpu_big0_s0>;
>> +};
>> +
>> +&cpu_b2 {
>> +	cpu-supply = <&vdd_cpu_big1_s0>;
>> +};
>> +
>> +&cpu_b3 {
>> +	cpu-supply = <&vdd_cpu_big1_s0>;
>> +};
>> +
>> +&i2c0 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&i2c0m2_xfer>;
>> +	status = "okay";
>> +
>> +	vdd_cpu_big0_s0: regulator@42 {
>> +		compatible = "rockchip,rk8602";
> 
> Looking at your next node, this is surprising... Double check if you
> have correct compatibles everywhere.
> 
>> +		reg = <0x42>;
>> +		fcs,suspend-voltage-selector = <1>;
> 
> Does not look like you tested the DTS against bindings. Please run `make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).
> 
>> +		regulator-name = "vdd_cpu_big0_s0";
>> +		regulator-always-on;
>> +		regulator-boot-on;
>> +		regulator-min-microvolt = <550000>;
>> +		regulator-max-microvolt = <1050000>;
>> +		regulator-ramp-delay = <2300>;
>> +		vin-supply = <&vcc5v0_sys>;
>> +
>> +		regulator-state-mem {
>> +			regulator-off-in-suspend;
>> +		};
>> +	};
>> +
>> +	vdd_cpu_big1_s0: regulator@43 {
>> +		compatible = "rockchip,rk8603", "rockchip,rk8602";
>> +		reg = <0x43>;
>> +		fcs,suspend-voltage-selector = <1>;
> 
> Does not look like you tested the DTS against bindings. Please run `make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).

I mentioned in the cover letter that the support for the RK860X 
regulators has been recently merged via [1]. The patches in this 
series have been verified on next-20230413.

[1] https://lore.kernel.org/lkml/20230406194158.963352-1-cristian.ciocaltea@collabora.com/

Thanks,
Cristian

Re: [PATCH 3/3] arm64: dts: rockchip: Add vdd_cpu_big regulators to rk3588-rock-5b

[Krzysztof Kozlowski]

On 14/04/2023 12:40, Cristian Ciocaltea wrote:
> On 4/14/23 13:27, Krzysztof Kozlowski wrote:
>> On 14/04/2023 11:34, Cristian Ciocaltea wrote:
>>> The RK8602 and RK8603 voltage regulators on the Rock 5B board provide
>>> the power lines vdd_cpu_big0 and vdd_cpu_big1, respectively.
>>>
>>> Add the necessary device tree nodes and bind them to the corresponding
>>> CPU big core nodes.
>>>
>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>> ---
>>>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 56 +++++++++++++++++++
>>>  1 file changed, 56 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> index 8cc97d146a73..3e4aee8f70c1 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>> @@ -53,6 +53,62 @@ vcc5v0_sys: vcc5v0-sys-regulator {
>>>  	};
>>>  };
>>>  
>>> +&cpu_b0 {
>>> +	cpu-supply = <&vdd_cpu_big0_s0>;
>>> +};
>>> +
>>> +&cpu_b1 {
>>> +	cpu-supply = <&vdd_cpu_big0_s0>;
>>> +};
>>> +
>>> +&cpu_b2 {
>>> +	cpu-supply = <&vdd_cpu_big1_s0>;
>>> +};
>>> +
>>> +&cpu_b3 {
>>> +	cpu-supply = <&vdd_cpu_big1_s0>;
>>> +};
>>> +
>>> +&i2c0 {
>>> +	pinctrl-names = "default";
>>> +	pinctrl-0 = <&i2c0m2_xfer>;
>>> +	status = "okay";
>>> +
>>> +	vdd_cpu_big0_s0: regulator@42 {
>>> +		compatible = "rockchip,rk8602";
>>
>> Looking at your next node, this is surprising... Double check if you
>> have correct compatibles everywhere.
>>
>>> +		reg = <0x42>;
>>> +		fcs,suspend-voltage-selector = <1>;
>>
>> Does not look like you tested the DTS against bindings. Please run `make
>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>> for instructions).
>>
>>> +		regulator-name = "vdd_cpu_big0_s0";
>>> +		regulator-always-on;
>>> +		regulator-boot-on;
>>> +		regulator-min-microvolt = <550000>;
>>> +		regulator-max-microvolt = <1050000>;
>>> +		regulator-ramp-delay = <2300>;
>>> +		vin-supply = <&vcc5v0_sys>;
>>> +
>>> +		regulator-state-mem {
>>> +			regulator-off-in-suspend;
>>> +		};
>>> +	};
>>> +
>>> +	vdd_cpu_big1_s0: regulator@43 {
>>> +		compatible = "rockchip,rk8603", "rockchip,rk8602";
>>> +		reg = <0x43>;
>>> +		fcs,suspend-voltage-selector = <1>;
>>
>> Does not look like you tested the DTS against bindings. Please run `make
>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>> for instructions).
> 
> I mentioned in the cover letter that the support for the RK860X 
> regulators has been recently merged via [1]. The patches in this 
> series have been verified on next-20230413.

OK. The question about compatibles still stays - but maybe you have
indeed 8603 and 8602 in the same time.

Best regards,
Krzysztof

Re: [PATCH 3/3] arm64: dts: rockchip: Add vdd_cpu_big regulators to rk3588-rock-5b

[Cristian Ciocaltea]

On 4/14/23 14:29, Krzysztof Kozlowski wrote:
> On 14/04/2023 12:40, Cristian Ciocaltea wrote:
>> On 4/14/23 13:27, Krzysztof Kozlowski wrote:
>>> On 14/04/2023 11:34, Cristian Ciocaltea wrote:
>>>> The RK8602 and RK8603 voltage regulators on the Rock 5B board provide
>>>> the power lines vdd_cpu_big0 and vdd_cpu_big1, respectively.
>>>>
>>>> Add the necessary device tree nodes and bind them to the corresponding
>>>> CPU big core nodes.
>>>>
>>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>>> ---
>>>>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 56 +++++++++++++++++++
>>>>  1 file changed, 56 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>>> index 8cc97d146a73..3e4aee8f70c1 100644
>>>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>>>> @@ -53,6 +53,62 @@ vcc5v0_sys: vcc5v0-sys-regulator {
>>>>  	};
>>>>  };
>>>>  
>>>> +&cpu_b0 {
>>>> +	cpu-supply = <&vdd_cpu_big0_s0>;
>>>> +};
>>>> +
>>>> +&cpu_b1 {
>>>> +	cpu-supply = <&vdd_cpu_big0_s0>;
>>>> +};
>>>> +
>>>> +&cpu_b2 {
>>>> +	cpu-supply = <&vdd_cpu_big1_s0>;
>>>> +};
>>>> +
>>>> +&cpu_b3 {
>>>> +	cpu-supply = <&vdd_cpu_big1_s0>;
>>>> +};
>>>> +
>>>> +&i2c0 {
>>>> +	pinctrl-names = "default";
>>>> +	pinctrl-0 = <&i2c0m2_xfer>;
>>>> +	status = "okay";
>>>> +
>>>> +	vdd_cpu_big0_s0: regulator@42 {
>>>> +		compatible = "rockchip,rk8602";
>>>
>>> Looking at your next node, this is surprising... Double check if you
>>> have correct compatibles everywhere.
>>>
>>>> +		reg = <0x42>;
>>>> +		fcs,suspend-voltage-selector = <1>;
>>>
>>> Does not look like you tested the DTS against bindings. Please run `make
>>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>>> for instructions).
>>>
>>>> +		regulator-name = "vdd_cpu_big0_s0";
>>>> +		regulator-always-on;
>>>> +		regulator-boot-on;
>>>> +		regulator-min-microvolt = <550000>;
>>>> +		regulator-max-microvolt = <1050000>;
>>>> +		regulator-ramp-delay = <2300>;
>>>> +		vin-supply = <&vcc5v0_sys>;
>>>> +
>>>> +		regulator-state-mem {
>>>> +			regulator-off-in-suspend;
>>>> +		};
>>>> +	};
>>>> +
>>>> +	vdd_cpu_big1_s0: regulator@43 {
>>>> +		compatible = "rockchip,rk8603", "rockchip,rk8602";
>>>> +		reg = <0x43>;
>>>> +		fcs,suspend-voltage-selector = <1>;
>>>
>>> Does not look like you tested the DTS against bindings. Please run `make
>>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>>> for instructions).
>>
>> I mentioned in the cover letter that the support for the RK860X 
>> regulators has been recently merged via [1]. The patches in this 
>> series have been verified on next-20230413.
> 
> OK. The question about compatibles still stays - but maybe you have
> indeed 8603 and 8602 in the same time.

Yes, according to [1], initially discussed in [2].

[1] https://lore.kernel.org/lkml/20230406194158.963352-2-cristian.ciocaltea@collabora.com/
[2] https://lore.kernel.org/lkml/ea1dfe0f-4ed3-9bfb-dc6b-6d87b0267a99@linaro.org/

Regards,
Cristian