From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/7] arm64: dts: exynos: use proper node names for GPIO based I2C busses
Date: Mon, 19 May 2025 17:05:41 +0200 [thread overview]
Message-ID: <3f6e1b74-5d19-4194-b98b-91ab6f10446c@kernel.org> (raw)
In-Reply-To: <aCtD7BH5N_uPGkq7@shikoro>
On 19/05/2025 16:45, Wolfram Sang wrote:
>
>> You did not paste the warning in commit msg, so I don't know the
>> rationale, but at first glance this is not correct. "-0" is the
>> preferred suffix. "0" is not.
>
> Here is an example:
>
> .../Kernel/linux/arch/arm/boot/dts/microchip/usb_a9g20.dtb: i2c-gpio-0 (i2c-gpio): $nodename:0: 'i2c-gpio-0' does not match '^i2c(@.+|-[a-z0-9]+)?$'
> from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
>
... so clearly the suffix is "-foo" or "-0", as we usually prefer. This
should be replaced into i2c-X, by dropping "gpio", instead of using less
favored suffixing (one without -).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-19 15:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 12:15 [PATCH 0/7] archs: use proper node names for GPIO based I2C busses Wolfram Sang
2025-05-19 12:15 ` [PATCH 1/7] arm64: dts: exynos: " Wolfram Sang
2025-05-19 13:54 ` Krzysztof Kozlowski
2025-05-19 14:45 ` Wolfram Sang
2025-05-19 15:05 ` Krzysztof Kozlowski [this message]
2025-05-19 15:14 ` Wolfram Sang
2025-05-19 16:11 ` Krzysztof Kozlowski
2025-05-19 16:25 ` Wolfram Sang
2025-05-19 18:50 ` Wolfram Sang
2025-06-12 7:46 ` Krzysztof Kozlowski
2025-06-12 7:50 ` Wolfram Sang
2025-06-12 9:02 ` Krzysztof Kozlowski
2025-06-12 9:49 ` Krzysztof Kozlowski
2025-06-12 9:54 ` Wolfram Sang
2025-05-19 16:28 ` Herve Codina
2025-05-19 12:15 ` [PATCH 2/7] arm64: dts: mediatek: " Wolfram Sang
2025-05-19 12:15 ` [PATCH 3/7] ARM: dts: microchip: " Wolfram Sang
2025-05-19 12:15 ` [PATCH 4/7] ARM: dts: samsung: " Wolfram Sang
2025-05-19 12:15 ` [PATCH 5/7] ARM: dts: stm32: " Wolfram Sang
2025-05-19 12:15 ` [PATCH 6/7] LoongArch: dts: " Wolfram Sang
2025-05-19 12:15 ` [PATCH 7/7] riscv: dts: allwinner: " Wolfram Sang
2025-05-19 13:10 ` Chen-Yu Tsai
2025-05-19 12:54 ` [PATCH 0/7] archs: " Geert Uytterhoeven
2025-05-19 14:47 ` Wolfram Sang
2025-05-19 18:59 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f6e1b74-5d19-4194-b98b-91ab6f10446c@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).