Devicetree
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
To: Conor Dooley <conor@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: riscv: cpus: reg matches hart ID
Date: Sun, 28 Jan 2024 19:23:39 +0100	[thread overview]
Message-ID: <3f751ed6-871e-424e-a50e-4362e1bfb527@canonical.com> (raw)
In-Reply-To: <20240128-simile-endocrine-9e8af979d361@spud>

On 1/28/24 19:20, Conor Dooley wrote:
> On Sun, Jan 28, 2024 at 07:06:21PM +0100, Heinrich Schuchardt wrote:
>> Add a description to the CPU reg property to clarify that
>> the reg property must match the hart ID.
> 
> That is the expected usage alright. Did you come across something where
> it was not being used in that way?

No. I was simply missing it in the documentation.

There is a page 
https://www.kernel.org/doc/Documentation/devicetree/bindings/riscv/cpus.txt 
but that seems not to be generated from the kernel tree.

Best regards

Heinrich

> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Cheers,
> Conor.
> 
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>> ---
>>   Documentation/devicetree/bindings/riscv/cpus.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/riscv/cpus.yaml b/Documentation/devicetree/bindings/riscv/cpus.yaml
>> index f392e367d673..fa9da59d9316 100644
>> --- a/Documentation/devicetree/bindings/riscv/cpus.yaml
>> +++ b/Documentation/devicetree/bindings/riscv/cpus.yaml
>> @@ -74,6 +74,10 @@ properties:
>>         - riscv,sv57
>>         - riscv,none
>>   
>> +  reg:
>> +    description:
>> +      The hart ID of this CPU node.
>> +
>>     riscv,cbom-block-size:
>>       $ref: /schemas/types.yaml#/definitions/uint32
>>       description:
>> -- 
>> 2.43.0
>>


  reply	other threads:[~2024-01-28 18:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-28 18:06 [PATCH 1/1] dt-bindings: riscv: cpus: reg matches hart ID Heinrich Schuchardt
2024-01-28 18:20 ` Conor Dooley
2024-01-28 18:23   ` Heinrich Schuchardt [this message]
2024-01-28 18:40     ` Conor Dooley
2024-02-26  9:46   ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f751ed6-871e-424e-a50e-4362e1bfb527@canonical.com \
    --to=heinrich.schuchardt@canonical.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox