From: Paolo Abeni <pabeni@redhat.com>
To: Jay Monkman <jtm@lopingdog.com>, Andrew Lunn <andrew@lunn.ch>
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Piergiorgio Beruto <piergiorgio.beruto@gmail.com>,
Arndt Schuebel <Arndt.Schuebel@onsemi.com>,
Parthiban.Veerasooran@microchip.com
Subject: Re: [PATCH 4/4] net/onsemi: Add NCN26010 driver
Date: Tue, 19 Sep 2023 11:47:30 +0200 [thread overview]
Message-ID: <3f79b0d4b9409a223f03c0b36b3544ce1389a500.camel@redhat.com> (raw)
In-Reply-To: <ZQkNfAOYgsBIhBRW@lopingdog.com>
On Mon, 2023-09-18 at 21:54 -0500, Jay Monkman wrote:
> On Mon, Sep 18, 2023 at 06:00:37PM +0200, Andrew Lunn wrote:
> > Is this an OA TC6 device? At a quick look it does appear to
> > be. Please make use of the framework Microchip is developing:
> >
> > https://lore.kernel.org/netdev/20230908142919.14849-4-Parthiban.Veerasooran@microchip.com/T/
>
> Yes it is. I wasn't aware of Microchip's work. Thanks for pointing it out.
I guess this patch is going to change a lot in future revisions...
Please double check the code with checkpatch before the next
submission, there are a few things that could be improved.
Specifically, avoid c++ style comments, and avoid using multiple label
names to jump into the same location - selecting the label name as the
target action will make the code more clear.
Thanks,
Paolo
prev parent reply other threads:[~2023-09-19 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 6:59 [PATCH 4/4] net/onsemi: Add NCN26010 driver Jay Monkman
2023-09-18 16:00 ` Andrew Lunn
2023-09-19 2:54 ` Jay Monkman
2023-09-19 9:47 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f79b0d4b9409a223f03c0b36b3544ce1389a500.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=Arndt.Schuebel@onsemi.com \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=jtm@lopingdog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).