From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: ty <zonyitoo@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Peter Geis <pgwipeout@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
DHDAXCW <lasstp5011@gmail.com>
Subject: Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1
Date: Wed, 21 Dec 2022 12:41:10 +0100 [thread overview]
Message-ID: <3f7dc970-4cc0-7d8e-b33f-83c9dd368b11@linaro.org> (raw)
In-Reply-To: <CAMmci2UgwqDyPPJXwGRsMW1Y1Cy2c6LMybk+7v7pGz-LtYzGTw@mail.gmail.com>
On 21/12/2022 11:46, ty wrote:
> Dear Kozlowski,
>
> Sorry that we didn't fully get the idea in your previous comments.
>
>>
>> On 21/12/2022 06:52, Yuteng Zhong wrote:
>>> from: DHDAXCW <lasstp5011@gmail.com>
>>>
>>> LubanCat 1 is a Rockchip RK3566 SBC based
>>> is developed by EmbedFire Electronics Co., Ltd.
>>> Mini Linux Card Type Cheap Computer Development Board
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>>
>> Thank you.
>
> Your pervious comment were:
>
>> Please wrap commit message according to Linux coding style / submission
>> process:
>> https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
>
> So I think there must be something wrong in the message but I didn't
> notice. This message has a `from` line, and the body was wrapped at 75
> columns. Please help me make it better.
You do not wrap at 75, but at some other place. Just put it to editor
and check where is wrapping (count characters).
>
>
>
>>>
>>> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
>>> Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
>>> ---
>>> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> index 88ff4422a8c1..84d39a3a8843 100644
>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> @@ -781,6 +781,11 @@ properties:
>>> - const: rockchip,rk3568-bpi-r2pro
>>> - const: rockchip,rk3568
>>>
>>> + - description: EmbedFire LubanCat 1
>>> + items:
>>> + - const: embedfire,lubancat-1
>>> + - const: rockchip,rk3566
>>
>> Here as well.
>
> This change was addressing the previous comment in V2:
>
>> This is separate patch. Does not look like properly ordered. Don't add
>> stuff at the end of files/lists.
>
> The previous PATCH v2 merged changes in 3 diffent files:
>
> 1. arch/arm64/boot/dts/rockchip/Makefile
> 2. arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> 3. Documentation/devicetree/bindings/arm/rockchip.yaml
>
> What we do in this PATCH v4 was separated the 3 into a separated patch.
So how did you solve the comment "Does not look like properly ordered.
Don't add stuff at the end of files/lists."? What did you change to
solve it?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-21 11:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 5:46 [PATCH v4 1/2] arm64: dts: rockchip: Add EmbedFire LubanCat 1 Yuteng Zhong
2022-12-21 5:52 ` [PATCH v4 2/2] dt-bindings: arm: " Yuteng Zhong
2022-12-21 8:16 ` Krzysztof Kozlowski
2022-12-21 10:46 ` ty
2022-12-21 11:41 ` Krzysztof Kozlowski [this message]
2022-12-21 11:44 ` Heiko Stübner
2022-12-21 12:12 ` ty
2022-12-21 12:15 ` Krzysztof Kozlowski
2022-12-21 8:15 ` [PATCH v4 1/2] arm64: dts: " Krzysztof Kozlowski
2022-12-21 9:44 ` ty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f7dc970-4cc0-7d8e-b33f-83c9dd368b11@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lasstp5011@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zonyitoo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).