From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6A67C4332F for ; Wed, 21 Dec 2022 11:41:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234451AbiLULlQ (ORCPT ); Wed, 21 Dec 2022 06:41:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234274AbiLULlP (ORCPT ); Wed, 21 Dec 2022 06:41:15 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C02F1837A for ; Wed, 21 Dec 2022 03:41:14 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id f34so7880742lfv.10 for ; Wed, 21 Dec 2022 03:41:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TFr+KkgF0f2zsju3on50AY6Jqv8wMu+vCgWh7SKVHvU=; b=a2EUh3XRGsS46OpUUPOejw8y2YIi+wRZ3E9NbbtKa16cGTd+sMjTKjBtYMbjgClYen +fLzFb+nskcXKLmkZaNaO1ieTjC+oJ3wy7O4NDF+1zmHsj0UFJBGRaxsxxjHm2Yrr7J/ HD/Y25cJ58bdyREnEe1nqQJQsBPe03KSi5r2ovgkObqPEBGGvQKY5Oj5nUOHlPp9e6Ly reFgdBt6JNfcY4LfLAoObxVIG0a8qYY4XQkCM0vIKeD+uAsmm47CgeFDTUI/Drrp4+Jw cww7q/I/Ds/Rw7sa+vjwQS2GQzZEbwHWGG22HCGeJknxoJYOfvuhzNza/DEpSqvag4BG xkLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TFr+KkgF0f2zsju3on50AY6Jqv8wMu+vCgWh7SKVHvU=; b=CaW/f55Cx6s9ODNttpP6XGqvPabZCr4oq8GzVrBdJyAJLdPO7MN09v/+4dhu86Z3qw MB6+i+Cj4MkEqnW7LGjFkSN0f4O1O75DnX9XlfDBLBUBkQ22AB+sTvO292O4OpxIXDBl x1eeksrPk1EDsDcQCtXPHkIaFXXMo5dS+jLRudmbOmba8FnRmoG+gVn7gdDdbXAZ5LlM UJppKCDkX94kYOwU3d+CYjRte0GvKbdXk06OmXUv2RBtkZ33IIcK+1zK4McKJxdLuJ/a X9h+2GCE6mKiSn+tPEZ+RNsshtgKtnRSYiFLlTMcbjJ3bZkfaVyuiPdtkFidPaB8xR0F uNFQ== X-Gm-Message-State: AFqh2krARda/DwnbkcTE3geeCyfSOcPBNiRYpi3X9VZN6j1llUDU83MV wxNvZmQc6SBf+i5w1LecqjVzpA== X-Google-Smtp-Source: AMrXdXsyPsMudczLvkigBGwO5mqibV7RZCAK5DqU/SA/VLHDDLkZTKPd3hjMSTk2tDvZ0oatgeXkNw== X-Received: by 2002:a05:6512:3e0c:b0:4b5:a5c7:3286 with SMTP id i12-20020a0565123e0c00b004b5a5c73286mr681061lfv.9.1671622872355; Wed, 21 Dec 2022 03:41:12 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id f14-20020a056512360e00b004b551cdfe13sm1800382lfs.279.2022.12.21.03.41.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 03:41:11 -0800 (PST) Message-ID: <3f7dc970-4cc0-7d8e-b33f-83c9dd368b11@linaro.org> Date: Wed, 21 Dec 2022 12:41:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1 Content-Language: en-US To: ty Cc: Heiko Stuebner , Rob Herring , Peter Geis , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, DHDAXCW References: <5a7907e3-f79e-5de9-ed1b-ec24ea52c437@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/12/2022 11:46, ty wrote: > Dear Kozlowski, > > Sorry that we didn't fully get the idea in your previous comments. > >> >> On 21/12/2022 06:52, Yuteng Zhong wrote: >>> from: DHDAXCW >>> >>> LubanCat 1 is a Rockchip RK3566 SBC based >>> is developed by EmbedFire Electronics Co., Ltd. >>> Mini Linux Card Type Cheap Computer Development Board >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my >> feedback got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all >> requested changes or keep discussing them. >> >> Thank you. > > Your pervious comment were: > >> Please wrap commit message according to Linux coding style / submission >> process: >> https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > So I think there must be something wrong in the message but I didn't > notice. This message has a `from` line, and the body was wrapped at 75 > columns. Please help me make it better. You do not wrap at 75, but at some other place. Just put it to editor and check where is wrapping (count characters). > > > >>> >>> Signed-off-by: Yuteng Zhong >>> Signed-off-by: DHDAXCW >>> --- >>> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml >>> index 88ff4422a8c1..84d39a3a8843 100644 >>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >>> @@ -781,6 +781,11 @@ properties: >>> - const: rockchip,rk3568-bpi-r2pro >>> - const: rockchip,rk3568 >>> >>> + - description: EmbedFire LubanCat 1 >>> + items: >>> + - const: embedfire,lubancat-1 >>> + - const: rockchip,rk3566 >> >> Here as well. > > This change was addressing the previous comment in V2: > >> This is separate patch. Does not look like properly ordered. Don't add >> stuff at the end of files/lists. > > The previous PATCH v2 merged changes in 3 diffent files: > > 1. arch/arm64/boot/dts/rockchip/Makefile > 2. arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts > 3. Documentation/devicetree/bindings/arm/rockchip.yaml > > What we do in this PATCH v4 was separated the 3 into a separated patch. So how did you solve the comment "Does not look like properly ordered. Don't add stuff at the end of files/lists."? What did you change to solve it? Best regards, Krzysztof