From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 159B6C433EF for ; Mon, 20 Jun 2022 07:35:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238369AbiFTHfl (ORCPT ); Mon, 20 Jun 2022 03:35:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239353AbiFTHfk (ORCPT ); Mon, 20 Jun 2022 03:35:40 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A517AEE13 for ; Mon, 20 Jun 2022 00:35:39 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id e40so1305007eda.2 for ; Mon, 20 Jun 2022 00:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LK+h2iGp+FEdq5egGWt8aFfxmV7BDPBoOQ4aISdjxsw=; b=dR2FYV+L/1fAtQC91SldjEDV5m2KbV+omB84RliOqB9SF54DIX6B/WK2iZizEMpVZT L86d5D0lDyYoQVnZRPSJUFQ5Ne+KsAHajW5Kco24dXJHFk1ThMEgs9LS+oET/xIq6ZRB /4Z1H8OvK9/1q+fx3cB0b3Zdv6/rWpscTAswKAEJa918sbBLLMisvdWmPY3awoRjE91W grlz+Rqy0B7u6DtRUVTgy5UPRmL7nSCIEsK/xKNBdeTn9ZkaqFME+qKXLxxna5vHrBdJ o5NdUZKHXDie0SN0ESBQ44+A0X2LYA8uJ9WtF0np5k7AhAbKHbidzCz7K+iJQW+o5nqe olhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LK+h2iGp+FEdq5egGWt8aFfxmV7BDPBoOQ4aISdjxsw=; b=AjSJBchjP5Vtk1E1IA73BEQUJwKOmJqT0Gy8OVEO1ZU+I446WGEAwvDJhnZpCnR6KW SESktK7Oero14fKDnHvKEo/0Wa108Muc31c7LK851AwlZs17O3kU6v9sNbARgT6XSIKs VY3a/k+KeATGWwjMmjxZtuyb0gW9dlaO/3Zz5eqtkKKf6zBHgSbSwofi2UYNteZRL139 +uU2reLGZ7y7BlpzkXMfXQQrCVo7sUTpxGpvyy+n33IrsNLARQ5NLCYAoYyaFbX8BZuo ZhoC/oIvdlluHtmqo8Fn2fRCFY/wBCZdsKrYfUAKB2ETiZpRFeMwTVgzyYioGqyxfh3X GXXA== X-Gm-Message-State: AJIora+ey9z5x9rWRSfghxlVVw0rVx1eTG9FU29n5/sRx4FE5uGkOhZI XorPF7xU/oneRZkXKcjWkbfDvg== X-Google-Smtp-Source: AGRyM1vQz+p3dzznqsCkDc567/s1M7YN/IdCOaWjkzpxc4fFrcYHL7hmiHyPBFESeaSj77W2DDl1gg== X-Received: by 2002:a05:6402:24a4:b0:434:e43e:2462 with SMTP id q36-20020a05640224a400b00434e43e2462mr28012497eda.312.1655710538202; Mon, 20 Jun 2022 00:35:38 -0700 (PDT) Received: from [192.168.0.206] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id y3-20020a056402358300b0042dc25fdf5bsm9685616edc.29.2022.06.20.00.35.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jun 2022 00:35:37 -0700 (PDT) Message-ID: <3f805983-47c0-9be1-f221-4cd23b847018@linaro.org> Date: Mon, 20 Jun 2022 09:35:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] dt-bindings: phy: Add Freescale i.MX8qm Mixel LVDS PHY binding Content-Language: en-US To: Liu Ying , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com References: <20220618092201.3837791-1-victor.liu@nxp.com> <20220618092201.3837791-2-victor.liu@nxp.com> <89a29795e918343583f45b0f8a65a002592f8b15.camel@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <89a29795e918343583f45b0f8a65a002592f8b15.camel@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/06/2022 05:06, Liu Ying wrote: > On Sun, 2022-06-19 at 14:11 +0200, Krzysztof Kozlowski wrote: >> On 18/06/2022 11:22, Liu Ying wrote: >>> This patch adds bindings for Mixel LVDS PHY found on >>> Freescale i.MX8qm SoC. >>> >>> Signed-off-by: Liu Ying >>> --- >>> .../bindings/phy/mixel,lvds-phy.yaml | 64 >>> +++++++++++++++++++ >>> 1 file changed, 64 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/phy/mixel,lvds-phy.yaml >> >>> diff --git a/Documentation/devicetree/bindings/phy/mixel,lvds- >>> phy.yaml b/Documentation/devicetree/bindings/phy/mixel,lvds- >>> phy.yaml >>> new file mode 100644 >>> index 000000000000..de964ffb9356 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/phy/mixel,lvds-phy.yaml >>> @@ -0,0 +1,64 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: >>> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fphy%2Fmixel%2Clvds-phy.yaml%23&data=05%7C01%7Cvictor.liu%40nxp.com%7Cb68f9012ddcc44bc10cd08da51ece7f7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637912375188731290%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MdBILPYmfYeWeCXXNxy1mu1NcU0b6EW3QztYc294dd4%3D&reserved=0 >>> +$schema: >>> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cvictor.liu%40nxp.com%7Cb68f9012ddcc44bc10cd08da51ece7f7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637912375188731290%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MhHwku8rbDLAZAQh1T9CGFULMkk5MaNoj3LQnQJ6VXM%3D&reserved=0 >>> + >>> +title: Mixel LVDS PHY for Freescale i.MX8qm SoC >> >> If Mixel is a vendor, it needs it's vendor prefix documented and used >> in >> compatible. Filename should match compatible. If it is not a vendor, >> then filename should be "fsl,imx8qm-lvds-phy.yaml" > > Mixel is a vendor. I'll document the vendor prefix and set > 'fsl,imx8qm-lvds-phy' and 'mixel,lvds-phy' as compatible's enum. > I'll keep the filename as-is. mixel,lvds-phy is not a good compatible (and filename) because it is not specific about component version. Please use specific compatibles only thus also specific filename (filename should match first compatible). Best regards, Krzysztof