From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 508C7C3F2D2 for ; Mon, 2 Mar 2020 06:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24AC624695 for ; Mon, 2 Mar 2020 06:36:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="QyDveerB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726300AbgCBGgR (ORCPT ); Mon, 2 Mar 2020 01:36:17 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:23069 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726263AbgCBGgR (ORCPT ); Mon, 2 Mar 2020 01:36:17 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1583130976; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=YYalt6l/N7I/mSLT1TfY3UB/16G6fmRPNEGmAhNeO4I=; b=QyDveerBgxzE2kFNBna3YyvzG62yX7DX0JfHpGt/AeRZ3fcXyuLEGQnoqm13I1KBqA04N45o +tAtWN+ltSZW1XxJZ7nHEmER71SbjgNuPoOMP0z10izJ2TK6Fx9dNaOgeNNfhMgK0yAUwGO/ ppDtqY3WaNkzwOjYexDa2IwwdvM= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e5ca950.7ff8cb975340-smtp-out-n02; Mon, 02 Mar 2020 06:36:00 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6CC71C4479F; Mon, 2 Mar 2020 06:35:59 +0000 (UTC) Received: from [10.204.67.17] (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: smasetty) by smtp.codeaurora.org (Postfix) with ESMTPSA id C6A9CC43383; Mon, 2 Mar 2020 06:35:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C6A9CC43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=smasetty@codeaurora.org Subject: Re: [PATCH] dt-bindings: arm-smmu: update the list of clocks To: Rob Herring Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Doug Anderson , Bjorn Andersson , Matthias Kaehlcke , dri-devel@freedesktop.org, linux-arm-msm , freedreno , saiprakash.ranjan@codeaurora.org References: <1582186342-3484-1-git-send-email-smasetty@codeaurora.org> <1582186342-3484-2-git-send-email-smasetty@codeaurora.org> <20200220203509.GA14697@bogus> <6a7c1f39-a85f-4a99-fed3-71001bdb6128@codeaurora.org> From: Sharat Masetty Message-ID: <3f9ae835-5146-d5db-1caf-01ede5bc9a1f@codeaurora.org> Date: Mon, 2 Mar 2020 12:05:53 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2/26/2020 8:03 PM, Rob Herring wrote: > On Wed, Feb 26, 2020 at 5:17 AM Sharat Masetty wrote: >> >> On 2/21/2020 2:05 AM, Rob Herring wrote: >>> On Thu, 20 Feb 2020 13:42:22 +0530, Sharat Masetty wrote: >>>> This patch adds a clock definition needed for powering on the GPU TBUs >>>> and the GPU TCU. >>>> >>>> Signed-off-by: Sharat Masetty >>>> --- >>>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>> My bot found errors running 'make dt_binding_check' on your patch: >>> >>> Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node >>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clock-names: ['bus', 'iface'] is too short >>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clocks: [[4294967295, 123], [4294967295, 124]] is too short >>> >>> See https://patchwork.ozlabs.org/patch/1241297 >>> Please check and re-submit. >> Hi Rob, These issues seem to be from the original code and not related >> to my patch. Are these going to be blocking errors? > There are no errors in this binding in mainline. You've added a 3rd > clock when all the existing users have exactly 2 clocks. Rob, Adding something like the following seems to be solving the bot errors, but I am not certain if this is the right way to address this issue. Can you please comment?    clock-names: +    minItems: 2 +    maxItems: 3      items:        - const: bus        - const: iface +      - const: mem_iface_clk    clocks: +    minItems: 2 +    maxItems: 3      items:        - description: bus clock required for downstream bus access and for the            smmu ptw        - description: interface clock required to access smmu's registers            through the TCU's programming interface. +      - description: core clock required for the GPU SMMU TBUs and the GPU TCU. > > Rob > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel