From: Markus Elfring <Markus.Elfring@web.de>
To: Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Chancel Liu <chancel.liu@nxp.com>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
Jonathan Downing <jonathan.downing@nautel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Rob Herring <robh@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Takashi Iwai <tiwai@suse.com>, Vladimir Zapolskiy <vz@mleia.com>
Subject: Re: [PATCH v3 4/4] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs
Date: Mon, 17 Jun 2024 21:30:11 +0200 [thread overview]
Message-ID: <3fb7f6db-6822-413e-9aa3-953a5e3cd566@web.de> (raw)
In-Reply-To: <20240614163500.386747-5-piotr.wojtaszczyk@timesys.com>
I suggest to specify email addresses for message recipients not only
in the header field “Cc”.
…
> +++ b/sound/soc/fsl/lpc3xxx-i2s.c
> @@ -0,0 +1,393 @@
…
> +static int lpc3xxx_i2s_startup(struct snd_pcm_substream *substream, struct snd_soc_dai *cpu_dai)
> +{
…
> + int ret = 0;
> +
> + mutex_lock(&i2s_info_p->lock);
…
> +lpc32xx_unlock:
> + mutex_unlock(&i2s_info_p->lock);
> + return ret;
> +}
…
Would you become interested to apply a statement like “guard(mutex)(&i2s_info_p->lock);”?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L196
Regards,
Markus
next prev parent reply other threads:[~2024-06-17 19:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs>
2024-06-11 9:47 ` [Patch v2 1/2] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs Piotr Wojtaszczyk
2024-06-11 9:47 ` [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding Piotr Wojtaszczyk
2024-06-11 10:18 ` Krzysztof Kozlowski
2024-06-12 8:02 ` Piotr Wojtaszczyk
2024-06-13 6:11 ` Krzysztof Kozlowski
2024-06-11 10:37 ` Mark Brown
2024-06-11 10:45 ` Krzysztof Kozlowski
2024-06-12 8:06 ` Piotr Wojtaszczyk
2024-06-13 6:11 ` Krzysztof Kozlowski
2024-06-11 11:31 ` Rob Herring (Arm)
2024-06-11 10:15 ` [Patch v2 1/2] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs Krzysztof Kozlowski
2024-06-12 7:48 ` Piotr Wojtaszczyk
2024-06-11 10:36 ` Mark Brown
2024-06-12 7:54 ` Piotr Wojtaszczyk
2024-06-14 16:24 ` Piotr Wojtaszczyk
2024-06-14 16:42 ` Mark Brown
2024-06-14 16:46 ` Piotr Wojtaszczyk
2024-06-14 16:51 ` Mark Brown
2024-06-14 16:34 ` [PATCH v3 0/4] Add audio support for LPC32XX CPUs Piotr Wojtaszczyk
2024-06-14 16:34 ` [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding Piotr Wojtaszczyk
2024-06-15 10:01 ` Krzysztof Kozlowski
2024-06-17 9:33 ` Piotr Wojtaszczyk
2024-06-17 12:14 ` Krzysztof Kozlowski
2024-06-17 14:04 ` Piotr Wojtaszczyk
2024-06-17 15:48 ` Krzysztof Kozlowski
2024-06-17 16:30 ` Piotr Wojtaszczyk
2024-06-14 16:34 ` [PATCH v3 2/4] ARM: dts: lpc32xx: Add missing properties for the i2s interfaces Piotr Wojtaszczyk
2024-06-14 16:34 ` [PATCH v3 3/4] ARM: lpc32xx: Add pl08x virtual dma channels for spi and i2s Piotr Wojtaszczyk
2024-06-14 16:34 ` [PATCH v3 4/4] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs Piotr Wojtaszczyk
2024-06-17 19:30 ` Markus Elfring [this message]
2024-06-18 7:45 ` Piotr Wojtaszczyk
2024-06-14 16:43 ` [PATCH v3 0/4] Add audio support for LPC32XX CPUs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fb7f6db-6822-413e-9aa3-953a5e3cd566@web.de \
--to=markus.elfring@web.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chancel.liu@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan.downing@nautel.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=perex@perex.cz \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).