From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75212C83F16 for ; Tue, 29 Aug 2023 06:30:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233216AbjH2GaG (ORCPT ); Tue, 29 Aug 2023 02:30:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233715AbjH2G3z (ORCPT ); Tue, 29 Aug 2023 02:29:55 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 697251AD for ; Mon, 28 Aug 2023 23:29:46 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9a19bf6ab66so520511566b.3 for ; Mon, 28 Aug 2023 23:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693290585; x=1693895385; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VfulV8l9fAUi9Tsip5/92M0tbm/MGDJ64gWqHZKs5QM=; b=M6U9uxGnbQr/fqYwdYbCqGLGUC5TUD21umeX91HrRYhQ9ru4ZrV22Oc73gfV+qTpfr 7xrf8ZFp3iXsdNCL9aJs+1orL7o0WUwiM/7C/U1GpYfzEj2hKL4B3rkscQzmw0hL9kcd F+B0mr/KR0tu8xq/cbfrcyWYEiI8A9+IRlG4YYJjFt1xCFNZ6Xo6XU/LM7n29+9JSb0l jMdltpPxtOW5wPQkWFY5lgUW4HxkuKHrBFA5tsqR1D+J6j5PqiRmomqNTRqLTf0XF39Y QIgxnwhEkEgqQc3jKhkzwSpJ2uuPpfX5ulMqOkbRSriLqBkx67qgLplaaW1+G0Jd9XN6 JY/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693290585; x=1693895385; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VfulV8l9fAUi9Tsip5/92M0tbm/MGDJ64gWqHZKs5QM=; b=mIffs5rFtIty0RGuKFVzuDzKekFlJYhhzdBQnVVqalDWpMQ6xDTbtjQp4ePR4Sdxyg IG+rm69Lh2ANkMMp7tUiILozE5g776yvOhG6CS+q3pB46yX216wX4NP1vinsXgSumvnf 2mzCm8nhBmDQ+9aEJ0S8x2cq5mgGLumlCAubiJf5DhR1GJ1SaGU4RhBHaD76wx74q9l/ gslFdLXT/6jqTQFZoC6PjIPPKJFbuaPl5qCMMsW2Jkq05PAj0Mhavr1QfCWaUGoFfPhQ P+ReB22AZEtEGEtKLOBQZLQD07QUavOj/eD/Q7kFeArp/buTFYUAZPzHu+y00IUrXzpA FvQg== X-Gm-Message-State: AOJu0YwDEw1fU/vHFD5HCtoG8pMy6X+Ws6FErRn81zI6nKP+kPnBr6oj 6FbCX6jEj6sEI2tZnfjJD0AuHQ== X-Google-Smtp-Source: AGHT+IHmnbiTbRrVI1+kiRm4p8e06XXGWlBZtkv3p5iM1pfrWN1Ql5/ryaWvi4l3r6rYzjx7fJXLvw== X-Received: by 2002:a17:906:113:b0:9a2:120a:5779 with SMTP id 19-20020a170906011300b009a2120a5779mr11507129eje.60.1693290584856; Mon, 28 Aug 2023 23:29:44 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.196]) by smtp.gmail.com with ESMTPSA id k16-20020a170906971000b009a0955a7ad0sm5573160ejx.128.2023.08.28.23.29.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 23:29:44 -0700 (PDT) Message-ID: <3fd27e64-2221-ec38-1320-9ae966f998aa@linaro.org> Date: Tue, 29 Aug 2023 08:29:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/5] dt-bindings: soc: loongson,ls2k-pmc: Add missing compatible for Loongson-2K2000 Content-Language: en-US To: Binbin Zhou , Conor Dooley Cc: Binbin Zhou , Huacai Chen , Yinbo Zhu , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Huacai Chen , loongson-kernel@lists.loongnix.cn, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Xuerui Wang , loongarch@lists.linux.dev References: <54ee114c08f35ab8b5dc584fd76135ac9076f5a7.1693218539.git.zhoubinbin@loongson.cn> <20230828-shrewdly-payee-c5eb091a0417@spud> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/08/2023 05:21, Binbin Zhou wrote: > HI Conor: > > Thanks for your reply. > > On Mon, Aug 28, 2023 at 11:49 PM Conor Dooley wrote: >> >> On Mon, Aug 28, 2023 at 08:38:32PM +0800, Binbin Zhou wrote: >>> Document the Power Management Unit system controller compatible for >>> Loongson-2K2000. >>> >>> This is a missing compatible, now we add it. >>> >>> Signed-off-by: Binbin Zhou >>> --- >>> .../devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml b/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml >>> index da2dcfeebf12..7473c5659929 100644 >>> --- a/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml >>> +++ b/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml >>> @@ -15,6 +15,7 @@ properties: >>> - enum: >>> - loongson,ls2k0500-pmc >>> - loongson,ls2k1000-pmc >>> + - loongson,ls2k2000-pmc >> >> Same thing here as the driver patch, the pmc on this newly added SoC >> appears to use the same codepaths as the existing ones. Does it share a >> programming model & should there be a fallback compatible here? > > I noticed the guideline about fallback compatible: > > "DO use fallback compatibles when devices are the same as or a subset > of prior implementations." > > But in fact, ls2k0500/ls2k1000/ls2k2000 are independent, there is no subset. We do not consider here ls2k0500/ls2k1000/ls2k2000, but PMC in each of them. If they are independent, why would they use the same interface? > Can we define a "loongson,ls2k-pmc" superset for each ls2k SoC > compatible fallback. > > Such as: > > compatible: > oneOf: > - enum: > - loongson,ls2k0500-pmc > - loongson,ls2k1000-pmc > - loongson,ls2k2000-pmc > - const: loongson,ls2k-pmc This is discouraged. Use 0500 as fallback. Best regards, Krzysztof